From owner-cvs-all Thu Dec 19 16: 8:12 2002 Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 77A9437B405; Thu, 19 Dec 2002 16:08:10 -0800 (PST) Received: from canning.wemm.org (canning.wemm.org [192.203.228.65]) by mx1.FreeBSD.org (Postfix) with ESMTP id 29DD543ED8; Thu, 19 Dec 2002 16:08:10 -0800 (PST) (envelope-from peter@wemm.org) Received: from wemm.org (localhost [127.0.0.1]) by canning.wemm.org (Postfix) with ESMTP id 139972A7EA; Thu, 19 Dec 2002 16:08:10 -0800 (PST) (envelope-from peter@wemm.org) X-Mailer: exmh version 2.5 07/13/2001 with nmh-1.0.4 To: Bruce Evans Cc: "David O'Brien" , Poul-Henning Kamp , cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/boot/i386/boot2 Makefile boot1.s In-Reply-To: <20021217071156.H17797-100000@gamplex.bde.org> Date: Thu, 19 Dec 2002 16:08:10 -0800 From: Peter Wemm Message-Id: <20021220000810.139972A7EA@canning.wemm.org> Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG Bruce Evans wrote: > On Mon, 16 Dec 2002, David O'Brien wrote: > > > On Sun, Dec 15, 2002 at 08:31:45PM +1100, Bruce Evans wrote: > > > Please remove the alignment hacks (Makefile rev.1.25) while you are there . > > > Breakage of -[fm]align-* seems to have been fixed in gcc, so the hacks > > > make no difference except to reduce the size of boot2.o's data by 3 bytes > > > (I think the 3 bytes is wasted at link time). > > > > I'd rather leave them in to get the 3 bytes -- believe it or not it has > > made a difference in the past. > > It doesn't any difference because the 3 bytes is wasted at link time. > The data section has size 29, but sections are padded to 4-byte boundaries, > at least for ELF objects with the default linker scripts, so 29 becomes 32 > the same as if it had been padded internally for aligment. In my case, it was a *final* object size difference of 3 bytes in /boot/ boot2. I found that turning off the sed caused quite a bit of bloat, so obviously we dont have all the necessary -[fm]align-*'s in the Makefile that you have. Cheers, -Peter -- Peter Wemm - peter@wemm.org; peter@FreeBSD.org; peter@yahoo-inc.com "All of this is for nothing if we don't go to the stars" - JMS/B5 To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message