From owner-freebsd-arch@FreeBSD.ORG  Fri May 11 23:43:46 2007
Return-Path: <owner-freebsd-arch@FreeBSD.ORG>
X-Original-To: arch@FreeBSD.org
Delivered-To: freebsd-arch@FreeBSD.ORG
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id B7EA916A403;
	Fri, 11 May 2007 23:43:46 +0000 (UTC)
	(envelope-from sean-freebsd@farley.org)
Received: from mail.farley.org (farley.org [67.64.95.201])
	by mx1.freebsd.org (Postfix) with ESMTP id 7CC7B13C458;
	Fri, 11 May 2007 23:43:46 +0000 (UTC)
	(envelope-from sean-freebsd@farley.org)
Received: from [192.168.1.211] ([192.168.1.211])
	by mail.farley.org (8.14.1/8.14.1) with ESMTP id l4BNhZSO072236;
	Fri, 11 May 2007 18:43:40 -0500 (CDT)
	(envelope-from sean-freebsd@farley.org)
Date: Fri, 11 May 2007 18:44:37 -0500 (CDT)
From: "Sean C. Farley" <sean-freebsd@farley.org>
To: Andrey Chernov <ache@FreeBSD.org>
In-Reply-To: <20070511003443.GA6422@nagual.pp.ru>
Message-ID: <20070511182126.U9004@baba.farley.org>
References: <20070504213312.GA33163@nagual.pp.ru>
	<20070504174657.D1343@thor.farley.org>
	<20070505213202.GA49925@nagual.pp.ru>
	<20070505163707.J6670@thor.farley.org>
	<20070505221125.GA50439@nagual.pp.ru>
	<20070506091835.A43775@besplex.bde.org>
	<20070508162458.G6015@baba.farley.org>
	<20070508222521.GA59534@nagual.pp.ru>
	<20070509200000.B56490@besplex.bde.org>
	<20070510184447.H4969@baba.farley.org>
	<20070511003443.GA6422@nagual.pp.ru>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed
Cc: Daniel Eischen <deischen@FreeBSD.org>, arch@FreeBSD.org
Subject: Re: HEADS DOWN
X-BeenThere: freebsd-arch@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Discussion related to FreeBSD architecture <freebsd-arch.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-arch>,
	<mailto:freebsd-arch-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-arch>
List-Post: <mailto:freebsd-arch@freebsd.org>
List-Help: <mailto:freebsd-arch-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-arch>,
	<mailto:freebsd-arch-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 11 May 2007 23:43:46 -0000

On Fri, 11 May 2007, Andrey Chernov wrote:

> On Thu, May 10, 2007 at 06:58:45PM -0500, Sean C. Farley wrote:
>>  Would there be any other changes anybody can see need to be made?  What
>>  type of testing would be desired?  The regression tests I wrote provide
>>  a good basic test.
>
> I worry about this sort of things
> errx(EXIT_FAILURE, "environ corrupt");
>
> There is no mention anywhere that *env() functions can exit the
> program.  Moreover some programs in theory can temprorarily put
> incorrect values into environment via putenv() after-modification or
> direct environ assignments for their own reasons.
>
> I suggest to change errx() to warnx()+return(failure).

No need to worry any longer; I changed them into warnx().  What value
should I give errno?  I do not want the program to receive a random
error code.  The first warnx() could be EINVAL.  The second warnx()
would be a coding error on my part.  EDOOFUS would fit.  :)  I know I
should not use it.  EINVAL?

Sean
-- 
sean-freebsd@farley.org