From owner-svn-src-all@freebsd.org Sun Mar 12 01:55:39 2017 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 24663D06A0F; Sun, 12 Mar 2017 01:55:39 +0000 (UTC) (envelope-from cse.cem@gmail.com) Received: from mail-wr0-f180.google.com (mail-wr0-f180.google.com [209.85.128.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id B99ED14C8; Sun, 12 Mar 2017 01:55:38 +0000 (UTC) (envelope-from cse.cem@gmail.com) Received: by mail-wr0-f180.google.com with SMTP id l37so84824730wrc.1; Sat, 11 Mar 2017 17:55:38 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:reply-to:in-reply-to:references :from:date:message-id:subject:to:cc; bh=QsQn46hoXATFR5tZ3TsWMamSuz6ZD5C6ZqZKOBZYQYE=; b=DxahLPlRZh6ZwFNU1Xe+Y+QXueDihaguoyCaGyGhkhKglMBvWr6SBdnoVIPXg5cdj3 sm9kUKmUVoQ8boz3MU4pzoPyQc3vNzoaN56ZOTe/WNEy4XYMFQskQFOSc15UYI1y+uIp iSA3lZKzGzmQk+Uaba7URMWckOWtvJhmMfxrJh3QHsNwpJ85+eMc5J5E1DHqYsyQo6ov DrZJxZL1r4CsubXsx86Ly/k24GreKg6LK34Ni43agsmlh5Z/Wn5iary2QwFIbFdJT+YK 4buLRERXo/TA0nwQ34fq/ZWha/kRUn8NLDie9PtEbBh5ijbvkRm0W4nfrsxu9R6tC51B kW1g== X-Gm-Message-State: AMke39nKzfEQMVo6K8PAGy4K7GNC7ltyhG0CNHz8IA7Tzi8nQ5HLcp3PrwnDHZfjR1xqoQ== X-Received: by 10.223.179.216 with SMTP id x24mr21995186wrd.171.1489283422813; Sat, 11 Mar 2017 17:50:22 -0800 (PST) Received: from mail-wr0-f180.google.com (mail-wr0-f180.google.com. [209.85.128.180]) by smtp.gmail.com with ESMTPSA id z70sm19341235wrc.2.2017.03.11.17.50.22 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 11 Mar 2017 17:50:22 -0800 (PST) Received: by mail-wr0-f180.google.com with SMTP id u48so84826987wrc.0; Sat, 11 Mar 2017 17:50:22 -0800 (PST) X-Received: by 10.223.133.6 with SMTP id 6mr22356358wrh.57.1489283422477; Sat, 11 Mar 2017 17:50:22 -0800 (PST) MIME-Version: 1.0 Reply-To: cem@freebsd.org Received: by 10.80.169.4 with HTTP; Sat, 11 Mar 2017 17:50:21 -0800 (PST) In-Reply-To: <201703110436.v2B4aF6Z037011@repo.freebsd.org> References: <201703110436.v2B4aF6Z037011@repo.freebsd.org> From: Conrad Meyer Date: Sat, 11 Mar 2017 17:50:21 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: svn commit: r315049 - head/usr.bin/vmstat To: Marcelo Araujo Cc: src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset=UTF-8 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 12 Mar 2017 01:55:39 -0000 Hi Marcelo, Should we add WARNS=2 in vmstat's Makefile so that developers notice when they break warnings at that level? Thanks, Conrad On Fri, Mar 10, 2017 at 8:36 PM, Marcelo Araujo wrote: > Author: araujo > Date: Sat Mar 11 04:36:15 2017 > New Revision: 315049 > URL: https://svnweb.freebsd.org/changeset/base/315049 > > Log: > Bring back the cast removed in my previous commit to allow us build vmstat > with WARNS 2. This cast was first introduced at r87690. > > Reported by: bde, pfg and ngie > MFC after: 3 weeks. > > Modified: > head/usr.bin/vmstat/vmstat.c > > Modified: head/usr.bin/vmstat/vmstat.c > ============================================================================== > --- head/usr.bin/vmstat/vmstat.c Sat Mar 11 04:03:13 2017 (r315048) > +++ head/usr.bin/vmstat/vmstat.c Sat Mar 11 04:36:15 2017 (r315049) > @@ -288,13 +288,13 @@ retry_nlist: > namelist[X_SUM].n_name = "_cnt"; > goto retry_nlist; > } > - for (c = 0; c < nitems(namelist); c++) > + for (c = 0; c < (int)(nitems(namelist)); c++) > if (namelist[c].n_type == 0) > bufsize += strlen(namelist[c].n_name) + 1; > bufsize += len + 1; > buf = bp = alloca(bufsize); > > - for (c = 0; c < nitems(namelist); c++) > + for (c = 0; c < (int)(nitems(namelist)); c++) > if (namelist[c].n_type == 0) { > xo_error(" %s", > namelist[c].n_name); >