From nobody Thu May 28 14:36:59 2026 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4gR8Fm0J0fz6fqHN for ; Thu, 28 May 2026 14:37:00 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R13" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4gR8Fl6cbpz3kX9 for ; Thu, 28 May 2026 14:36:59 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1779979019; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=4ZG3MhVxD9r5dp2AouwByMWLd1lpLTGPHMD1c4Lam74=; b=V82i3sstPE3USJOuRvcfjyOXLGAYkpU7SFS1Q+6IdQxTcJDV8Pn1kFm0milHtnYOBpvPIg tGqFm5BX9aSq+jtZxR9QSl0dvj+i1M09UNRmnfUPWyj0vF1ZhI4YRQRYYVx9w4W41ztFBe YbN5yUT/t3ZhZ2LBPO85l/dIhTKaDNbKBg+18MgdqzJmtnICQrB2dpowAYYNsc7byrehwM LQgclEk7UzZ8cYLNuZsQB+/f2Ck5q9QPIfjkUGiuaBGCVQXKTj3BbwvAoTCmodifhg9wKm +wR8utcS9CUs6oZY0j030i3sZ40grSlfXbIwi9sqAvcSa6YiQts0uNODUilsxQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1779979019; a=rsa-sha256; cv=none; b=DJiv0+jqdES4NvnmmVcwof66sd3lrJZq8S8D1QHyXKR+JQrznEjjxDuW4mQp33TmIzvOa4 jAqGULYDCM42lO8uPDEwhXevpraugCfpD/9UaT+K9uctWQMRBqwmOPDckymYQeqf+BVSuG Nt5ImOfY0gdAk6ZZoCql5LcGyEhfWcT6QKIuzpBztDd7GspoBsDrnxtvO+6f8mybCdPGJ9 pd+5qPsiyw0fuXYPejesSsV7nTt8ImFlGKDOY2DTU3VOLVUa9Ci0f1JHL0GCRT++JKSjzQ gN6SF8kRb+7DP2efjD1JZSqecMw4jtGvpY+oQQ/DPY0EK6b4DwuWRZcdoFV0vg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1779979019; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=4ZG3MhVxD9r5dp2AouwByMWLd1lpLTGPHMD1c4Lam74=; b=gvIsfUExQ/iCB9Lg9QYkmTmnkaOltqX+623uyCnSK9+LjpC2/VCwAOb4zNa2oOLdRiHKox KyLi5M8lvm6oyebWzGKXm2wlIms6rYAL9zxQC/rlDVYEv+Sqs0bx/8CRcHLDJrH8A4FWM6 4rOGeVqf0k1nqT3tZd0ug9tXRKVdr1K89hsEbKtMSba47Ba2p4UecnnNgJiGjM0qYw5XwT YDhyKuOxam1DQGmb31dOXG4aI7pNBINxYSILcWVIdHARfn/5xw5WfQJusC1ov73WEgJXQp 7upVHSlAMxgTqvydkK6SvJFdtPfzgTGA6pgUQhH2ocJCW8GBxKh8NT/PIIkS+A== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4gR8Fl5tpdzqZM for ; Thu, 28 May 2026 14:36:59 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 22f16 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Thu, 28 May 2026 14:36:59 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: ShengYi Hung Subject: git: df5e9e3da5b9 - main - usb: Add missing mtx lock and unlock in pushing dma queue List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: aokblast X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: df5e9e3da5b9b3fe63ed4aaaa19b824fd18ae0f2 Auto-Submitted: auto-generated Date: Thu, 28 May 2026 14:36:59 +0000 Message-Id: <6a18530b.22f16.2a0fd314@gitrepo.freebsd.org> The branch main has been updated by aokblast: URL: https://cgit.FreeBSD.org/src/commit/?id=df5e9e3da5b9b3fe63ed4aaaa19b824fd18ae0f2 commit df5e9e3da5b9b3fe63ed4aaaa19b824fd18ae0f2 Author: ShengYi Hung AuthorDate: 2026-05-28 08:42:11 +0000 Commit: ShengYi Hung CommitDate: 2026-05-28 14:36:10 +0000 usb: Add missing mtx lock and unlock in pushing dma queue Accessing usb_xfer_queue requires bus lock, we added this missing lock in here to prevent racing issue. Reviewed by: adrian MFC after: 2 weeks Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D57293 --- sys/dev/usb/usb_transfer.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/sys/dev/usb/usb_transfer.c b/sys/dev/usb/usb_transfer.c index 67745cf49397..d41121ed3a06 100644 --- a/sys/dev/usb/usb_transfer.c +++ b/sys/dev/usb/usb_transfer.c @@ -1889,8 +1889,10 @@ usbd_transfer_submit(struct usb_xfer *xfer) */ #if USB_HAVE_BUSDMA if (xfer->flags_int.bdma_enable) { + USB_BUS_LOCK(bus); /* insert the USB transfer last in the BUS-DMA queue */ usb_command_wrapper(&xfer->xroot->dma_q, xfer); + USB_BUS_UNLOCK(bus); return; } #endif