From owner-svn-src-head@freebsd.org Sun Sep 1 21:12:28 2019 Return-Path: Delivered-To: svn-src-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 659E5E6339; Sun, 1 Sep 2019 21:12:28 +0000 (UTC) (envelope-from cse.cem@gmail.com) Received: from mail-io1-f49.google.com (mail-io1-f49.google.com [209.85.166.49]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 46M5Wv4LSbz3MMb; Sun, 1 Sep 2019 21:12:27 +0000 (UTC) (envelope-from cse.cem@gmail.com) Received: by mail-io1-f49.google.com with SMTP id b136so1248475iof.3; Sun, 01 Sep 2019 14:12:27 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:reply-to :from:date:message-id:subject:to:cc; bh=ZuwUP04HEKnNPcZdMtZSZdOKzS2YB6kIJ5ufhi6c8gM=; b=p7UKD3TJPgsK3FfjNpCCy8fIRTSS67iU9MuYDaKY6bSr/SfDzCuG9S9G1k8rMH76yQ Ep1Mei/WZzi0jzUkqReF3gfPTIZQpAWDtH8qBCCiSmSLhIdgbx2mvnLGYVtZhLVmLNnJ gXqpRoc/3Mp6AiCWFP4CK7xYSchhOykJuFpJBELzbSemwuZTz9/qGP8hoCOKEy/9Tnrb MLM9466CRgG85qtBESaJB567WOr2WHklkjX3r6NRrbWzOyTk61nzrrPKN30X9+1qG9CB Iywh2vJz4ROheG0cnhNDdfTjGrXUXKIxX7TWPN6eb1DPh7AGCElc6Wv/Z49H9CiY/ZzR 5kPA== X-Gm-Message-State: APjAAAWQ717xjX7U43BK9wdnN6YtKbUHapZ1IM76QJF9KZcwWSP/WKs9 C6zvNCmXCX9u6bD3wRvjd2O1RpU4 X-Google-Smtp-Source: APXvYqxFfTl5/4hQwPRwN2n6bA6jC4OpWp0dV0N6D5MuDbnZBN4ZL/89amTw0SaMMSo3tUOy/kdZMw== X-Received: by 2002:a5d:8b47:: with SMTP id c7mr13015658iot.42.1567372346528; Sun, 01 Sep 2019 14:12:26 -0700 (PDT) Received: from mail-io1-f46.google.com (mail-io1-f46.google.com. [209.85.166.46]) by smtp.gmail.com with ESMTPSA id q5sm10987122iot.5.2019.09.01.14.12.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 01 Sep 2019 14:12:26 -0700 (PDT) Received: by mail-io1-f46.google.com with SMTP id f12so7869083iog.12; Sun, 01 Sep 2019 14:12:26 -0700 (PDT) X-Received: by 2002:a02:6d24:: with SMTP id m36mr28495390jac.87.1567372345968; Sun, 01 Sep 2019 14:12:25 -0700 (PDT) MIME-Version: 1.0 References: <201909011612.x81GC5DW097846@repo.freebsd.org> <201909011932.x81JWYts004074@slippy.cwsent.com> In-Reply-To: <201909011932.x81JWYts004074@slippy.cwsent.com> Reply-To: cem@freebsd.org From: Conrad Meyer Date: Sun, 1 Sep 2019 14:12:14 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: svn commit: r351659 - in head: contrib/libc++/include contrib/netbsd-tests/lib/libc/ssp gnu/lib/libssp include lib/libc/stdio To: Cy Schubert Cc: src-committers , svn-src-all , svn-src-head Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 46M5Wv4LSbz3MMb X-Spamd-Bar: ----- Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=pass (mx1.freebsd.org: domain of csecem@gmail.com designates 209.85.166.49 as permitted sender) smtp.mailfrom=csecem@gmail.com X-Spamd-Result: default: False [-5.50 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; FROM_NEQ_ENVFROM(0.00)[cem@freebsd.org,csecem@gmail.com]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; R_SPF_ALLOW(-0.20)[+ip4:209.85.128.0/17]; RCVD_TLS_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[freebsd.org]; HAS_REPLYTO(0.00)[cem@freebsd.org]; REPLYTO_ADDR_EQ_FROM(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; RCVD_COUNT_THREE(0.00)[4]; TO_MATCH_ENVRCPT_SOME(0.00)[]; TO_DN_ALL(0.00)[]; NEURAL_HAM_SHORT(-0.99)[-0.989,0]; RCVD_IN_DNSWL_NONE(0.00)[49.166.85.209.list.dnswl.org : 127.0.5.0]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; IP_SCORE(-2.51)[ip: (-6.87), ipnet: 209.85.128.0/17(-3.34), asn: 15169(-2.31), country: US(-0.05)]; FORGED_SENDER(0.30)[cem@freebsd.org,csecem@gmail.com]; MIME_TRACE(0.00)[0:+]; R_DKIM_NA(0.00)[]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US]; TAGGED_FROM(0.00)[] X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 01 Sep 2019 21:12:28 -0000 On Sun, Sep 1, 2019 at 12:32 PM Cy Schubert wrote: > > In message <201909011612.x81GC5DW097846@repo.freebsd.org>, Ed Maste writes: > > Author: emaste > > Date: Sun Sep 1 16:12:05 2019 > > New Revision: 351659 > > URL: https://svnweb.freebsd.org/changeset/base/351659 > > > > Log: > > libc: remove gets > > > > gets is unsafe and shouldn't be used (for many years now). Leave it in > > the existing symbol version so anything that previously linked aginst it > > still runs, but do not allow new software to link against it. > > > > (The compatability/legacy implementation must not be static so that > > the symbol and in particular the compat sym gets@FBSD_1.0 make it > > into libc.) > > > > PR: 222796 (exp-run) > > Reported by: Paul Vixie > > Reviewed by: allanjude, cy, eadler, gnn, jhb, kib, ngie (some earlie > > r) > > Relnotes: Yes > > Sponsored by: The FreeBSD Foundation > > Differential Revision: https://reviews.freebsd.org/D12298 > > > > Modified: > > head/contrib/libc++/include/cstdio > > head/contrib/netbsd-tests/lib/libc/ssp/h_gets.c > > head/gnu/lib/libssp/Makefile > > head/include/stdio.h > > head/lib/libc/stdio/fgets.3 > > head/lib/libc/stdio/gets.c > > head/lib/libc/stdio/stdio.3 > > Should we encourage the use of gets_s() in the man page or in other doc? > > This probably requires a __FreeBSD_version bump. > > > -- > Cheers, > Cy Schubert > FreeBSD UNIX: Web: http://www.FreeBSD.org > > The need of the many outweighs the greed of the few. > > >