From owner-freebsd-current Wed Jan 27 21:54:27 1999 Return-Path: Received: (from majordom@localhost) by hub.freebsd.org (8.8.8/8.8.8) id VAA17770 for freebsd-current-outgoing; Wed, 27 Jan 1999 21:54:27 -0800 (PST) (envelope-from owner-freebsd-current@FreeBSD.ORG) Received: from cimlogic.com.au (cimlog.lnk.telstra.net [139.130.51.31]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id VAA17765 for ; Wed, 27 Jan 1999 21:54:24 -0800 (PST) (envelope-from jb@cimlogic.com.au) Received: (from jb@localhost) by cimlogic.com.au (8.9.1/8.9.1) id QAA07918; Thu, 28 Jan 1999 16:58:06 +1100 (EST) (envelope-from jb) From: John Birrell Message-Id: <199901280558.QAA07918@cimlogic.com.au> Subject: Re: btokup() macro in sys/malloc.h In-Reply-To: <199901280540.WAA26288@mt.sri.com> from Nate Williams at "Jan 27, 1999 10:40:16 pm" To: nate@mt.sri.com (Nate Williams) Date: Thu, 28 Jan 1999 16:58:06 +1100 (EST) Cc: archie@whistle.com, wollman@khavrinen.lcs.mit.edu, current@FreeBSD.ORG X-Mailer: ELM [version 2.4ME+ PL43 (25)] MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG Nate Williams wrote: > > Anyway, if we're going to -Wall'ify the kernel (as we should) > > then we need to update sytle(9) to reflect that. > > > > In fact, style(9) should say: > > > > If at all possible, your code should compile without warnings > > when the gcc -Wall flag is given. > > I disagree. As has been shown many times in the past (and I suspect the > down-under constituent will show that at least a couple of the I think you must mean the "Sydney-down-under constituent". There *is* a difference. 8-) > 'warnings' fixes will be wrong and hide bogus code), making -Wall a goal > causes people to cover up bad code with bad casts and such. > > '-Wall' is *NOT* a good design goal. Fixing warnings with bad casts is a problem, sure, but asking people to write code without casts (if possible) that will compile cleanly with -Wall is a reasonable thing to ask IMO. In my experience, the resulting code tends to be more portable across architectures with different pointer/long sizes and endian-ness. Just my 0.02, and I hate style(9) anyway. -- John Birrell - jb@cimlogic.com.au; jb@freebsd.org http://www.cimlogic.com.au/ CIMlogic Pty Ltd, GPO Box 117A, Melbourne Vic 3001, Australia +61 418 353 137 To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message