From owner-freebsd-emulation@FreeBSD.ORG Fri Jun 12 16:23:26 2015 Return-Path: Delivered-To: vbox@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 6260ED76; Fri, 12 Jun 2015 16:23:26 +0000 (UTC) (envelope-from leonard.rucker@gmail.com) Received: from mail-qg0-x243.google.com (mail-qg0-x243.google.com [IPv6:2607:f8b0:400d:c04::243]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 1F645BBE; Fri, 12 Jun 2015 16:23:26 +0000 (UTC) (envelope-from leonard.rucker@gmail.com) Received: by qgdq107 with SMTP id q107so3426399qgd.3; Fri, 12 Jun 2015 09:23:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :content-type; bh=VtCn6mCmmmjZliwL4yM3yY82Bek1TgrDuoYcIXDMfrU=; b=mBy/kvBun/LVRd8dS86wB+wgs+j83+Wwg0BnfWEMNPUohFCVF8wqEpT2zDp04DiiIN MtyNyJdJe3swJJvYdZUYLS5I4jSbUOTZ5S3uXMg0JaTVKl4kWwjWVHGZuUDLbtnuDZra EAidtgrcva9vKv+cXwSNTiUygYAz9/XtEDIyVkYBad7Q98bXJdqtBXiYguSiJI3gHIHy CUIzjk8FCcjuCIHU6WM1/XcPFqCkGGjX9GY0e7gKKXQFTE3SzEAZvVfDFQJTLCgOols/ ybBStGO7HHyM600ydGAo/rWBbwiX+MkIqbwkQ+vP9FChvi+Rx942nHBIohd7Z7C/AUQT vxlQ== X-Received: by 10.55.17.75 with SMTP id b72mr31529631qkh.103.1434126205214; Fri, 12 Jun 2015 09:23:25 -0700 (PDT) MIME-Version: 1.0 References: <20150610194853.GF23380@dft-labs.eu> <5578AA88.6040200@FreeBSD.org> In-Reply-To: <5578AA88.6040200@FreeBSD.org> From: Leonard Rucker Date: Fri, 12 Jun 2015 16:23:14 +0000 Message-ID: Subject: Re: virtualbox kmod build fix after r284215 To: Jung-uk Kim , Mateusz Guzik , vbox@freebsd.org X-Mailman-Approved-At: Fri, 12 Jun 2015 16:24:49 +0000 Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.20 X-BeenThere: freebsd-emulation@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Development of Emulators of other operating systems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 12 Jun 2015 16:23:26 -0000 I noticed a problem after I updated to 10.1-STABLE r284253 where I couldn't boot. I found the problem was the the vbox kernel module. After I stopped loading it I was able to boot successfully. Will this change fix this or is there something else I need to do? Len On Wed, Jun 10, 2015 at 5:07 PM Jung-uk Kim wrote: > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA256 > > On 06/10/2015 15:48, Mateusz Guzik wrote: > > Hello, > > > > the following is needed since r284215 (__FreeBSD_version 1100077): > > > > --- ./src/VBox/Runtime/r0drv/freebsd/memobj-r0drv-freebsd.c.orig > > 2015-06-10 19:30:28.355276494 +0000 +++ > > ./src/VBox/Runtime/r0drv/freebsd/memobj-r0drv-freebsd.c 2015-06-10 > > 19:30:41.280304985 +0000 @@ -747,7 +747,7 @@ { /** @todo: is this > > needed?. */ PROC_LOCK(pProc); - AddrR3 = > > round_page((vm_offset_t)pProc->p_vmspace->vm_daddr + lim_max(pProc, > > RLIMIT_DATA)); + AddrR3 = > > round_page((vm_offset_t)pProc->p_vmspace->vm_daddr + > > lim_max_proc(pProc, RLIMIT_DATA)); PROC_UNLOCK(pProc); } else > > Committed (r389147), thanks! > > > Interestingly enough for some reason the build does not fail > > without the patch, even though resulting code is clearly broken as > > lim_max now expects a thread argument. > > Yes, kernel module build is very fragile ATM and it should be fixed. > > Jung-uk Kim > -----BEGIN PGP SIGNATURE----- > Version: GnuPG v2 > > iQEcBAEBCAAGBQJVeKqIAAoJEHyflib82/FG6RMH/i6o37JDe+CY/m3K9GOaL9LM > e6Rn65pMarZUeU3TvNchtqaK2SZF2gGo2b0CPnrRddE6Ufomm5molazoGcs9nSJX > MqCHs0bisg4zyo37JOHOWPQ5go/J6hfO1pPCGBhQ8E3j2BpyeRJykebnOwUQ9Tei > G7mTV78l0joEjkrxXt55TYuARtTuY8ISlyfzyXibghVm1meNvz0/CLcadgUkgn1a > H42XSsBpaJpSLrv8MW7+7rm8snc/Z3zWwd8vGHjRcUfQbyvPCMhMuLntMyW+t2yx > Eij4QYe+h2yfIXPW1M3h8amOCkMT8hJlQEfC9ZcroPjtIdanwv+6DuNWOfBLQMM= > =twB8 > -----END PGP SIGNATURE----- > _______________________________________________ > freebsd-emulation@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-emulation > To unsubscribe, send any mail to " > freebsd-emulation-unsubscribe@freebsd.org" >