From owner-svn-ports-all@FreeBSD.ORG  Sat Nov 24 09:09:04 2012
Return-Path: <owner-svn-ports-all@FreeBSD.ORG>
Delivered-To: svn-ports-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
 by hub.freebsd.org (Postfix) with ESMTP id 35EACFC5;
 Sat, 24 Nov 2012 09:09:04 +0000 (UTC)
 (envelope-from fluffy@fluffy.khv.ru)
Received: from forward7.mail.yandex.net (forward7.mail.yandex.net
 [IPv6:2a02:6b8:0:202::2])
 by mx1.freebsd.org (Postfix) with ESMTP id 6F7618FC13;
 Sat, 24 Nov 2012 09:09:03 +0000 (UTC)
Received: from smtp7.mail.yandex.net (smtp7.mail.yandex.net [77.88.61.55])
 by forward7.mail.yandex.net (Yandex) with ESMTP id ABB8B1C0C0A;
 Sat, 24 Nov 2012 13:08:52 +0400 (MSK)
Received: from smtp7.mail.yandex.net (localhost [127.0.0.1])
 by smtp7.mail.yandex.net (Yandex) with ESMTP id 518C4158035B;
 Sat, 24 Nov 2012 13:08:52 +0400 (MSK)
Received: from host85.static2.l2tp.ttkdv.ru (host85.static2.l2tp.ttkdv.ru
 [46.38.1.85])
 by smtp7.mail.yandex.net (nwsmtp/Yandex) with ESMTP id 8n08068c-8o0WAFaq;
 Sat, 24 Nov 2012 13:08:50 +0400
Message-ID: <50B08E77.80100@fluffy.khv.ru>
Date: Sat, 24 Nov 2012 20:08:07 +1100
From: Dima Panov <fluffy@fluffy.khv.ru>
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64;
 rv:17.0) Gecko/17.0 Thunderbird/17.0
MIME-Version: 1.0
To: "Jason E. Hale" <jhale@freebsd.org>
Subject: Re: svn commit: r307701 - head/graphics/vigra
References: <201211240225.qAO2PdBV045963@svn.freebsd.org>
 <23752824.Nt9BvllcTf@mocha.verizon.net>
In-Reply-To: <23752824.Nt9BvllcTf@mocha.verizon.net>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org,
 ports-committers@freebsd.org, Dima Panov <fluffy@freebsd.org>
X-BeenThere: svn-ports-all@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
Reply-To: fluffy@FreeBSD.org
List-Id: SVN commit messages for the ports tree <svn-ports-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-all>
List-Post: <mailto:svn-ports-all@freebsd.org>
List-Help: <mailto:svn-ports-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 24 Nov 2012 09:09:04 -0000

24.11.2012 17:17, Jason E. Hale пишет:
> On Saturday, November 24, 2012 02:25:38 Dima Panov wrote:
>> Author: fluffy
>> Date: Sat Nov 24 02:25:38 2012
>> New Revision: 307701
>> URL: http://svnweb.freebsd.org/changeset/ports/307701
>>
>> Log:
>>    - Force to use gcc46+ if CC is not Clang.
>>
>>    Feature safe:	yes
>>
>> Modified:
>>    head/graphics/vigra/Makefile
>>
>> Modified: head/graphics/vigra/Makefile
>> ============================================================================
>> == --- head/graphics/vigra/Makefile	Sat Nov 24 02:23:00 2012	(r307700) +++
>> head/graphics/vigra/Makefile	Sat Nov 24 02:25:38 2012	(r307701) @@ -56,6
>> +56,12 @@ PLIST_SUB+=	PYTHON="@comment "
>>
>>   .include <bsd.port.pre.mk>
>>
>> +# Check for clang, else use gcc46+
>> +CPP_check!=	${CPP} --version | tr -d '()'
>> +.if !${CPP_check:Mclang}
>> +USE_GCC=	4.6+
>> +.endif
>> +
> I think it would be better to avoid the '!=' expansion and check for
> clang/clang++ with something like this:
>
> .if ${CC:T:Mclang} != "clang" && ${CXX:T:Mclang++} != "clang++"
> USE_GCC=        4.6+
> .endif
>
This construction doesn't cover situation when cc = clang (-current, for 
example, where WITH_CLANG_IS_CC is default), so I've used own check..


-- 
Dima Panov (fluffy@FreeBSD.org)
(KDE, Office)@FreeBSD team

Facebook: http://www.facebook.com/fluffy.khv
IRC: fluffy@EFNet, fluffykhv@FreeNode
twitter: fluffy_khv | skype: dima.panov