Date: Sun, 26 Mar 2000 02:47:00 -0500 From: "C. Stephen Gunn" <csg@waterspout.com> To: Matt Dillon <dillon@FreeBSD.ORG> Cc: archie@FreeBSD.ORG, rwatson@FreeBSD.ORG, cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/sys/netinet if_ether.c Message-ID: <20000326024700.A3342@waterspout.com> In-Reply-To: <200003231859.KAA01229@freefall.freebsd.org>; from dillon@FreeBSD.ORG on Thu, Mar 23, 2000 at 10:59:00AM -0800 References: <200003231859.KAA01229@freefall.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Mar 23, 2000 at 10:59:00AM -0800, Matt Dillon wrote: > Fix parens in m_pullup() line in arp handling code. The code was > improperly doing the equivalent of (m = (function() == NULL)) instead > of ((m = function()) == NULL). > > This fixes a NULL pointer dereference panic with runt arp packets. While I understand this fix. I copied this check from the "recommended" procedure for calling m_pullup inside. There are several instances of missing parenthesis in sys/netgraph/*.c as well. Can I ask how you ran across the problem? (IE how you got a NULL mbuf pointer queue for ARPINTR?) Or just general code review.. - Steve To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20000326024700.A3342>