From owner-svn-src-head@freebsd.org Wed Sep 23 10:42:42 2020 Return-Path: Delivered-To: svn-src-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 62E663F5515; Wed, 23 Sep 2020 10:42:42 +0000 (UTC) (envelope-from mjg@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4BxFBB1ptBz4bBs; Wed, 23 Sep 2020 10:42:42 +0000 (UTC) (envelope-from mjg@FreeBSD.org) Received: from repo.freebsd.org (repo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:0]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 219FBF249; Wed, 23 Sep 2020 10:42:42 +0000 (UTC) (envelope-from mjg@FreeBSD.org) Received: from repo.freebsd.org ([127.0.1.37]) by repo.freebsd.org (8.15.2/8.15.2) with ESMTP id 08NAgfcF011892; Wed, 23 Sep 2020 10:42:41 GMT (envelope-from mjg@FreeBSD.org) Received: (from mjg@localhost) by repo.freebsd.org (8.15.2/8.15.2/Submit) id 08NAgfT1011891; Wed, 23 Sep 2020 10:42:41 GMT (envelope-from mjg@FreeBSD.org) Message-Id: <202009231042.08NAgfT1011891@repo.freebsd.org> X-Authentication-Warning: repo.freebsd.org: mjg set sender to mjg@FreeBSD.org using -f From: Mateusz Guzik Date: Wed, 23 Sep 2020 10:42:41 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: svn commit: r366069 - head/sys/kern X-SVN-Group: head X-SVN-Commit-Author: mjg X-SVN-Commit-Paths: head/sys/kern X-SVN-Commit-Revision: 366069 X-SVN-Commit-Repository: base MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 Sep 2020 10:42:42 -0000 Author: mjg Date: Wed Sep 23 10:42:41 2020 New Revision: 366069 URL: https://svnweb.freebsd.org/changeset/base/366069 Log: cache: clean up atomic ops on numneg and numcache - use subtract instead of adding -1 - drop the useless _rel fence Note this should be converted to a scalable scheme. Modified: head/sys/kern/vfs_cache.c Modified: head/sys/kern/vfs_cache.c ============================================================================== --- head/sys/kern/vfs_cache.c Wed Sep 23 09:59:06 2020 (r366068) +++ head/sys/kern/vfs_cache.c Wed Sep 23 10:42:41 2020 (r366069) @@ -841,7 +841,7 @@ cache_negative_insert(struct namecache *ncp) mtx_lock(&neglist->nl_lock); TAILQ_INSERT_TAIL(&neglist->nl_list, ncp, nc_dst); mtx_unlock(&neglist->nl_lock); - atomic_add_rel_long(&numneg, 1); + atomic_add_long(&numneg, 1); } static void @@ -887,7 +887,7 @@ cache_negative_remove(struct namecache *ncp) mtx_unlock(&neglist->nl_lock); if (hot_locked) mtx_unlock(&ncneg_hot.nl_lock); - atomic_subtract_rel_long(&numneg, 1); + atomic_subtract_long(&numneg, 1); } static void @@ -1030,7 +1030,7 @@ cache_zap_locked(struct namecache *ncp) counter_u64_add(numcachehv, -1); } } - atomic_subtract_rel_long(&numcache, 1); + atomic_subtract_long(&numcache, 1); } static void @@ -1959,7 +1959,7 @@ cache_enter_time(struct vnode *dvp, struct vnode *vp, */ lnumcache = atomic_fetchadd_long(&numcache, 1) + 1; if (__predict_false(lnumcache >= ncsize)) { - atomic_add_long(&numcache, -1); + atomic_subtract_long(&numcache, 1); counter_u64_add(numdrops, 1); return; } @@ -2125,7 +2125,7 @@ cache_enter_time(struct vnode *dvp, struct vnode *vp, return; out_unlock_free: cache_enter_unlock(&cel); - atomic_add_long(&numcache, -1); + atomic_subtract_long(&numcache, 1); cache_free(ncp); return; }