From owner-svn-src-head@freebsd.org Sat Mar 30 04:10:24 2019 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 303471561E8A for ; Sat, 30 Mar 2019 04:10:24 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-qt1-x832.google.com (mail-qt1-x832.google.com [IPv6:2607:f8b0:4864:20::832]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id DFA2D6C86D for ; Sat, 30 Mar 2019 04:10:22 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-qt1-x832.google.com with SMTP id x12so5015870qts.7 for ; Fri, 29 Mar 2019 21:10:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=/h33n9/OH8gsuUYw2JJGYJtNFYReSU0fvCH/PkoJJT0=; b=Xd/JkF1D7jtHlVJtRfgVo0x/QEu7qLr8JIddOdGZ9XhJDKRSgHzKJ5hyMsghKZa+Zi bxmExtnfykVsbksgSaLqGWqq/efE7casIXFDLMnrKyxNAaeZtz3Bk2LpyyoIyMYz69Ux R4fol/ARYc2/9PdhahHRz/LOtsr076RAPSn9L8CItuHZ6fwNwbhDaxgNfFrNcSTG0GP+ wJ3yaH9zyAykb+cOK2Zjrlq3GYoHqVBHuIb29ihEeLIvNMiMOqIaJPTDHR7+hH5GJGDU usreJf7hH5PnZ7KTDRXtth2ipqRgE3z7bzeUw5pVQQYCzeQIiC4bOJn5yuHtIE4Wn0S8 FNcA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=/h33n9/OH8gsuUYw2JJGYJtNFYReSU0fvCH/PkoJJT0=; b=rnZO/E5VAJkGeMmrIH+NMM7G9GyDidTbFBVIMYWx66ovfLIxQmimm6m+hMex3LAgY9 NEPw7zQE0PNMviEDk4ekYQOYQHTc47vMQgYAHLX2aS3gBCxdsINmyVt2CYfJZT/0Hwg1 HgnfRyrQ/28o2Km3CTyPwSYipXylxfVB8gotz3a31wItleHM3srNmzgFxA7Qgm4Sru+e ToppICggon7dhLQoiQ+2/yIaOTXQbxvfhSAQF3DUnQxrg5AuuzHhayVQCbZCC9aqlhl9 R50SwLCzUNzw/rHvvNyLiVrvvjOaqaEPNstGkZPOTgsqlJmiWpz5C4TFVQs7MzdYO1Ds NiaA== X-Gm-Message-State: APjAAAUGbV+rKezJyOB49wNGFQdo2numI62mwQTHp4mg59QVQidq7BjN 713Up2UnnTf/CahKCDYI/e+fywrbbeGbSTQiWAyAIg== X-Google-Smtp-Source: APXvYqyaGuq6e9/6MTKs0oR1i7mB46gfp/cbIAlIKyQP0JG/DF+bJ20xspXEHsrx4EmJuLxq2Ho7zFj1C+EMuioM5U4= X-Received: by 2002:ac8:304a:: with SMTP id g10mr45047889qte.118.1553919022055; Fri, 29 Mar 2019 21:10:22 -0700 (PDT) MIME-Version: 1.0 References: <201903300309.x2U39DtW002526@gndrsh.dnsmgr.net> In-Reply-To: From: Warner Losh Date: Fri, 29 Mar 2019 22:10:10 -0600 Message-ID: Subject: Re: svn commit: r345707 - in head: lib/clang lib/libc++ lib/libc++experimental lib/libc++fs lib/libc/tests/stdlib lib/libclang_rt lib/libcxxrt lib/libgcc_eh lib/libomp lib/ofed/libibnetdisc share/mk us... To: Garrett Cooper Cc: "Rodney W. Grimes" , Garrett Cooper , src-committers , svn-src-all , svn-src-head@freebsd.org X-Rspamd-Queue-Id: DFA2D6C86D X-Spamd-Bar: ----- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=bsdimp-com.20150623.gappssmtp.com header.s=20150623 header.b=Xd/JkF1D X-Spamd-Result: default: False [-5.74 / 15.00]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; R_DKIM_ALLOW(-0.20)[bsdimp-com.20150623.gappssmtp.com:s=20150623]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; PREVIOUSLY_DELIVERED(0.00)[svn-src-head@freebsd.org]; DMARC_NA(0.00)[bsdimp.com]; RCPT_COUNT_FIVE(0.00)[6]; TO_MATCH_ENVRCPT_SOME(0.00)[]; MX_GOOD(-0.01)[cached: ALT1.aspmx.l.google.com]; DKIM_TRACE(0.00)[bsdimp-com.20150623.gappssmtp.com:+]; RCVD_IN_DNSWL_NONE(0.00)[2.3.8.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.b.8.f.7.0.6.2.list.dnswl.org : 127.0.5.0]; NEURAL_HAM_SHORT(-0.89)[-0.889,0]; R_SPF_NA(0.00)[]; FORGED_SENDER(0.30)[imp@bsdimp.com,wlosh@bsdimp.com]; FREEMAIL_TO(0.00)[gmail.com]; MIME_TRACE(0.00)[0:+,1:+]; RCVD_TLS_LAST(0.00)[]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; FROM_NEQ_ENVFROM(0.00)[imp@bsdimp.com,wlosh@bsdimp.com]; IP_SCORE(-2.84)[ip: (-9.12), ipnet: 2607:f8b0::/32(-2.88), asn: 15169(-2.14), country: US(-0.07)]; RCVD_COUNT_TWO(0.00)[2] Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 30 Mar 2019 04:10:24 -0000 On Fri, Mar 29, 2019, 9:15 PM Enji Cooper wrote: > > > On Mar 29, 2019, at 8:09 PM, Rodney W. Grimes > wrote: > > > >> Author: ngie > >> Date: Fri Mar 29 18:43:46 2019 > >> New Revision: 345707 > >> URL: https://svnweb.freebsd.org/changeset/base/345707 > >> > >> Log: > >> Revert r345706: the third time will be the charm > >> > >> When a review is closed via Phabricator it updates the patch attached > to the > >> review. I downloaded the raw patch from Phabricator, applied it, and > repeated > >> my mistake from r345704 by accident mixing content from D19732 and > D19738. > > > > Which, arguable is a feature or mis feature depending on the point > > of view. I do not like it when I go to look at someone elses > > committed code siting a review, as I want to actually see what > > it was that was committed. You can find the pre-commit diff, > > but it takes a bit of probling. The upside is you can get > > both diffs from the same place and diff the diffs :-) > > > >> For my own personal sanity, I will try not to mix reviews like this i= n > the > >> future. > > > > :-) Been there, almost did that too. > > Pre commit last minute svn diff saved me. > > =E2=80=A6 > > This is why I=E2=80=99m doing the following from here on out: > > $ arc patch > $ svn ci > > Unfortunately svn doesn=E2=80=99t support all of the niceties of =E2=80= =9Carc land=E2=80=9D. > Otherwise, I would have used that. > > The Facebook version of =E2=80=9Carc land=E2=80=9D (before their new non-= public variation) > supported verifying diffs in local repos vs Phabricator to make sure that > the diff content was consistent/correct. > > * Pro: it would catch issues like what I did the first time. > * Con: I couldn=E2=80=99t make last minute changes (I would need to resub= mit the > change and have it re-reviewed, which I argue is a good feature). > > Just some food for thought. For now, arc patch/svn ci works for me. > I use git svn and git show every commit so I'm sure when I want to do multiple at once. Phab doesn't make that easy, alas, so I often choose the lesser evil of just getting a review on the squashed branch. I only split when there is a good reason. If we had better tools, I wouldn't be forced to pick, but you go to wat with the tools you have... Warner >