From owner-svn-src-head@freebsd.org Thu Aug 6 03:07:36 2015 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id EEDEC9B39B0; Thu, 6 Aug 2015 03:07:35 +0000 (UTC) (envelope-from gjb@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) by mx1.freebsd.org (Postfix) with ESMTP id D81B4CF; Thu, 6 Aug 2015 03:07:35 +0000 (UTC) (envelope-from gjb@FreeBSD.org) Received: from FreeBSD.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) by freefall.freebsd.org (Postfix) with ESMTP id F195C1BB1; Thu, 6 Aug 2015 03:07:34 +0000 (UTC) (envelope-from gjb@FreeBSD.org) Date: Thu, 6 Aug 2015 03:07:33 +0000 From: Glen Barber To: "K. Macy" Cc: Pawel Jakub Dawidek , Andriy Gapon , "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" , Xin Li Subject: Re: svn commit: r285021 - head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs Message-ID: <20150806030733.GI1484@FreeBSD.org> References: <201507020832.t628W3WJ002944@repo.freebsd.org> <55BF6A84.1040808@FreeBSD.org> <20150806021723.GB72832@garage.freebsd.pl> <20150806022247.GG1484@FreeBSD.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="Er/3qITiDpnrteFh" Content-Disposition: inline In-Reply-To: X-Operating-System: FreeBSD 11.0-CURRENT amd64 X-SCUD-Definition: Sudden Completely Unexpected Dataloss X-SULE-Definition: Sudden Unexpected Learning Event X-PEKBAC-Definition: Problem Exists, Keyboard Between Admin/Computer User-Agent: Mutt/1.5.23 (2014-03-12) X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 06 Aug 2015 03:07:36 -0000 --Er/3qITiDpnrteFh Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Aug 05, 2015 at 08:04:55PM -0700, K. Macy wrote: > On Wed, Aug 5, 2015 at 7:22 PM, Glen Barber wrote: > > On Thu, Aug 06, 2015 at 04:17:23AM +0200, Pawel Jakub Dawidek wrote: > >> On Mon, Aug 03, 2015 at 04:20:04PM +0300, Andriy Gapon wrote: > >> > On 30/07/2015 10:24, K. Macy wrote: > >> > > Just FYI this change introduces a deadlock with with the > >> > > spa_namespace_lock. Mount will be holding this lock while trying to > >> > > acquire the spa_namespace_lock. zfskern on the other hand holds the > >> > > spa_namespace_lock when calling zfs_freebsd_access which in turn > >> > > tries to acquire the teardown lock. > >> > > >> > I missed the fact that zpool.cache file is being written with spa_na= mespace_lock > >> > held. > >> > I'll try to either resolve the problem in the next day or I will rev= ert the change. > >> > >> FYI, I'm hitting this deadlock on my laptop. Reverting the change fixes > >> the problem. > >> > > > > Since it is now 3 days after "I'll try to either resolve the problem in > > the next day or I will revert the change", my view is that this needs to > > be reverted now, if it hasn't been done already. > > > His proposed solution looks fine to me. Why don't we commit that? >=20 I must have missed the solution - was it part of this thread? If a solution exists, then yes, that should be the fix instead. Glen --Er/3qITiDpnrteFh Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJVws91AAoJEAMUWKVHj+KTe4kQAIZS2vdbkuC9Yy35s7/iLXg3 Ld2xCo6mvJD71/oRdRCZZSP0ZLHay29jxgQoar8wpli5iu8RNReqlxS+KLfsTZcK pqC6+QZc9euF+gFcSkR9HGh8YmWf++8eOmPnp4DddSKzVnOcbIYg7EAw8BB60E1P qWS9KPMA872XiREYG0jm3BBZ7yXfDoha3UAujk8HUwjkVLhly47OWCVqZDi/q3Td vq5Q5BR7eIvdSViBZhj9zl4OLEbQMs0jnqkQQ6chPX/eWN6oFKCrvwpZgPHAGKqO xtUKt+7HsQxzg3jTdqUTxpGhF4vaDZXmET4MpiHM7a96efvoKkW3AgUn8/r2/Zmg GMD0DI/MajEDdmxkFzM5i3UNroLLxV3eea4SAPboJZ0htTxUyxSA3zhTt8mHjft+ z7qeFaHjUnxzNrL3G0y06FQd100vwmZjL3edWIHn9z7XyFMo32uyISSiYxlCzyes id4ADzHVZPucIH9Km8mKq+DwLI0/liP0FDdBwLm860Eg9xMfEbnEo0e9DmqsvEkH ju8onU0VxSwMVqLYQTQyBtOoO0TB906MNjfhY9Jfijj32MldRu/kQ49HUEARZw23 pC3z0hbX5UieLAX4bMPolYrgc/jlqoegDtq44jzppK9EOPwi00fAtp/BwzD+pmMf eSzUQnZ+bFr++wZszki7 =MerD -----END PGP SIGNATURE----- --Er/3qITiDpnrteFh--