Date: Thu, 04 Oct 2012 12:19:10 +0400 From: Ruslan Mahmatkhanov <cvs-src@yandex.ru> To: Baptiste Daroussin <bapt@FreeBSD.org> Cc: svn-ports-head@FreeBSD.org, svn-ports-all@FreeBSD.org, ports-committers@FreeBSD.org Subject: Re: svn commit: r305051 - head/dns/py-dnspython Message-ID: <506D467E.3020206@yandex.ru> In-Reply-To: <20121003220436.GA81976@ithaqua.etoilebsd.net> References: <201209292019.q8TKJqa6087700@svn.freebsd.org> <20121003220436.GA81976@ithaqua.etoilebsd.net>
next in thread | previous in thread | raw e-mail | index | archive | help
Baptiste Daroussin wrote on 04.10.2012 02:04: > On Sat, Sep 29, 2012 at 08:19:52PM +0000, Ruslan Mahmatkhanov wrote: >> Author: rm >> Date: Sat Sep 29 20:19:52 2012 >> New Revision: 305051 >> URL: http://svn.freebsd.org/changeset/ports/305051 [...] >> PORTNAME= dnspython >> -PORTVERSION= 1.9.4 >> +PORTVERSION= 1.10.0 >> CATEGORIES= dns python >> MASTER_SITES= http://www.dnspython.org/kits/${PORTVERSION}/ >> PKGNAMEPREFIX= ${PYTHON_PKGNAMEPREFIX} [...] >> -OPTIONS= PYCRYPTO "Enable pycrypto (part of dnssec needs it)" off >> +OPTIONS_DEFINE= PYCRYPTO >> +PYCRYPTO_DESC= Enable pycrypto (part of dnssec needs it) [...] > > There is a problem here which will lead for users to endless see the dialog in > make config-conditional > > The bug affects every single ports using framework modifier prefixes: python > rubygem, apache modules and many more for ages. > > The bug is the optionsfile is base on UNIQUENAME which is not the same when make > first reads the the makefile and what it becomes after inclusion of > bsd.port.pre.mk or bsd.port.options.mk, which means the optionsfiles read > (config-conditional or more) and the one written is not the same! > > the workaround for edges is to set OPTIONSFILE manually in the ports, lots of > python ports already do that. > > This is a long standing bug, if someone has a smart idea on how to fix easily > please step up, currently the only solution being worked on is trying to enforce > UNIQUENAME to be really unique. But this has a huge impact :) any the subject of > the mail was just to say here the options won't work as expected for the users > and never have in the past (prior to optionsng conversion :)) > > regards, > Bapt Just fixed, thank you for pointing this out. I never faced with it before (or just didn't pay an attention), nor got any reports about that. It will be great to note this in PH in BUGS or Caveats section of Options chapter. Thanks. -- Regards, Ruslan Tinderboxing kills... the drives.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?506D467E.3020206>