Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 19 May 2012 16:56:06 +0000
From:      Max Brazhnikov <makc@freebsd.org>
To:        "Sunpoet Po-Chuan Hsieh" <sunpoet@freebsd.org>, churanov.port.maintainer@gmail.com
Cc:        cvs-ports@freebsd.org, cvs-all@freebsd.org, ports-committers@freebsd.org
Subject:   Re: cvs commit: ports/devel/boost-all common.mk ports/devel/boost-docs distinfo pkg-plist ports/devel/boost-jam Makefile distinfo ports/devel/boost-libs Makefile distinfo pkg-plist ports/devel/boost-libs/files patch-Jamroot patch-boost-foreach.hpp ...
Message-ID:  <201205191656.06695.makc@freebsd.org>
In-Reply-To: <20120518034037.GB9141@bonjour.sunpoet.net>
References:  <201205161607.q4GG7OF2098675@repoman.freebsd.org> <201205170907.55840.makc@freebsd.org> <20120518034037.GB9141@bonjour.sunpoet.net>

next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, 18 May 2012 11:40:38 +0800, Sunpoet Po-Chuan Hsieh wrote:
> I found another problem.
> When WITHOUT_ICU is set, boost-libs will not install lib/libboost_locale.a and lib/libboost_locale.so.

Should we make dependency on icu non-optional in this case?

> Regards,
> sunpoet
> 
> Index: Makefile
> ===================================================================
> RCS file: /home/pcvs/ports/devel/boost-libs/Makefile,v
> retrieving revision 1.12
> diff -u -r1.12 Makefile
> --- Makefile	16 May 2012 16:07:23 -0000	1.12
> +++ Makefile	18 May 2012 03:34:43 -0000
> @@ -29,6 +29,9 @@
>  .if defined (WITH_ICU)
>  LIB_DEPENDS+=	icuuc:${PORTSDIR}/devel/icu
>  BJAM_OPTIONS+=	-sICU_PATH=${LOCALBASE}
> +PLIST_SUB+=	ICU=""
> +.else
> +PLIST_SUB+=	ICU="@comment "
>  .endif
>  
>  .if ${ARCH} == "sparc64"
> Index: pkg-plist
> ===================================================================
> RCS file: /home/pcvs/ports/devel/boost-libs/pkg-plist,v
> retrieving revision 1.5
> diff -u -r1.5 pkg-plist
> --- pkg-plist	16 May 2012 16:07:23 -0000	1.5
> +++ pkg-plist	18 May 2012 03:34:45 -0000
> @@ -8748,8 +8748,8 @@
>  lib/libboost_iostreams.a
>  lib/libboost_iostreams.so
>  lib/libboost_iostreams.so.%%BOOST_SHARED_LIB_VER%%
> -lib/libboost_locale.a
> -lib/libboost_locale.so
> +%%ICU%%lib/libboost_locale.a
> +%%ICU%%lib/libboost_locale.so
>  lib/libboost_math_c99.a
>  lib/libboost_math_c99.so
>  lib/libboost_math_c99.so.%%BOOST_SHARED_LIB_VER%%
> 




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201205191656.06695.makc>