From owner-cvs-ports@FreeBSD.ORG  Sat May 19 16:54:35 2012
Return-Path: <owner-cvs-ports@FreeBSD.ORG>
Delivered-To: cvs-ports@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id C1673106566B;
	Sat, 19 May 2012 16:54:35 +0000 (UTC)
	(envelope-from makc@freebsd.org)
Received: from mail.issp.ac.ru (mail.issp.ac.ru [77.236.34.3])
	by mx1.freebsd.org (Postfix) with ESMTP id 2A2308FC17;
	Sat, 19 May 2012 16:54:34 +0000 (UTC)
Received: from mercury.ph.man.ac.uk [130.88.75.175:5802] (HELO/EHLO
	mercury.ph.man.ac.uk, authenticated with LOGIN)
	by mail.issp.ac.ru with ESMTP/inet id q4JGsfck010197 (using TLSv1/SSLv3,
	with cipher DHE-RSA-AES256-SHA (256 bits), verified NO)
	Sat, 19 May 2012 20:54:42 +0400 (MSK)
From: Max Brazhnikov <makc@freebsd.org>
To: "Sunpoet Po-Chuan Hsieh" <sunpoet@freebsd.org>,
	churanov.port.maintainer@gmail.com
Date: Sat, 19 May 2012 16:56:06 +0000
User-Agent: KMail/1.13.7 (FreeBSD/9.0-STABLE; KDE/4.8.3; amd64; ; )
References: <201205161607.q4GG7OF2098675@repoman.freebsd.org>
	<201205170907.55840.makc@freebsd.org>
	<20120518034037.GB9141@bonjour.sunpoet.net>
In-Reply-To: <20120518034037.GB9141@bonjour.sunpoet.net>
MIME-Version: 1.0
Content-Type: Text/Plain;
  charset="us-ascii"
Content-Transfer-Encoding: 7bit
Message-Id: <201205191656.06695.makc@freebsd.org>
Cc: cvs-ports@freebsd.org, cvs-all@freebsd.org, ports-committers@freebsd.org
Subject: Re: cvs commit: ports/devel/boost-all common.mk
	ports/devel/boost-docs distinfo pkg-plist
	ports/devel/boost-jam Makefile distinfo
	ports/devel/boost-libs Makefile distinfo pkg-plist
	ports/devel/boost-libs/files patch-Jamroot
	patch-boost-foreach.hpp ...
X-BeenThere: cvs-ports@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the ports tree <cvs-ports.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-ports>,
	<mailto:cvs-ports-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-ports>
List-Post: <mailto:cvs-ports@freebsd.org>
List-Help: <mailto:cvs-ports-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-ports>,
	<mailto:cvs-ports-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 19 May 2012 16:54:35 -0000

On Fri, 18 May 2012 11:40:38 +0800, Sunpoet Po-Chuan Hsieh wrote:
> I found another problem.
> When WITHOUT_ICU is set, boost-libs will not install lib/libboost_locale.a and lib/libboost_locale.so.

Should we make dependency on icu non-optional in this case?

> Regards,
> sunpoet
> 
> Index: Makefile
> ===================================================================
> RCS file: /home/pcvs/ports/devel/boost-libs/Makefile,v
> retrieving revision 1.12
> diff -u -r1.12 Makefile
> --- Makefile	16 May 2012 16:07:23 -0000	1.12
> +++ Makefile	18 May 2012 03:34:43 -0000
> @@ -29,6 +29,9 @@
>  .if defined (WITH_ICU)
>  LIB_DEPENDS+=	icuuc:${PORTSDIR}/devel/icu
>  BJAM_OPTIONS+=	-sICU_PATH=${LOCALBASE}
> +PLIST_SUB+=	ICU=""
> +.else
> +PLIST_SUB+=	ICU="@comment "
>  .endif
>  
>  .if ${ARCH} == "sparc64"
> Index: pkg-plist
> ===================================================================
> RCS file: /home/pcvs/ports/devel/boost-libs/pkg-plist,v
> retrieving revision 1.5
> diff -u -r1.5 pkg-plist
> --- pkg-plist	16 May 2012 16:07:23 -0000	1.5
> +++ pkg-plist	18 May 2012 03:34:45 -0000
> @@ -8748,8 +8748,8 @@
>  lib/libboost_iostreams.a
>  lib/libboost_iostreams.so
>  lib/libboost_iostreams.so.%%BOOST_SHARED_LIB_VER%%
> -lib/libboost_locale.a
> -lib/libboost_locale.so
> +%%ICU%%lib/libboost_locale.a
> +%%ICU%%lib/libboost_locale.so
>  lib/libboost_math_c99.a
>  lib/libboost_math_c99.so
>  lib/libboost_math_c99.so.%%BOOST_SHARED_LIB_VER%%
>