From owner-svn-src-head@FreeBSD.ORG Thu Jun 18 11:09:49 2015 Return-Path: Delivered-To: svn-src-head@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 70192F7; Thu, 18 Jun 2015 11:09:49 +0000 (UTC) (envelope-from avg@FreeBSD.org) Received: from citadel.icyb.net.ua (citadel.icyb.net.ua [212.40.38.140]) by mx1.freebsd.org (Postfix) with ESMTP id 8D6FB157; Thu, 18 Jun 2015 11:09:47 +0000 (UTC) (envelope-from avg@FreeBSD.org) Received: from porto.starpoint.kiev.ua (porto-e.starpoint.kiev.ua [212.40.38.100]) by citadel.icyb.net.ua (8.8.8p3/ICyb-2.3exp) with ESMTP id OAA14673; Thu, 18 Jun 2015 14:09:44 +0300 (EEST) (envelope-from avg@FreeBSD.org) Received: from localhost ([127.0.0.1]) by porto.starpoint.kiev.ua with esmtp (Exim 4.34 (FreeBSD)) id 1Z5XhY-000DGd-6B; Thu, 18 Jun 2015 14:09:44 +0300 Message-ID: <5582A6A6.4040604@FreeBSD.org> Date: Thu, 18 Jun 2015 14:08:22 +0300 From: Andriy Gapon User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Warner Losh , Matthew Ahrens CC: Baptiste Daroussin , "src-committers@freebsd.org" , svn-src-all@FreeBSD.org, svn-src-head@FreeBSD.org Subject: Re: svn commit: r284409 - in head/cddl/lib: libzfs libzfs_core References: <201506151048.t5FAmnF0039077@svn.freebsd.org> <557EBCAB.3010505@FreeBSD.org> In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 Jun 2015 11:09:49 -0000 On 15/06/2015 21:06, Warner Losh wrote: > >> On Jun 15, 2015, at 8:37 AM, Matthew Ahrens wrote: >> >> >> >> On Mon, Jun 15, 2015 at 7:53 AM, Andriy Gapon wrote: >> >> P.S. My personal preference would be to drop that compat code and to >> convince ZFS/FreeBSD users to always use boot environments, so that their >> kernel and userland never fall out of sync :) >> >> Me too :-) > > Sadly, there are a number of upgrade scenarios where this simply isn’t > possible. Curious what are those... The only scenario I can think of is one where there is not enough space to hold the previous OS bits and the new ones. But in such a constrained system there is probably not much use for ZFS anyway. > But looking at the file, it appears to be full of stuff to do the 8.x -> > 9.x upgrade of ZFS to format 28. Perhaps that can now be removed? I would expect that every user of ZFS/FreeBSD has moved past that line by now, but who knows... > These libraries appear to be versioned, rather than symbol versioned > otherwise Baptiste’s commit would have been bad… but I wonder if maybe a > version bump is in order… I think we should be okay without a version bump, because the symbol is moved from a library to its dependency. So, libzfs_core interface is extended and that should not be a problem for its users. And libzfs users should not notice that the symbol migrated from libzfs to libfzs_core because the users have to link to both libraries (or load both of them). -- Andriy Gapon