From owner-dev-commits-src-all@freebsd.org Wed Feb 10 19:38:10 2021 Return-Path: Delivered-To: dev-commits-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 89C11528754 for ; Wed, 10 Feb 2021 19:38:10 +0000 (UTC) (envelope-from ricera10@gmail.com) Received: from mail-lf1-f51.google.com (mail-lf1-f51.google.com [209.85.167.51]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4DbVRP67s1z3Dnn for ; Wed, 10 Feb 2021 19:38:09 +0000 (UTC) (envelope-from ricera10@gmail.com) Received: by mail-lf1-f51.google.com with SMTP id v30so4269508lfq.6 for ; Wed, 10 Feb 2021 11:38:09 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=NJsci89OA2fPyZGPJmBk9h98HhBAcJbE6RJBJ/M+owk=; b=nOGMOiuv7hwv3DKno+9hnRVewTOHbk+Z1psnDXaQBtzPR22IOqK1Q8MoYk4hAVa6It +ejDjus5HqYHKy4FfKaQLTIqb9KTm32SZ282nywJxF83GyZpu80P8H+sdGNHNYQ+HM5S bvpqT2Rb3Ddz//aTzcAtD1REFZEsIB1RFNILI4mv5PFhX/NsYjR9jjL4L7JcHJlRsHq6 A9YVPrA49iUIGFZr1CnrHtk7RtBzBIO+OeZR1woxqP8Vurs/ZGqUlh+a7/86UJd9HRPD T08ky9mC+mZBnY41l2vPEcZ6LyUM84eEPeF2U8mAtwTfRjjTHoJhqN0sosi8O9WirQG0 bZTQ== X-Gm-Message-State: AOAM531bYZqpqTiwvAlnlU9DsQ9w5DFacIS8NPvsVvTxv8+ByFTfu9W1 wrAu5E4/5L4MFPa29mmWUL9A6Bx3XL8= X-Google-Smtp-Source: ABdhPJwc4nFScLLEN9x24m21JnTP3Fv9b9+jbcW3w0P2wfub6Ou7vpd+8JFtsX9nHhqp0Nxh7uwR2A== X-Received: by 2002:a19:6448:: with SMTP id b8mr887176lfj.361.1612985887589; Wed, 10 Feb 2021 11:38:07 -0800 (PST) Received: from mail-lf1-f46.google.com (mail-lf1-f46.google.com. [209.85.167.46]) by smtp.gmail.com with ESMTPSA id h18sm438397lft.4.2021.02.10.11.38.06 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 10 Feb 2021 11:38:07 -0800 (PST) Received: by mail-lf1-f46.google.com with SMTP id p21so4571130lfu.11 for ; Wed, 10 Feb 2021 11:38:06 -0800 (PST) X-Received: by 2002:a05:6512:2014:: with SMTP id a20mr2351086lfb.437.1612985886673; Wed, 10 Feb 2021 11:38:06 -0800 (PST) MIME-Version: 1.0 References: <202102042333.114NXowE086993@gitrepo.freebsd.org> In-Reply-To: From: Eric Joyner Date: Wed, 10 Feb 2021 11:37:55 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: git: 7d4dceec1030 - main - ixl(4): Fix VLAN HW filtering To: Kyle Evans Cc: Krzysztof Galazka , src-committers , dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org X-Rspamd-Queue-Id: 4DbVRP67s1z3Dnn X-Spamd-Bar: --- Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=pass (mx1.freebsd.org: domain of ricera10@gmail.com designates 209.85.167.51 as permitted sender) smtp.mailfrom=ricera10@gmail.com X-Spamd-Result: default: False [-3.00 / 15.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+ip4:209.85.128.0/17:c]; RCPT_COUNT_FIVE(0.00)[5]; RCVD_COUNT_THREE(0.00)[4]; NEURAL_HAM_SHORT(-1.00)[-1.000]; FORGED_SENDER(0.30)[erj@freebsd.org,ricera10@gmail.com]; MIME_TRACE(0.00)[0:+,1:+,2:~]; RBL_DBL_DONT_QUERY_IPS(0.00)[209.85.167.51:from]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US]; FROM_NEQ_ENVFROM(0.00)[erj@freebsd.org,ricera10@gmail.com]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; FROM_HAS_DN(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; PREVIOUSLY_DELIVERED(0.00)[dev-commits-src-all@freebsd.org]; DMARC_NA(0.00)[freebsd.org]; SPAMHAUS_ZRD(0.00)[209.85.167.51:from:127.0.2.255]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[209.85.167.51:from]; R_DKIM_NA(0.00)[]; RWL_MAILSPIKE_POSSIBLE(0.00)[209.85.167.51:from]; RCVD_TLS_ALL(0.00)[]; MAILMAN_DEST(0.00)[dev-commits-src-all] Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.34 X-BeenThere: dev-commits-src-all@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for all branches of the src repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 10 Feb 2021 19:38:10 -0000 Yeah, Internally we have the ixl and iavf drivers split up so that they no longer share source and have independent code bases, but that change hasn't made it upstream yet. Doing that would fix the dependency issue, so I'll see about doing that ASAP, possibly for 13.0. I recently came back from a long vacation, so I have to catch up on all of these things. :( - Eric On Sat, Feb 6, 2021 at 10:32 AM Kyle Evans wrote: > On Sat, Feb 6, 2021 at 12:30 PM Kyle Evans wrote: > > > > On Thu, Feb 4, 2021 at 5:34 PM Eric Joyner wrote: > > > > > > The branch main has been updated by erj: > > > > > > URL: > https://cgit.FreeBSD.org/src/commit/?id=7d4dceec103039e2b2fa90793ceeb71a8d6684aa > > > > > > commit 7d4dceec103039e2b2fa90793ceeb71a8d6684aa > > > Author: Krzysztof Galazka > > > AuthorDate: 2021-02-03 23:22:55 +0000 > > > Commit: Eric Joyner > > > CommitDate: 2021-02-04 23:33:42 +0000 > > > > > > ixl(4): Fix VLAN HW filtering > > > > > > X700 family of controllers has limited number of available VLAN > > > HW filters. Driver did not handle properly a case when user > > > assigned more VLANs to the interface which had all filters > > > already in use. Fix that by disabling HW filtering when > > > it is impossible to create filters for all requested VLANs. > > > Keep track of registered VLANs using bitstring to be able > > > to re-enable HW filtering when number of requested VLANs > > > drops below the limit. > > > > > > Also switch all allocations to use M_IXL malloc type > > > to ease detecting memory leaks in the driver. > > > > > > > Hi, > > > > This adds a dependency on `device ixl` for `device iavf` since M_IXL > > is defined in ixl_pf_main.c, but I think that particular part should > > be partially reverted anyways. There's an M_IAVF already that's more > > appropriate for i40e_osdep.c -- proposed patch here: > > > https://people.freebsd.org/~kevans/0001-ixl-switch-i40e_osdep.c-allocations-to-M_IAVF.patch > > > > Ah crud, nope. I missed that i40e_osdep is pulled in for ixl as well. :-( >