Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 3 Sep 2023 20:39:52 +0100
From:      Jessica Clarke <jrtc27@freebsd.org>
To:        Xin LI <delphij@FreeBSD.org>
Cc:        "src-committers@freebsd.org" <src-committers@FreeBSD.org>, "dev-commits-src-all@freebsd.org" <dev-commits-src-all@FreeBSD.org>, "dev-commits-src-branches@freebsd.org" <dev-commits-src-branches@FreeBSD.org>
Subject:   Re: git: 02183951bfb1 - stable/13 - Fix build for FreeBSD 13.
Message-ID:  <3D2AC67E-C1F8-4DD0-9D7C-65AD4E283C44@freebsd.org>
In-Reply-To: <202309031849.383In8u2023677@gitrepo.freebsd.org>
References:  <202309031849.383In8u2023677@gitrepo.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On 3 Sep 2023, at 19:49, Xin LI <delphij@FreeBSD.org> wrote:
>=20
> The branch stable/13 has been updated by delphij:
>=20
> URL: =
https://cgit.FreeBSD.org/src/commit/?id=3D02183951bfb19fda7a199acaeb9223cd=
28f29de3
>=20
> commit 02183951bfb19fda7a199acaeb9223cd28f29de3
> Author:     Xin LI <delphij@FreeBSD.org>
> AuthorDate: 2023-09-03 18:49:02 +0000
> Commit:     Xin LI <delphij@FreeBSD.org>
> CommitDate: 2023-09-03 18:49:02 +0000
>=20
>    Fix build for FreeBSD 13.
>=20
>    The minigzip utility has been removed in FreeBSD 14 but still
>    exists in FreeBSD 13. The upstream revision e9d5486e removed
>    prototype definitions, rendering the code no longer compliant
>    with WARNS=3D5.

Uh, what on earth is upstream doing? Has this been reported /
complained about?

Jess

> ---
> usr.bin/minigzip/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/usr.bin/minigzip/Makefile b/usr.bin/minigzip/Makefile
> index 6b04d8a65599..e7174694865a 100644
> --- a/usr.bin/minigzip/Makefile
> +++ b/usr.bin/minigzip/Makefile
> @@ -4,7 +4,7 @@ SRCDIR=3D ${SRCTOP}/sys/contrib/zlib/test
>=20
> PROG=3D minigzip
>=20
> -WARNS?=3D 5
> +WARNS?=3D 2
> CFLAGS+=3D-DUSE_MMAP
> LIBADD=3D z
>=20




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?3D2AC67E-C1F8-4DD0-9D7C-65AD4E283C44>