From owner-cvs-all@FreeBSD.ORG Fri Jan 13 06:37:25 2012 Return-Path: Delivered-To: cvs-all@FreeBSD.org Received: from mx2.freebsd.org (mx2.freebsd.org [IPv6:2001:4f8:fff6::35]) by hub.freebsd.org (Postfix) with ESMTP id 3EE3A106566C; Fri, 13 Jan 2012 06:37:25 +0000 (UTC) (envelope-from dougb@FreeBSD.org) Received: from 172-17-198-245.globalsuite.net (hub.freebsd.org [IPv6:2001:4f8:fff6::36]) by mx2.freebsd.org (Postfix) with ESMTP id D593E14F2DB; Fri, 13 Jan 2012 06:37:24 +0000 (UTC) Message-ID: <4F0FD124.6000303@FreeBSD.org> Date: Thu, 12 Jan 2012 22:37:24 -0800 From: Doug Barton Organization: http://SupersetSolutions.com/ User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:9.0) Gecko/20111222 Thunderbird/9.0 MIME-Version: 1.0 To: Mark Linimon References: <201201061944.q06JiwUR048089@repoman.freebsd.org> <4F0BF9F3.40009@FreeBSD.org> <4F0C2E7C.6070802@FreeBSD.org> <4F0CC4DF.6030906@FreeBSD.org> <4F0ED9F1.20305@FreeBSD.org> <4F0F800E.6060505@FreeBSD.org> <20120113042839.GB12998@lonesome.com> In-Reply-To: <20120113042839.GB12998@lonesome.com> X-Enigmail-Version: undefined OpenPGP: id=1A1ABC84 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: Michael Scheidell , cvs-all@FreeBSD.org, ports-committers@FreeBSD.org, Greg Larkin , Gabor Kovesdan , raven428@gmail.com, cvs-ports@FreeBSD.org Subject: Re: cvs commit: ports/devel/pinba_engine Makefile distinfo ports/devel/pinba_engine/files patch-src__ha_pinba.cc X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: **OBSOLETE** CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 13 Jan 2012 06:37:25 -0000 On 01/12/2012 20:28, Mark Linimon wrote: > On Thu, Jan 12, 2012 at 04:51:26PM -0800, Doug Barton wrote: >> On 01/12/2012 05:02, Gabor Kovesdan wrote: >>> Em 11-01-2012 00:08, Doug Barton escreveu: >>>> .if ${MYSQL_VER} == 52 >>>> MYSQL_PORTDIR= ${PORTSDIR}/databases/mariadb-server >>>> .else >>>> MYSQL_PORTDIR= ${PORTSDIR}/databases/mysql${MYSQL_VER}-server >>>> .endif >>> Although compatible, MariaDB is not MySQL. >> >> We use it heavily as a drop-in replacement and have not run into any >> problems. Do you have specific concerns? > > To me, on inspection it would be surprising behavior. > > I requested MySQL and I got something else as a dependency instead. Well you snipped the part of my previous post that answers this, so let me try again. MYSQL_VER is a user knob. It's defined in bsd.databases.mk. If a user sets MYSQL_VER= 52 it means that they are choosing, on purpose, to use mariadab as their version of mysql. So, "I requested MySQL and I got something else as a dependency instead" isn't happening. If you need to know more about mariadb feel free to visit http://mariadb.org/. Further, every other port that uses mysql as a dependency already works the way I described. The bug in this port is that it doesn't properly honor the user's MYSQL_VER setting. That bug needs to be fixed, that's all. Doug -- You can observe a lot just by watching. -- Yogi Berra Breadth of IT experience, and depth of knowledge in the DNS. Yours for the right price. :) http://SupersetSolutions.com/