From nobody Tue Oct 22 04:33:17 2024 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4XXfSF4sRBz52Mb4; Tue, 22 Oct 2024 04:33:17 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4XXfSF4LNNz4395; Tue, 22 Oct 2024 04:33:17 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1729571597; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=Hmm27BpdwO+Q3GI7oNNHJrqKI3Euxv2GaR3gqZmyAEI=; b=tWDInoGHGGbu7C/UcIxeBIt1R5c25zi3kUtiR3SnQMkghqFph2VPvfy2Vi1IfqrVdbk/rU g7qE58Elgir7hyei75SU1EROOm59vofMGGR7O2yfA6T+wgp/SHTGNedi8QCPhLO7SUqXdb DLgWAJoMAeduc3oN5kbxFwccDj/yqAgh5pLrbyCPWwqX4ehKwdAvwtOD5p26tjp89kPNPQ ilgJ0ZI7JmBA9u/hmjctxB0eJl3NUlr3DHy3RwsVhWWz3/ayZK7IZbtl0lpmr4R1HNKU5J 2cSAJqmtml0PvFM/Gg/AffJsFm+25WVqi0s9uVWoE0AV2gtuEv0EIr4jrO9KEQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1729571597; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=Hmm27BpdwO+Q3GI7oNNHJrqKI3Euxv2GaR3gqZmyAEI=; b=aBihQQpt6g4UrfBwYnO1PZrI17cHi4w8eO/B8vBdDVyhERTEVDCZjDsKxjN9YfHA4EOtgw HFfQYOP95BDY9Px0yL+JlLabhW+9UEYKbwOB1cfQY5OpBg6Liupg+iTUgB9m1CrQHfxlnl sqQIMyr2LKoalHGI32GHUVrElxCeTB8fEnrb8KODrkQ9jhi7BGtwwOfrLovDxGVKfRirzy Efc3lzFjgb7vwq0CewFM0HHU66FI8CNJo1PABaGAQrZAmS3P+CZfIqh8NSCOc3c8+23fo3 pywPWRjiza9KNurI1fkPGr9Iq6hlQ/Nvj2Xbh34bf5ukZHzRefAJjnFx/CM2hg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1729571597; a=rsa-sha256; cv=none; b=i3qnQHfXZiXuqmE0eraYpvxG8LoJv6f8mOKeQ+OFjI9a2RYFDjutY/Z0iMZxaTa0aTsY5V YEXUGHdeDxDPHR+YTtoWZ2WXFRScsalN2jQsbkod8cvVEqzPSgtUhA47wceSKm5XnxMlIf HtVP8nk7JwgHVpVqx2FkOkny30b+YQGRw41Pf3Mi5yCxbNASoAFtFMB6YDIN9qTCEF+MWU 9J5bCPc7wuEL8y5Et0IEFfVoJsw5SrC3S7tgdMVMN7OPbZy9wvLRcfHZqUZxsL7qLaN4SE BH4wAlRsm0FBXPoTCvD+f0k/TYFt28lkOuVtwV/5jeuw2EN/PQLJgYO76iI9Zg== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4XXfSF3yBxzyxj; Tue, 22 Oct 2024 04:33:17 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 49M4XHZr046640; Tue, 22 Oct 2024 04:33:17 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 49M4XHrg046637; Tue, 22 Oct 2024 04:33:17 GMT (envelope-from git) Date: Tue, 22 Oct 2024 04:33:17 GMT Message-Id: <202410220433.49M4XHrg046637@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Zhenlei Huang Subject: git: d1d839d0b593 - main - ifnet: Assert that we are assigning network stack correctly List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: zlei X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: d1d839d0b593541174ca48c675c9eff4ddb4715e Auto-Submitted: auto-generated The branch main has been updated by zlei: URL: https://cgit.FreeBSD.org/src/commit/?id=d1d839d0b593541174ca48c675c9eff4ddb4715e commit d1d839d0b593541174ca48c675c9eff4ddb4715e Author: Zhenlei Huang AuthorDate: 2024-10-22 04:32:24 +0000 Commit: Zhenlei Huang CommitDate: 2024-10-22 04:32:24 +0000 ifnet: Assert that we are assigning network stack correctly It makes no sense to assign NULL vnet to an interface when the kernel option VIMAGE is enabled. Add an assertion to catch that. This will also help diagnosing problem report [1] and [2]. 1. https://bugs.freebsd.org/275381 2. https://bugs.freebsd.org/282168 Reviewed by: kp MFC after: 1 week Differential Revision: https://reviews.freebsd.org/D46982 --- sys/net/if.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sys/net/if.c b/sys/net/if.c index ebad5c5d16e5..8dc212ae4ac7 100644 --- a/sys/net/if.c +++ b/sys/net/if.c @@ -832,6 +832,7 @@ if_attach_internal(struct ifnet *ifp, bool vmove) MPASS(ifindex_table[ifp->if_index].ife_ifnet == ifp); #ifdef VIMAGE + CURVNET_ASSERT_SET(); ifp->if_vnet = curvnet; if (ifp->if_home_vnet == NULL) ifp->if_home_vnet = curvnet;