From owner-freebsd-rc@FreeBSD.ORG Sat Jun 10 00:41:03 2006 Return-Path: X-Original-To: freebsd-rc@FreeBSD.org Delivered-To: freebsd-rc@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id AD8AA16A479; Sat, 10 Jun 2006 00:41:03 +0000 (UTC) (envelope-from alex@foxybanana.com) Received: from imf18aec.mail.bellsouth.net (imf18aec.mail.bellsouth.net [205.152.59.66]) by mx1.FreeBSD.org (Postfix) with ESMTP id D296C43D73; Sat, 10 Jun 2006 00:41:02 +0000 (GMT) (envelope-from alex@foxybanana.com) Received: from ibm59aec.bellsouth.net ([68.209.153.178]) by imf18aec.mail.bellsouth.net with ESMTP id <20060610004056.TPQG13665.imf18aec.mail.bellsouth.net@ibm59aec.bellsouth.net>; Fri, 9 Jun 2006 20:40:56 -0400 Received: from Laptop.mine.box ([68.209.153.178]) by ibm59aec.bellsouth.net with ESMTP id <20060610004055.CESL25054.ibm59aec.bellsouth.net@Laptop.mine.box>; Fri, 9 Jun 2006 20:40:55 -0400 Received: from Laptop.mine.box (localhost [127.0.0.1]) by Laptop.mine.box (8.13.6/8.13.6) with ESMTP id k5A0cgX0078259; Fri, 9 Jun 2006 19:38:42 -0500 (CDT) (envelope-from alex@Laptop.mine.box) Received: (from alex@localhost) by Laptop.mine.box (8.13.6/8.13.6/Submit) id k5A0cdU5078258; Fri, 9 Jun 2006 19:38:39 -0500 (CDT) (envelope-from alex) From: Alexander Botero-Lowry Message-Id: <200606100038.k5A0cdU5078258@Laptop.mine.box> Date: Fri, 09 Jun 2006 19:38:38 -0500 To: flz@FreeBSD.org, alex@foxybanana.com References: <200606091826.k59IQfmo057494@freefall.freebsd.org> <20060609222512.Y15476@erdgeist.org> <20060610001442.U15476@erdgeist.org> <200606092231.k59MVFNQ077781@Laptop.mine.box> <1149897016.31327.2.camel@localhost> In-Reply-To: <1149897016.31327.2.camel@localhost> User-Agent: nail 11.25 7/29/05 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: freebsd-rc@FreeBSD.org Subject: Re: conf/95162: [patch] Missing feature in rc.subr X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 10 Jun 2006 00:41:03 -0000 Florent Thoumie wrote: > On Fri, 2006-06-09 at 17:31 -0500, Alexander Botero-Lowry wrote: > > Using /etc/rc.conf.d would be better. You don't have to bother doing reinplace, you can just override the file when you have a configval change. > > No, please use ${prefix}/etc/rc.conf.d/. And anyway you still need to Erm. I don't know how you would be able to use ${prefix}/etc/rc.conf.d/ considering that /etc/rc.subr does: if [ -f /etc/rc.conf.d/"$_command" ]; then debug "Sourcing /etc/rc.conf.d/${_command}" . /etc/rc.conf.d/"$_command" fi That is the only reference to *rc.conf.d* in rc.subr. So clearly rc.subr would need to be modified to be able to handle rc.conf.d/$_command files in $LOCALBASE. Even more work to handle them in $PREFIX. > use 'sed -i' because people might use this file for custom flags. > I noticed that while reading rc.subr manpage after sending the email, my apologies for the quick response. > -- > Florent Thoumie > flz@FreeBSD.org > FreeBSD Committer