From owner-freebsd-bugs@FreeBSD.ORG  Thu Feb 24 16:00:20 2011
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
Delivered-To: freebsd-bugs@hub.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id A2561106566B
	for <freebsd-bugs@hub.freebsd.org>;
	Thu, 24 Feb 2011 16:00:20 +0000 (UTC)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
	[IPv6:2001:4f8:fff6::28])
	by mx1.freebsd.org (Postfix) with ESMTP id 5C2A58FC0A
	for <freebsd-bugs@hub.freebsd.org>;
	Thu, 24 Feb 2011 16:00:20 +0000 (UTC)
Received: from freefall.freebsd.org (localhost [127.0.0.1])
	by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id p1OG0KsW019834
	for <freebsd-bugs@freefall.freebsd.org>; Thu, 24 Feb 2011 16:00:20 GMT
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.14.4/8.14.4/Submit) id p1OG0KaG019832;
	Thu, 24 Feb 2011 16:00:20 GMT (envelope-from gnats)
Resent-Date: Thu, 24 Feb 2011 16:00:20 GMT
Resent-Message-Id: <201102241600.p1OG0KaG019832@freefall.freebsd.org>
Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer)
Resent-To: freebsd-bugs@FreeBSD.org
Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org,
	Helmut Schneider <jumper99@gmx.de>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id A37C9106566B
	for <freebsd-gnats-submit@FreeBSD.org>;
	Thu, 24 Feb 2011 15:51:24 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22])
	by mx1.freebsd.org (Postfix) with ESMTP id 92FC88FC14
	for <freebsd-gnats-submit@FreeBSD.org>;
	Thu, 24 Feb 2011 15:51:24 +0000 (UTC)
Received: from red.freebsd.org (localhost [127.0.0.1])
	by red.freebsd.org (8.14.4/8.14.4) with ESMTP id p1OFpOHW053831
	for <freebsd-gnats-submit@FreeBSD.org>; Thu, 24 Feb 2011 15:51:24 GMT
	(envelope-from nobody@red.freebsd.org)
Received: (from nobody@localhost)
	by red.freebsd.org (8.14.4/8.14.4/Submit) id p1OFpOFf053830;
	Thu, 24 Feb 2011 15:51:24 GMT (envelope-from nobody)
Message-Id: <201102241551.p1OFpOFf053830@red.freebsd.org>
Date: Thu, 24 Feb 2011 15:51:24 GMT
From: Helmut Schneider <jumper99@gmx.de>
To: freebsd-gnats-submit@FreeBSD.org
X-Send-Pr-Version: www-3.1
Cc: 
Subject: bin/155006: named(8): /etc/rc.d/named might set wrong pid file
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 24 Feb 2011 16:00:20 -0000


>Number:         155006
>Category:       bin
>Synopsis:       named(8): /etc/rc.d/named might set wrong pid file
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Thu Feb 24 16:00:19 UTC 2011
>Closed-Date:
>Last-Modified:
>Originator:     Helmut Schneider
>Release:        8.1-RELEASE-p2
>Organization:
>Environment:
>Description:
According to "man named 8" the default pid file is /var/run/named/named.pid. /etc/rc.d/named says:

pidfile="${named_pidfile:-/var/run/named/pid}"

There might be a reason for it but if not /etc/rc.d/named should state:

pidfile="${named_pidfile:-/var/run/named/${name}.pid}
>How-To-Repeat:

>Fix:
--- /etc/rc.d/named.org 2011-02-24 16:43:08.000000000 +0100
+++ /etc/rc.d/named     2011-02-24 16:43:37.000000000 +0100
@@ -279,7 +279,7 @@
 #
 required_dirs="$named_chrootdir"       # if it is set, it must exist

-pidfile="${named_pidfile:-/var/run/named/pid}"
+pidfile="${named_pidfile:-/var/run/named/${name}.pid}"
 named_confdir="${named_chrootdir}${named_conf%/*}"

 run_rc_command "$1"

>Release-Note:
>Audit-Trail:
>Unformatted: