From owner-svn-src-all@FreeBSD.ORG Wed Jul 14 17:00:35 2010 Return-Path: Delivered-To: svn-src-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 2ECD5106564A; Wed, 14 Jul 2010 17:00:35 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from harmony.bsdimp.com (bsdimp.com [199.45.160.85]) by mx1.freebsd.org (Postfix) with ESMTP id C39D58FC0A; Wed, 14 Jul 2010 17:00:34 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by harmony.bsdimp.com (8.14.3/8.14.1) with ESMTP id o6EGw0Bg065669; Wed, 14 Jul 2010 10:58:00 -0600 (MDT) (envelope-from imp@bsdimp.com) Date: Wed, 14 Jul 2010 10:58:19 -0600 (MDT) Message-Id: <20100714.105819.636794876120392123.imp@bsdimp.com> To: jhb@FreeBSD.org From: "M. Warner Losh" In-Reply-To: <201007141241.36772.jhb@freebsd.org> References: <201007141008.56110.jhb@freebsd.org> <4C3DDEF2.4090309@FreeBSD.org> <201007141241.36772.jhb@freebsd.org> X-Mailer: Mew version 6.3 on Emacs 22.3 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: svn-src-head@FreeBSD.org, mav@FreeBSD.org, src-committers@FreeBSD.org, svn-src-all@FreeBSD.org Subject: Re: svn commit: r210054 - in head/sys: conf kern x86/x86 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Jul 2010 17:00:35 -0000 In message: <201007141241.36772.jhb@freebsd.org> John Baldwin writes: : On Wednesday, July 14, 2010 11:59:46 am Alexander Motin wrote: : > John Baldwin wrote: : > > On Wednesday, July 14, 2010 9:31:27 am Alexander Motin wrote: : > >> Author: mav : > >> Date: Wed Jul 14 13:31:27 2010 : > >> New Revision: 210054 : > >> URL: http://svn.freebsd.org/changeset/base/210054 : > >> : > >> Log: : > >> Move timeevents.c to MI code, as it is not x86-specific. I already have : > >> it working on Marvell ARM SoCs, and it would be nice to unify timer : code : > >> between more platforms. : > >> : > >> Added: : > >> head/sys/kern/timeevents.c : > >> - copied unchanged from r210053, head/sys/x86/x86/timeevents.c : > >> Deleted: : > >> head/sys/x86/x86/timeevents.c : > >> Modified: : > >> head/sys/conf/files.amd64 : > >> head/sys/conf/files.i386 : > >> head/sys/conf/files.pc98 : > > : > > Can this be merged with kern_et.c, : > : > They are different. kern_et.c provides event timer drivers API, : > timeevents.c consumes it to manage kernel clocks. kern_et.c : > theoretically can be used without timeevents.c if some other code : > consume timers, for example, exposing them to user-level. : > : > May be names indeed cryptic a bit, but I had no better ideas. : > : > > or perhaps called subr_eventtimers.c instead? : > : > Whatever you like, but why exactly so and why "subr_" important? : : The vast majority of files in sys/kern use some sort of prefix, either sys_*, : kern_*, subr_*, etc. subr_ was just a suggestion to avoid clashing with : kern_et.c. If timeevents.c is specific to clocks then maybe it should have : 'clock' in its name somehow? Right now having kern_et == kern_eventtimer.c : and timeevents.c is a bit ambiguous. Somehow making it clear that : timeevents.c is for clocks might help. Also, subr_ prefix helps prevent collisions in other parts of the tree for files with the same name. Warner