Date: Tue, 19 Oct 2004 08:37:36 -0700 From: Bruce M Simpson <bms@spc.org> To: Sebastian Schulze Struchtrup <seb@struchtrup.com> Cc: freebsd-current@freebsd.org Subject: Re: trap: page fault after shutdown (irq23: vr0) Message-ID: <20041019153736.GB86472@dhcp120.icir.org> In-Reply-To: <41750F05.1010704@struchtrup.com> References: <41750F05.1010704@struchtrup.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--fWddYNRDgTk9wQGZ
Content-Type: multipart/mixed; boundary="Qrgsu6vtpU/OV/zm"
Content-Disposition: inline
--Qrgsu6vtpU/OV/zm
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
Hi,
On Tue, Oct 19, 2004 at 02:56:37PM +0200, Sebastian Schulze Struchtrup wrot=
e:
> I have not noticed this before BETA4. I am currently running 5.3 STABLE/R=
C1.
> The trap occurs in process "irq23: vr0". I am not sure if this is=20
> related to vr0. The code for vr (sys/pci/if_vr.c) has not changed since=
=20
This is a duplicate of kern/62889.
vr_shutdown() is incorrect and in fact prone to race on SMP.
I've committed a fix to current. Patch is attached.
MFC request to RELENG_5 and RELENG_5_3 is pending.
Regards,
BMS
--Qrgsu6vtpU/OV/zm
Content-Type: text/plain; charset=us-ascii
Content-Disposition: attachment; filename="if_vr.c.patch"
Content-Transfer-Encoding: quoted-printable
Index: if_vr.c
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
RCS file: /home/ncvs/src/sys/pci/if_vr.c,v
retrieving revision 1.94
diff -u -p -r1.94 if_vr.c
--- if_vr.c 11 Aug 2004 04:30:49 -0000 1.94
+++ if_vr.c 19 Oct 2004 15:22:08 -0000
@@ -1692,7 +1692,5 @@ vr_shutdown(device_t dev)
{
struct vr_softc *sc =3D device_get_softc(dev);
=20
- VR_LOCK(sc);
- vr_stop(sc);
- VR_UNLOCK(sc);
+ vr_detach(sc);
}
--Qrgsu6vtpU/OV/zm--
--fWddYNRDgTk9wQGZ
Content-Type: application/pgp-signature
Content-Disposition: inline
-----BEGIN PGP SIGNATURE-----
Comment: ''
iD8DBQFBdTTAueUpAYYNtTsRAuTiAJ0YYbHgX3lc9FnIZbMc5Axi7HYX0ACdEkdt
iMUveDRLXaPIvGF3aDlfpK0=
=vdz2
-----END PGP SIGNATURE-----
--fWddYNRDgTk9wQGZ--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20041019153736.GB86472>