From owner-svn-ports-all@freebsd.org  Mon Apr 23 15:44:24 2018
Return-Path: <owner-svn-ports-all@freebsd.org>
Delivered-To: svn-ports-all@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 652E5FA4C6C;
 Mon, 23 Apr 2018 15:44:24 +0000 (UTC)
 (envelope-from yuri@freebsd.org)
Received: from shell1.rawbw.com (shell1.rawbw.com [198.144.192.42])
 by mx1.freebsd.org (Postfix) with ESMTP id EE02F7AAD5;
 Mon, 23 Apr 2018 15:44:23 +0000 (UTC)
 (envelope-from yuri@freebsd.org)
Received: from yv.noip.me (c-24-4-131-132.hsd1.ca.comcast.net [24.4.131.132])
 (authenticated bits=0)
 by shell1.rawbw.com (8.15.1/8.15.1) with ESMTPSA id w3NFiGkN044576
 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NO);
 Mon, 23 Apr 2018 08:44:17 -0700 (PDT)
 (envelope-from yuri@freebsd.org)
X-Authentication-Warning: shell1.rawbw.com: Host
 c-24-4-131-132.hsd1.ca.comcast.net [24.4.131.132] claimed to be yv.noip.me
Reply-To: yuri@freebsd.org
Subject: Re: svn commit: r468086 - in head/math: . piranha
To: Mathieu Arnold <mat@freebsd.org>
Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org,
 svn-ports-head@freebsd.org
References: <201804230903.w3N93LhK062379@repo.freebsd.org>
 <20180423123756.fvitgl3rll4yikeq@ogg.in.absolight.net>
From: Yuri <yuri@freebsd.org>
Message-ID: <b8c76e65-a4f4-9db2-ba9d-f2c9a43c417b@freebsd.org>
Date: Mon, 23 Apr 2018 08:44:15 -0700
User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:52.0) Gecko/20100101
 Thunderbird/52.7.0
MIME-Version: 1.0
In-Reply-To: <20180423123756.fvitgl3rll4yikeq@ogg.in.absolight.net>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
X-BeenThere: svn-ports-all@freebsd.org
X-Mailman-Version: 2.1.25
Precedence: list
List-Id: SVN commit messages for the ports tree <svn-ports-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-all/>
List-Post: <mailto:svn-ports-all@freebsd.org>
List-Help: <mailto:svn-ports-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 23 Apr 2018 15:44:24 -0000

On 04/23/18 05:37, Mathieu Arnold wrote:
> Unless this really needs cmake and ninja to run, please reverse the way
> you create the BUILD_DEPENDS and RUN_DEPENDS variables.  You may have
> noticed many ports do BUILD_DEPENDS=${RUN_DEPENDS} and RUN_DEPENDS=blah.


The way how they defined the build, it does involve cmake. cmake isn't 
"really needed" because cmake doesn't really build anything, but it does 
install it. It is also needed for the 'test' target.

You prefer it the way around, "BUILD_DEPENDS=${RUN_DEPENDS} and 
RUN_DEPENDS=blah"? But doesn't it end up being the same?


Yuri