From owner-cvs-all@FreeBSD.ORG  Sat Aug 14 12:23:03 2010
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@FreeBSD.org
Received: by hub.freebsd.org (Postfix, from userid 1033)
	id 574F4106566C; Sat, 14 Aug 2010 12:23:03 +0000 (UTC)
Date: Sat, 14 Aug 2010 12:23:03 +0000
From: Alexey Dokuchaev <danfe@FreeBSD.org>
To: Matthias Andree <mandree@FreeBSD.org>
Message-ID: <20100814122303.GA69635@FreeBSD.org>
References: <201008141202.o7EC2mvm018841@repoman.freebsd.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=koi8-r
Content-Disposition: inline
In-Reply-To: <201008141202.o7EC2mvm018841@repoman.freebsd.org>
User-Agent: Mutt/1.4.2.1i
Cc: cvs-ports@FreeBSD.org, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org
Subject: Re: cvs commit: ports/games Makefile ports/games/atanks Makefile
	distinfo pkg-descr pkg-plist ports/games/atanks/files
	patch-Makefile patch-src_files.cpp
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: **OBSOLETE** CVS commit messages for the entire tree
	<cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 14 Aug 2010 12:23:03 -0000

On Sat, Aug 14, 2010 at 12:02:48PM +0000, Matthias Andree wrote:
> mandree     2010-08-14 12:02:48 UTC
> 
>   FreeBSD ports repository
> 
>   Modified files:
>     games                Makefile 
>   Added files:
>     games/atanks         Makefile distinfo pkg-descr pkg-plist 
>     games/atanks/files   patch-Makefile patch-src_files.cpp 
>   Log:
>   Add new port games/atanks.

It is usually nice to briefly mention in the commit log some details
about the port and/or why it might be interesting to take a look at.
Quoting entire pkg-message is probably unnecessary, but simply
reiterating port name (that is, providing zero information) is certainly
not enough; consider at least quoting COMMENT line next time.

Also, post-patch: section is incorrectly indented, and setting DISTNAME
value is no-op (thus should be dropped).

>   Submitted by: Jesse Smith <jessefrgsmith@yahoo.ca>
>   PR: ports/147768

Try to indent tag values to ease the reading, thanks.

./danfe