From nobody Fri Jan 3 16:03:27 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4YPpJv6kDFz5k82L; Fri, 03 Jan 2025 16:03:27 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4YPpJv5MLyz4Zqq; Fri, 3 Jan 2025 16:03:27 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1735920207; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=hZewaFmqd2OAWUFygCrd2K3z3TMc4GBpzHLswwe9cMc=; b=LOwbbfSD12QCE5wgsy1qA/paV0uax1uWW8CUocZyckP3cJiVwF7ygbGYc/ysJ2xLZ21f2g b783CG397Bv1O/SaxeYZ/bd8HUlr8xLKFDdk8y/6+pgXr76QGRHBc1HMlk+8OU7RP9umCY 2iZuFQV5b3aMIrWl+IHk2qpCkB3cO1wG68eCOtnsw15pOROwZ7+yAnI5sjeeucuYl68x9u e1z/a+pomNfVWscEBt60MpexP+Q+SaUEeqCKHiC3gpe9VbNzWJPEKle4qnbnUitS7p0xtB 4yl9trn4xr6bw5T71MwpeXtDfoqPIMZaifwk/WPPMhqsl9Hsysq5Zjyn5wVsaA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1735920207; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=hZewaFmqd2OAWUFygCrd2K3z3TMc4GBpzHLswwe9cMc=; b=lmtmEjDa9P1xZWq2YRZtqGFC3EZu5+Yx5JKSrKw1RyzMWGiokAIi0qmdeoJjQkI316EWUQ Z0m1nMyqEvXcTUl9Zjduoz4u23Tr23uRlfArX6ItfD5CWq3BxNmY5y/DDH6ggNk1pFIuFm 9kdKxy5LRxwq48p+vVhihNQx4/J/Fcr47NsjjQ4misYMJfvV5lUaRZzbpGjLVNkf4nDbEc N/GzUWZ9lIObbpLaOfcWUJVHLUvvWGVB63XUAYY3aAK+IqPb6eRvn6fjRBdB47qThov0EC AkkykCmHHpjVUqK5/SAyQSaEHVEgNhEXXAQzxRMOk+XqKR6DUPxBqaWKGdhOqg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1735920207; a=rsa-sha256; cv=none; b=pi9iul1ZnOt1FBUDEAUn1n2ThBbcvAGCI8uZnG3BIZ7KpBr3tmpljTdMmr5SXQvCUY1mXz qhjuesgPcgOueCEEv2qynEXotva4e8Cm3bZoDwqjZg/kHb4UlQ08CtJn6pY1D9+VmL0Kgw 5nopoWT2J6/dAZBGm0bl8DpqBQP5KGJXclyf9I3sL3nZphHTmTQ47FEgAWj5qqt5N2qtjg gnQffM6G7Hm7nz9SoLoSF2dju7YtjQ7W9zYvEgNU1n0PiJAOXLrYNx2JJNPh8j0bsHkL1M TOE/bJ6mw2XHNotXeiX9tu2sEtCJ7jCwIr/cFTgPpx5mHgo3u8L2evMoWOgRSw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4YPpJv4xfbz1RZ3; Fri, 03 Jan 2025 16:03:27 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 503G3Rpf098400; Fri, 3 Jan 2025 16:03:27 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 503G3RxU098397; Fri, 3 Jan 2025 16:03:27 GMT (envelope-from git) Date: Fri, 3 Jan 2025 16:03:27 GMT Message-Id: <202501031603.503G3RxU098397@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: John Baldwin Subject: git: 0e742cc77454 - main - cpu_set_upcall / linux_clone_thread: Remove calls to cpu_thread_clean List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: jhb X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 0e742cc77454d0872ac2f6e7fd755b6d0322b711 Auto-Submitted: auto-generated The branch main has been updated by jhb: URL: https://cgit.FreeBSD.org/src/commit/?id=0e742cc77454d0872ac2f6e7fd755b6d0322b711 commit 0e742cc77454d0872ac2f6e7fd755b6d0322b711 Author: John Baldwin AuthorDate: 2025-01-03 16:03:08 +0000 Commit: John Baldwin CommitDate: 2025-01-03 16:03:08 +0000 cpu_set_upcall / linux_clone_thread: Remove calls to cpu_thread_clean This is intended to clean state of a thread at the end of its lifecycle during wait(), not the beginning of its life cycle. Reviewed by: kib Sponsored by: AFRL, DARPA Differential Revision: https://reviews.freebsd.org/D48023 --- sys/amd64/amd64/vm_machdep.c | 10 ---------- sys/compat/linux/linux_fork.c | 2 -- sys/i386/i386/vm_machdep.c | 10 ---------- 3 files changed, 22 deletions(-) diff --git a/sys/amd64/amd64/vm_machdep.c b/sys/amd64/amd64/vm_machdep.c index f74091438648..1c6b1549422b 100644 --- a/sys/amd64/amd64/vm_machdep.c +++ b/sys/amd64/amd64/vm_machdep.c @@ -605,16 +605,6 @@ int cpu_set_upcall(struct thread *td, void (*entry)(void *), void *arg, stack_t *stack) { - - /* - * Do any extra cleaning that needs to be done. - * The thread may have optional components - * that are not present in a fresh thread. - * This may be a recycled thread so make it look - * as though it's newly allocated. - */ - cpu_thread_clean(td); - #ifdef COMPAT_FREEBSD32 if (SV_PROC_FLAG(td->td_proc, SV_ILP32)) { /* diff --git a/sys/compat/linux/linux_fork.c b/sys/compat/linux/linux_fork.c index 4ce3bc192b4e..1c9189162a09 100644 --- a/sys/compat/linux/linux_fork.c +++ b/sys/compat/linux/linux_fork.c @@ -301,8 +301,6 @@ linux_clone_thread(struct thread *td, struct l_clone_args *args) else em->child_clear_tid = NULL; - cpu_thread_clean(newtd); - linux_set_upcall(newtd, args->stack); PROC_LOCK(p); diff --git a/sys/i386/i386/vm_machdep.c b/sys/i386/i386/vm_machdep.c index 0e0cebe98e5f..b0dd7534633b 100644 --- a/sys/i386/i386/vm_machdep.c +++ b/sys/i386/i386/vm_machdep.c @@ -480,16 +480,6 @@ int cpu_set_upcall(struct thread *td, void (*entry)(void *), void *arg, stack_t *stack) { - - /* - * Do any extra cleaning that needs to be done. - * The thread may have optional components - * that are not present in a fresh thread. - * This may be a recycled thread so make it look - * as though it's newly allocated. - */ - cpu_thread_clean(td); - /* * Set the trap frame to point at the beginning of the entry * function.