From owner-svn-src-all@FreeBSD.ORG Fri May 10 14:13:06 2013 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by hub.freebsd.org (Postfix) with ESMTP id 10A1254C for ; Fri, 10 May 2013 14:13:06 +0000 (UTC) (envelope-from lists@eitanadler.com) Received: from mail-pa0-f43.google.com (mail-pa0-f43.google.com [209.85.220.43]) by mx1.freebsd.org (Postfix) with ESMTP id DCC94C1E for ; Fri, 10 May 2013 14:13:05 +0000 (UTC) Received: by mail-pa0-f43.google.com with SMTP id hz10so2974928pad.30 for ; Fri, 10 May 2013 07:13:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=eitanadler.com; s=0xdeadbeef; h=x-received:mime-version:sender:in-reply-to:references:from:date :x-google-sender-auth:message-id:subject:to:cc:content-type; bh=5ht09uj8lCFEdJ4ymD9Tbn3FZOdsq/y7R2DPmqkY454=; b=FtgesT11sIfeTGmJqn18e/Geehm/tJVVzxHk0vYwXVqnBP1e34abBxC5rAj9CI48Ao eGjxyTS/INavpgyu3bjorg4j13eYnsDcqoblrpsBivpgWi/lupRtUNhvbYr0cUEGUUj8 eoAO+cQ0AO0ZKlbvUDzBZbeG2FGAB5XWz+L2A= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-received:mime-version:sender:in-reply-to:references:from:date :x-google-sender-auth:message-id:subject:to:cc:content-type :x-gm-message-state; bh=5ht09uj8lCFEdJ4ymD9Tbn3FZOdsq/y7R2DPmqkY454=; b=Idapz269iQ47GiBw9bV3D9tRRq4/oJw259WK8RiTSnGIUhroPwMOsQOqSVaVx4RUpK jwX/7c5XqXpevXJjZtiPps6jITntgW2GL+55ZfDigjs3Brz4HZ0oqISaKJDTS0qPjxTu Dl04otKrwfwN2mIPX6dZZ+JFE9kl26eS8BCjrNjc8D22gwQLpKxO6rncb8cMpRxmMKwo 7FliJzFTq9ytray1AB7P2ByvS2a6FtNsoa8fN3pFsD2Q5WQPa67B/J5qiaxSu5CBb2y5 VfIj4VQDyk4za26bHDntIIb4MUYzfTLekW4c3KU8YeweFaPOI1M+/tsiC5eyjd0L/Q7N yU5g== X-Received: by 10.66.144.170 with SMTP id sn10mr17966495pab.42.1368195185344; Fri, 10 May 2013 07:13:05 -0700 (PDT) MIME-Version: 1.0 Sender: lists@eitanadler.com Received: by 10.66.159.97 with HTTP; Fri, 10 May 2013 07:12:34 -0700 (PDT) In-Reply-To: References: <201305100342.r4A3gmc9080595@svn.freebsd.org> <20130510074235.GA19945@FreeBSD.org> <20130510133637.GA1679@FreeBSD.org> From: Eitan Adler Date: Fri, 10 May 2013 10:12:34 -0400 X-Google-Sender-Auth: d9kKuQaI7SBuKSWtv2M9yE1sT9k Message-ID: Subject: Re: svn commit: r250430 - head/sbin/dmesg To: David Chisnall Content-Type: text/plain; charset=UTF-8 X-Gm-Message-State: ALoCoQlhm3fwFHq4zIE2zWFI8RimIMajwfcOiR9m+dUqp9o+iuR0zGfXbqTNB4d0T6jnXJg+Koc6 Cc: svn-src-head@freebsd.org, Alexey Dokuchaev , src-committers@freebsd.org, svn-src-all@freebsd.org X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 10 May 2013 14:13:06 -0000 On 10 May 2013 10:08, David Chisnall wrote: > On 10 May 2013, at 10:01, Eitan Adler wrote: > >> I thought style(9) disliked the leading (void) but I could be wrong. > > The cast to (void) tells the compiler that you are ignoring the return result. Without it, you will introduce new warnings and break the build on certain compiler versions with -Werror. I know why the (void) is there. lint(1) is the main program which cares about it. I don't remember any recent tool which uses that cast to remove errors. This has nothing to do with my change though. That said I remembered some prior discussion claiming that style(9) does not require them. A quick recheck shows (void)fprintf(stderr, "usage: f [-ab]\n"); as an example, so clearly I was wrong. -- Eitan Adler Source, Ports, Doc committer Bugmeister, Ports Security teams