From owner-freebsd-bugs@FreeBSD.ORG  Thu Mar 21 17:00:01 2013
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
Delivered-To: freebsd-bugs@smarthost.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.FreeBSD.org [8.8.178.115])
 by hub.freebsd.org (Postfix) with ESMTP id 7FB54EA
 for <freebsd-bugs@smarthost.ysv.freebsd.org>;
 Thu, 21 Mar 2013 17:00:01 +0000 (UTC)
 (envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
 [IPv6:2001:1900:2254:206c::16:87])
 by mx1.freebsd.org (Postfix) with ESMTP id 5A0E6BDA
 for <freebsd-bugs@smarthost.ysv.freebsd.org>;
 Thu, 21 Mar 2013 17:00:01 +0000 (UTC)
Received: from freefall.freebsd.org (localhost [127.0.0.1])
 by freefall.freebsd.org (8.14.6/8.14.6) with ESMTP id r2LH01f8021549
 for <freebsd-bugs@freefall.freebsd.org>; Thu, 21 Mar 2013 17:00:01 GMT
 (envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
 by freefall.freebsd.org (8.14.6/8.14.6/Submit) id r2LH0189021547;
 Thu, 21 Mar 2013 17:00:01 GMT (envelope-from gnats)
Date: Thu, 21 Mar 2013 17:00:01 GMT
Message-Id: <201303211700.r2LH0189021547@freefall.freebsd.org>
To: freebsd-bugs@FreeBSD.org
Cc: 
From: hiren panchasara <hiren.panchasara@gmail.com>
Subject: Re: kern/177155: [patch] Fixing clang warnings at /sys/dev/safe
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
Reply-To: hiren panchasara <hiren.panchasara@gmail.com>
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-bugs>,
 <mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
 <mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 21 Mar 2013 17:00:01 -0000

The following reply was made to PR kern/177155; it has been noted by GNATS.

From: hiren panchasara <hiren.panchasara@gmail.com>
To: FreeBSD-gnats-submit@freebsd.org, freebsd-bugs@freebsd.org
Cc:  
Subject: Re: kern/177155: [patch] Fixing clang warnings at /sys/dev/safe
Date: Thu, 21 Mar 2013 09:58:56 -0700

 On Wed, Mar 20, 2013 at 1:10 PM,  <FreeBSD-gnats-submit@freebsd.org> wrote:
 > Thank you very much for your problem report.
 > It has the internal identification `kern/177155'.
 > The individual assigned to look at your
 > report is: freebsd-bugs.
 >
 > You can access the state of your problem report at any time
 > via this link:
 >
 > http://www.freebsd.org/cgi/query-pr.cgi?pr=177155
 >
 >>Category:       kern
 >>Responsible:    freebsd-bugs
 >>Synopsis:       [patch] Fixing clang warnings at /sys/dev/safe
 >>Arrival-Date:   Wed Mar 20 20:10:00 UTC 2013
 
 Taking a closer look, more correct fix looks like this:
 
 Index: sys/dev/safe/safe.c
 ===================================================================
 --- sys/dev/safe/safe.c (revision 248555)
 +++ sys/dev/safe/safe.c (working copy)
 @@ -122,7 +122,7 @@
  static void safe_intr(void *);
  static void safe_callback(struct safe_softc *, struct safe_ringentry *);
  static void safe_feed(struct safe_softc *, struct safe_ringentry *);
 -static void safe_mcopy(struct mbuf *, struct mbuf *, u_int);
 +static void safe_mcopy(struct mbuf *, struct mbuf *, int);
  #ifndef SAFE_NO_RNG
  static void safe_rng_init(struct safe_softc *);
  static void safe_rng(void *);
 @@ -1598,10 +1598,11 @@
   * Copy all data past offset from srcm to dstm.
   */
  static void
 -safe_mcopy(struct mbuf *srcm, struct mbuf *dstm, u_int offset)
 +safe_mcopy(struct mbuf *srcm, struct mbuf *dstm, int offset)
  {
 -       u_int j, dlen, slen;
 +       u_int dlen, slen;
         caddr_t dptr, sptr;
 +       int j;
 
         /*
          * Advance src and dst to offset.
 
 Reason being (as per my understanding):
 safe_mcopy() is being called from only one place: safe_process() where
 3rd arg to safe_mcopy() oplen is of type int.
 
 Thanks,
 Hiren