Date: Mon, 23 Apr 2018 13:05:01 -0300 From: Joseph Mingrone <jrm@FreeBSD.org> To: Yuri <yuri@freebsd.org> Cc: Mathieu Arnold <mat@freebsd.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r468086 - in head/math: . piranha Message-ID: <86k1sx9adu.fsf@phe.ftfl.ca> In-Reply-To: <b8c76e65-a4f4-9db2-ba9d-f2c9a43c417b@freebsd.org> (Yuri's message of "Mon, 23 Apr 2018 08:44:15 -0700") References: <201804230903.w3N93LhK062379@repo.freebsd.org> <20180423123756.fvitgl3rll4yikeq@ogg.in.absolight.net> <b8c76e65-a4f4-9db2-ba9d-f2c9a43c417b@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--=-=-= Content-Type: text/plain Yuri <yuri@freebsd.org> writes: > On 04/23/18 05:37, Mathieu Arnold wrote: >> Unless this really needs cmake and ninja to run, please reverse the way >> you create the BUILD_DEPENDS and RUN_DEPENDS variables. You may have >> noticed many ports do BUILD_DEPENDS=${RUN_DEPENDS} and RUN_DEPENDS=blah. > The way how they defined the build, it does involve cmake. cmake isn't "really needed" because cmake doesn't really build anything, but it does install it. It is also needed for the 'test' target. > You prefer it the way around, "BUILD_DEPENDS=${RUN_DEPENDS} and RUN_DEPENDS=blah"? But doesn't it end up being the same? > Yuri Hello Yuri, USES=cmake:outsource adds to BUILD_DEPENDS, so when you set RUN_DEPENDS to BUILD_DEPENDS, you add unwanted ports to RUN_DEPENDS. Current port: % make -VRUN_DEPENDS /usr/local/include/boost/numeric/conversion/cast.hpp:devel/boost-libs /usr/local/include/gmp.h:math/gmp /usr/local/include/mpfr.h:math/mpfr /usr/local/bin/cmake:devel/cmake ninja:devel/ninja With: BUILD_DEPENDS= ${RUN_DEPENDS} RUN_DEPENDS= ${LOCALBASE}/include/boost/numeric/conversion/cast.hpp:devel/boost-libs \ ${LOCALBASE}/include/gmp.h:math/gmp \ ${LOCALBASE}/include/mpfr.h:math/mpfr % make -VRUN_DEPENDS /usr/local/include/boost/numeric/conversion/cast.hpp:devel/boost-libs /usr/local/include/gmp.h:math/gmp /usr/local/include/mpfr.h:math/mpfr J. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKTBAEBCgB9FiEEVbCTpybDiFVxIrrVNqQMg7DW754FAlreBC1fFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDU1 QjA5M0E3MjZDMzg4NTU3MTIyQkFENTM2QTQwQzgzQjBENkVGOUUACgkQNqQMg7DW 757NtxAAmxQZZt2UQeiOJESqapoh1iLjnBPW2wxZoOKdE+rq3m5QjSDRgWG6FODw n0Dum45hmFS9AKeQULvZH01PzHF8jKedds6MCaR5YYFb6Tg+6Zn5Ruo0E4NWHhvZ GDiFZ5/IzBLDJM5bnP9YtOWgehWTnRjokNyxcKgLpXEb2hCTXILtag+dFSOaYOdC BXy79QP0qcrh3uDzMfx8t+bC5S7ugjeB4YlDkhDBdyBJROKAzwl+83L0CSlHzcPc cM9a7HJyvubUxWCTHQNx6rXlTgofMc1cNmR39lYcDdg/9xJnRvMvJV68iTfMsSae gbT38UgEBvvIYKnmWU4MhClmgHhTb/ijCJeLXvKzJ+UbkzwSWnNkmJci50QXyT90 dNyABXdsB1u5T0ia8OBqbm6fcRsN61yLpfjOFYDui+jMRT1PjgHblQh+j+fywHi8 rkcZImJKalffBt9qHfJQf3xXricQb9LwXnyFdTKrASCjDzUPu/irluTY1ilm+JDp S+vSfauegm166Bk8LfjGgJ/pCfVct0jNOKDXT8EyjP9nN6t0Ywr2EzEX7ZMdW2kx pVbtRHxu27IWcNit/dOnbyEXN1USqdOMUg5TRB+prrkZJBT9RGTpLmgzd+E3dx9D 4CpHSPrETE+mPMuzSkucVM6I/KpFYC6/2nsVQ7op3AGGUc0mNNk= =o2nk -----END PGP SIGNATURE----- --=-=-=--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?86k1sx9adu.fsf>