From nobody Wed Jan 22 21:47:14 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Ydd2q0WShz5l6c6; Wed, 22 Jan 2025 21:47:15 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Ydd2p734bz3RY1; Wed, 22 Jan 2025 21:47:14 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1737582435; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=TK0pwdqMeILTqMAAxMm1YLC9//nDDkiTm7rpk4GuVv4=; b=vhm9j6TINPDsm+H0zvedoyktdTMlmzGsyV6eC/yeq4wdXDxwhZ86TkPZxe4Fbz6iLEL+lx jaKjgiiW51IVgYEK/DO70pOYwE5NQS+aLlvx7rlPS+Vu1Z5xCFZ4ZDSxL5a6ElaLNVmsUk a2VfXpi9FtaYf/7yd0k/fCTOAWiM58CHLp1jVARiXBBEML71Ku6Ux4K6Qehck0zz66rwXK Y8MlQqru4yupvUK8byjC9Dcj/zFD7g5Ih0kx8orN7hMYpxjTDJMtTttUrhJblVSBvAAmMI OsKPfHCeubqCkcZqS8LAXDagcOoDsQJUKdPCbYFzSdh7G5UoJ52DhHNx+jmJOg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1737582435; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=TK0pwdqMeILTqMAAxMm1YLC9//nDDkiTm7rpk4GuVv4=; b=tD7Ss5t5b1J3zQfYvFZ0J7lESvppwfhhWIJE9093cKluwrQAmeLzi0Ljp4MLzPD+HDn3F8 Wv6ZzyF/EBf4dY7aGHWkv3jsYEf8WsfpwwIfPM1ihxBUgcKIp7L4jWqjzfNjlSKV/OR7dy jwDkoDNwnGqTr8DW2aPn5sPR9ob9mryv1Cpu+spggdEqsU00NpiWaq9grp8gK00TaXP2sn YcnuLHAY8XdEO7NQM20aeGO5f8H7Q21LcezSGR8nCLKkra3nY5hWFTVmblrTmGQS9KFqA1 5SOrerx9AJ53MqW8M7A00EMZ5Zb8HYlhO11Jlfq+ooxvwmb7su02+I3DO9fSKg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1737582435; a=rsa-sha256; cv=none; b=wcdVzdK/M5NukCJG9AdSXio877YbRmCV7zFWU/3EmPf/ehJWpTcXa8/vCu5troYvccsKPx 4wT8m9/ntjh8/ArKiIrTllHzO9eTR/9JyxQRhmLPUCaOFxkHQkCvEsP9yUMfKFosXAnZTW RmyPRkbH4dc63/9lqjkTq5uChg4qHf9DHYlHLxyBDEu4PEOC7tIO+THGwLo18yVzJ43ogo Xa564bSnQnNb0dHPFuXiqJ5u/ScO51q5CNIekjIkqgw+J8+JgRunkbcokvoZ3Ed6C2xf5M 26/SvT5F3i+NpNd2bNDIB+j9AhXQGPQJK4dGVNt8uSvZdHRxpOIeWd6PurWWQw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4Ydd2p6Ywqz18Xg; Wed, 22 Jan 2025 21:47:14 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 50MLlEXx009076; Wed, 22 Jan 2025 21:47:14 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 50MLlE27009073; Wed, 22 Jan 2025 21:47:14 GMT (envelope-from git) Date: Wed, 22 Jan 2025 21:47:14 GMT Message-Id: <202501222147.50MLlE27009073@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Adrian Chadd Subject: git: 5f9a2eec337c - main - rtwn: bring the RTL8192EU RF read/write routines in line with rtl8xxxu List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: adrian X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 5f9a2eec337c9cfdbfa800aff8875f5424e847e8 Auto-Submitted: auto-generated The branch main has been updated by adrian: URL: https://cgit.FreeBSD.org/src/commit/?id=5f9a2eec337c9cfdbfa800aff8875f5424e847e8 commit 5f9a2eec337c9cfdbfa800aff8875f5424e847e8 Author: Adrian Chadd AuthorDate: 2025-01-19 01:08:32 +0000 Commit: Adrian Chadd CommitDate: 2025-01-22 21:46:57 +0000 rtwn: bring the RTL8192EU RF read/write routines in line with rtl8xxxu The Linux rtl8xxxu driver has more delays in the RF read and write path. It looks like for writes it's ensuring the hardware is out of power save and that the transition has properly occured. And it looks for reads that it wants a delay after some bit setting, likely some shifting into the RF register space is occuring with a bit set/clear to trigger a load. See rtl8xxxu_write_rfreg() and rtl8xxxu_read_rfreg() for more information. Differential Revision: https://reviews.freebsd.org/D48512 Obtained from: Linux rtl8xxxu --- sys/dev/rtwn/rtl8192e/r92e_rf.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/sys/dev/rtwn/rtl8192e/r92e_rf.c b/sys/dev/rtwn/rtl8192e/r92e_rf.c index 8e05a827262b..478945d13c85 100644 --- a/sys/dev/rtwn/rtl8192e/r92e_rf.c +++ b/sys/dev/rtwn/rtl8192e/r92e_rf.c @@ -64,7 +64,9 @@ r92e_rf_read(struct rtwn_softc *sc, int chain, uint8_t addr) RW(val, R92C_HSSI_PARAM2_READ_ADDR, addr) & ~R92C_HSSI_PARAM2_READ_EDGE); + rtwn_delay(sc, 10); rtwn_bb_setbits(sc, R92C_HSSI_PARAM2(0), R92C_HSSI_PARAM2_READ_EDGE, 0); + rtwn_delay(sc, 100); rtwn_bb_setbits(sc, R92C_HSSI_PARAM2(0), 0, R92C_HSSI_PARAM2_READ_EDGE); rtwn_delay(sc, 20); @@ -82,5 +84,6 @@ r92e_rf_write(struct rtwn_softc *sc, int chain, uint8_t addr, uint32_t val) rtwn_bb_setbits(sc, 0x818, 0x20000, 0); rtwn_bb_write(sc, R92C_LSSI_PARAM(chain), SM(R88E_LSSI_PARAM_ADDR, addr) | SM(R92C_LSSI_PARAM_DATA, val)); + rtwn_delay(sc, 1); rtwn_bb_setbits(sc, 0x818, 0, 0x20000); }