Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 30 Oct 2015 08:06:24 +0000 (UTC)
From:      Garrett Cooper <ngie@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r290185 - head/lib/libc/tests/ssp
Message-ID:  <201510300806.t9U86OML030697@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: ngie
Date: Fri Oct 30 08:06:24 2015
New Revision: 290185
URL: https://svnweb.freebsd.org/changeset/base/290185

Log:
  Disable h_raw/h_read with gcc
  
  I forgot that these testcases fail with gcc 4.2.1; add a note to that effect
  
  MFC after: never
  Sponsored by: EMC / Isilon Storage Division

Modified:
  head/lib/libc/tests/ssp/Makefile

Modified: head/lib/libc/tests/ssp/Makefile
==============================================================================
--- head/lib/libc/tests/ssp/Makefile	Fri Oct 30 08:01:53 2015	(r290184)
+++ head/lib/libc/tests/ssp/Makefile	Fri Oct 30 08:06:24 2015	(r290185)
@@ -26,10 +26,15 @@ PROGS+=		h_memmove
 PROGS+=		h_memset
 # This testcase doesn't run properly when not compiled with -fsantize=bounds
 # with clang, which is currently contingent on a compiler_rt update
-.if (${COMPILER_TYPE} != "clang" || \
-     (${COMPILER_VERSION} < 30500 || 30700 <= ${COMPILER_VERSION}))
+#
+# XXX: the h_raw/h_read testcases don't cause a SIGABRT with in-tree gcc right
+# now on amd64 when it trips the stack bounds specified in t_ssp.sh . This
+# probably needs to be fixed as it's currently hardcoded.
+.if ${COMPILER_TYPE} == "clang"
+.if ${COMPILER_VERSION} < 30500 || 30700 <= ${COMPILER_VERSION}
 PROGS+=		h_raw
 .endif
+.endif
 PROGS+=		h_read
 PROGS+=		h_readlink
 PROGS+=		h_snprintf



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201510300806.t9U86OML030697>