From owner-svn-src-all@FreeBSD.ORG Wed Jan 20 09:46:33 2010 Return-Path: Delivered-To: svn-src-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 9F23F106566C; Wed, 20 Jan 2010 09:46:33 +0000 (UTC) (envelope-from ache@nagual.pp.ru) Received: from nagual.pp.ru (nagual.pp.ru [194.87.13.69]) by mx1.freebsd.org (Postfix) with ESMTP id F12948FC15; Wed, 20 Jan 2010 09:46:32 +0000 (UTC) Received: from nagual.pp.ru (ache@localhost [127.0.0.1]) by nagual.pp.ru (8.14.3/8.14.3) with ESMTP id o0K9kU34053414; Wed, 20 Jan 2010 12:46:30 +0300 (MSK) (envelope-from ache@nagual.pp.ru) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=nagual.pp.ru; s=default; t=1263980790; bh=TO51WibxmPIRQFA0xFt8/aR7ntoxCYpjy2hTdDmvzhY=; l=1947; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:In-Reply-To; b=dMq3VGFBtJxA5AvEWvFvR2Mo8DJ+bLHa4XTdcH9puLWeLPfJ7XxYuI3rrctzBhIt7 Kr3pMGg74hVrZtykZkSi88BQfjVpqBAwVsMdp1KEt2g9TnJvEcm8Ed9D66TitL0I3Z daPPAx+lAztKdzgXvObnMyz53alXI23os/Imtbb0= Received: (from ache@localhost) by nagual.pp.ru (8.14.3/8.14.3/Submit) id o0K9kTMH053413; Wed, 20 Jan 2010 12:46:30 +0300 (MSK) (envelope-from ache) Date: Wed, 20 Jan 2010 12:46:28 +0300 From: Andrey Chernov To: Bruce Evans Message-ID: <20100120094627.GA53020@nagual.pp.ru> Mail-Followup-To: Andrey Chernov , Bruce Evans , src-committers@FreeBSD.org, svn-src-all@FreeBSD.org, svn-src-head@FreeBSD.org References: <201001181344.o0IDiiEL079037@svn.freebsd.org> <20100120012639.B67517@delplex.bde.org> <20100120070843.GA45937@nagual.pp.ru> <20100120191752.Q2120@besplex.bde.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20100120191752.Q2120@besplex.bde.org> User-Agent: Mutt/1.5.20 (2009-06-14) Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: svn commit: r202572 - head/lib/libc/gen X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 Jan 2010 09:46:33 -0000 On Wed, Jan 20, 2010 at 07:43:29PM +1100, Bruce Evans wrote: > No, it is a comment about opendir()'s comparison function. It has nothing > to do with scandir(), and the only thing that it has to do with alphasort() > is that it must be different for the reasons described. Then the comment was plain wrong (not misplaced), so removing it becomes right again because the comment states: "opendir()'s comparison function" according to POSIX 2008 and XSI 7 should use strcoll(). But there is nothing said about opendir() & strcoll() relation in the mentioned standards. The only word I found is that opendir() returns "ordered" sequence, but nowhere mentioned ordered by what criteria, so perhaps they mean "stable": "The type DIR, which is defined in the header, represents a directory stream, which is an ordered sequence of all the directory entries in a particular directory." > page more than here. BTW, I don't remember any man page updates for > this. The man page still only says that alphasort() can be used to > give alphabetical sorting in scandir(). Alphabetically already means sorted according to collate, otherwhise it is called binary. Perhaps manpage should refer strcoll() directly. > I can't see this now (some illusion from my mailer or $TERMCAP > misformatting the patch?), but now I see an extra "the" in it: > > "requires the alphasort() to use strcoll()" > > should be either > > "requires that alphasort() uses strcoll()" > > (preferred) or > > "requires alphasort() to use strcoll()" > > (probably intended, but not too passive). I thought that you removed > this line completely. The previous line is even less useful. I don't add extra "the" there) What do you want, clarify please: 1) Remove whole comment. 2) Remove only first line and correct second to "that". 3) Just correct second to "that". -- http://ache.pp.ru/