From nobody Mon Jun 9 11:59:15 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4bG9Sy5p7Mz5y26h; Mon, 09 Jun 2025 11:59:30 +0000 (UTC) (envelope-from rick.macklem@gmail.com) Received: from mail-ej1-x62e.google.com (mail-ej1-x62e.google.com [IPv6:2a00:1450:4864:20::62e]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4bG9Sy3SSmz3Z9R; Mon, 09 Jun 2025 11:59:30 +0000 (UTC) (envelope-from rick.macklem@gmail.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-ej1-x62e.google.com with SMTP id a640c23a62f3a-ade58ef47c0so182853466b.1; Mon, 09 Jun 2025 04:59:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1749470368; x=1750075168; darn=freebsd.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=14tBxsff4ZoNnteaBwj9wq67HY4bvKrZaaeOa2UtVEE=; b=FaWQWiP0QFRRgQd/yCnH6z853c5IjVCU5YHWlMKAonhsWjpaj18uLLsZMG+mjyrgTW aJVEA90qUU8ImqHWopQCpZiym9KKler0s7v4Ms3R+9GmHPHfLfKDdIRcd9t2XBix4uNi qYxIrz8IhxzxkGrd+zdWfcVht/BSIUcB/9f8OMIe4qWSMfXwB9a6QxuHjXGDNJkdyBOU diNO6q6aW3/SrxI13QdT8XX36n6B/sufAiBj/2WUYCGVk99Q26t1Kl60Q0K/5XzyksEz XMp/8uE7q9XTSVpoJ7IjlbSSVfL0rZiNHZ4G9ycGsxsbypdgft7ygrRey0r2h3IGXgPZ Q1MQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749470368; x=1750075168; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=14tBxsff4ZoNnteaBwj9wq67HY4bvKrZaaeOa2UtVEE=; b=XJEYZ4OuhnwoIifwQaQaG1y2bam0h+tBuw4u2PvVeJn8l0ntEIJ1rf/T9KjqYsHXQ1 lHy5iK0urOeF2Yqfbu51uKgp6X1JiuCKQ6ip9OB5j1ydfRr5SrOpBMy2IcsnRIHxiEKg NRFbxmhdUzKm04ktkCHX4CvLtzyPSshSTaIdqzawq36Xy+G5BcicY4IQLhfFkqrkVeTy Ar1GLZB398B3+krftc90xplAXa5VRhR0LFfuqa+xQTGSQ4TDaAMK7PQ3KytXC1xAqPXX KK3om+km2myhJyt11S26qusbssAtFqCmMiVr2Csv2x7G7secTThG43bTHyyE9rTKEDrR syyA== X-Forwarded-Encrypted: i=1; AJvYcCV0JUNfvbHFnvSbD2BnU+CI3iqLLnImaEUJJp/fqEmj3MrNVtEwTYNPkZIbZD4Fksy8tbSFJKxyJSLmLxyOjODNhLFF@freebsd.org, AJvYcCVRVqpmMoNosAPMpMCa8lKp+azStbdoyg/+mp4w8Wio76SXmWK+WLgkBt7/1okDP7RiEQfPMv3V0tl9gv66V1X480GL57k=@freebsd.org, AJvYcCVgbHHZ7rWIdas5mYk/+DP6sldPffIBb9n1P1L14Jaykq6ZVWEQr+rDUyKr3U0MRt3EcrahBPbPUrUClwejyKA=@freebsd.org X-Gm-Message-State: AOJu0Yw27QpyizShT5nvFN1U5AQptWrMlAfDGav4fXLRyZqU0bmXxu9P UHIiNOSX4+/L/86LCFyZiekprVR/qhfttEiJ082Ut60/uPggjFo4GLynl6HmYbAtnGLRRXlfDIk hjWw22Wj+MS7nQnbrE/9Mm7EmR2icFg== X-Gm-Gg: ASbGnctVnV8KRArGs9vLnbMY9YB0CGBlIkcVdI3axpPdR3ZqVIjODz+XjURqGH2X9Pg atwhmJA7ZPtvVbx0GLjzkGBJovJrFAXivg0T9AaG3zZjXUJPcOuC193zk96snS1h+HR/cParNaI NXDrb6+7tm7rCuVoCQnxE92Fijpe3ae6hd1i6q9EfvfAZn4D1fXDnk5fwHv5Y4VUb6 X-Google-Smtp-Source: AGHT+IFd+rw2Ez+h8cUFkCrLNVk5TpguTSlw/jhp0L/yafEnN/+L6X84hsdwiXTRCcfpDNoxQ4j8HoliQjVc+whrkpY= X-Received: by 2002:a17:906:ef0e:b0:ad8:908d:20f3 with SMTP id a640c23a62f3a-ade07894142mr1536979666b.28.1749470367490; Mon, 09 Jun 2025 04:59:27 -0700 (PDT) List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 References: <202506091053.559ArJ8k043104@gitrepo.freebsd.org> In-Reply-To: From: Rick Macklem Date: Mon, 9 Jun 2025 04:59:15 -0700 X-Gm-Features: AX0GCFtfYgjMcwSIsL0jiYGG5sN3SRmG8cP5EvC52vQ_5-BGQiEGT3gLZPH2NdQ Message-ID: Subject: Re: git: 79d0f4474653 - main - rpcbind: Ensure krpc is present. To: Konstantin Belousov Cc: =?UTF-8?Q?Dag=2DErling_Sm=C3=B8rgrav?= , src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 4bG9Sy3SSmz3Z9R X-Spamd-Bar: ---- X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; TAGGED_FROM(0.00)[]; ASN(0.00)[asn:15169, ipnet:2a00:1450::/32, country:US] On Mon, Jun 9, 2025 at 4:49=E2=80=AFAM Konstantin Belousov wrote: > > CAUTION: This email originated from outside of the University of Guelph. = Do not click links or open attachments unless you recognize the sender and = know the content is safe. If in doubt, forward suspicious emails to IThelp@= uoguelph.ca. > > On Mon, Jun 09, 2025 at 10:53:19AM +0000, Dag-Erling Sm=C3=B8rgrav wrote: > > The branch main has been updated by des: > > > > URL: https://cgit.FreeBSD.org/src/commit/?id=3D79d0f447465394fee8afa833= dbdeb1a5f3ed52c3 > > > > commit 79d0f447465394fee8afa833dbdeb1a5f3ed52c3 > > Author: Dag-Erling Sm=C3=B8rgrav > > AuthorDate: 2025-06-09 10:52:21 +0000 > > Commit: Dag-Erling Sm=C3=B8rgrav > > CommitDate: 2025-06-09 10:52:21 +0000 > > > > rpcbind: Ensure krpc is present. > > > > MFC after: 1 week > > Reviewed by: rmacklem, glebius > > Differential Revision: https://reviews.freebsd.org/D50627 > > --- > > usr.sbin/rpcbind/rpcbind.c | 35 +++++++++++++++++++++-------------- > > 1 file changed, 21 insertions(+), 14 deletions(-) > > > > diff --git a/usr.sbin/rpcbind/rpcbind.c b/usr.sbin/rpcbind/rpcbind.c > > index 1397a0222396..622e954f903b 100644 > > --- a/usr.sbin/rpcbind/rpcbind.c > > +++ b/usr.sbin/rpcbind/rpcbind.c > > @@ -39,34 +39,38 @@ > > * > > */ > > > > -#include > > -#include > > -#include > > -#include > > +#include > > +#include > > +#include > > #include > > -#include > > #include > > #include > > +#include > > +#include > > #include > > +#include > > + > > #include > > #include > > #ifdef PORTMAP > > #include > > #endif > > #include > > + > > #include > > +#include > > +#include > > #include > > +#include > > #include > > +#include > > #include > > #include > > -#include > > #include > > -#include > > -#include > > -#include > > -#include > > #include > > -#include > > +#include > > +#include > > + > > #include "rpcbind.h" > > > > /* Global variables */ > > @@ -148,12 +152,15 @@ main(int argc, char *argv[]) > > > > update_bound_sa(); > > > > + /* Ensure krpc is loaded */ > > + if (modfind("krpc") < 0 && kldload("krpc") < 0) > > + err(1, "krpc"); > Why does rpcbind need krpc mod? > I understand that today most uses of Sun RPC are coming from nfs stuff. > But it is still not the only application. E.g., NIS is still there. I asked the same thig during review. It appears that the requirement is based on the recent change to using RPC over netlink instead of a unix domain socket, done by glebius@. rick