From owner-svn-src-all@FreeBSD.ORG  Sat Dec 15 00:13:18 2012
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
 by hub.freebsd.org (Postfix) with ESMTP id E84C5F34;
 Sat, 15 Dec 2012 00:13:18 +0000 (UTC)
 (envelope-from yanegomi@gmail.com)
Received: from mail-oa0-f54.google.com (mail-oa0-f54.google.com
 [209.85.219.54])
 by mx1.freebsd.org (Postfix) with ESMTP id 7C08F8FC19;
 Sat, 15 Dec 2012 00:13:18 +0000 (UTC)
Received: by mail-oa0-f54.google.com with SMTP id n9so4199582oag.13
 for <multiple recipients>; Fri, 14 Dec 2012 16:13:17 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
 h=mime-version:in-reply-to:references:date:message-id:subject:from:to
 :cc:content-type;
 bh=DyRItChpziaIfYYTDnX0QOZIZ6mO0hTJx7q/OaAF6y4=;
 b=GDYRdT2DAjlbmYMdgZ9SlKas7VFLC7mXfMRXuLIZrXFF77JEm0rsHauRuGXql7mrz8
 WCUyc6bJDw/wdQQaJBIK6/j5QdmbAFpZfHcWawHwaf/7PvTLTmhrbUmN6LV3FQhFTFoS
 PNjG+OGtAXEUgPjcYV8pSFfyiTvkxhSDu3WrIR37N2BJ+oPiRDx7b0uh2xcxdacBL8tX
 p2tTf5VjqMF2NZg278lV3qwph8JtmB32lSXG68ocu08DOO7rmrEAXsEtlhiWgcDnXcIm
 8hte6kdvU7kXXHxyJjA7ohf/WT998xSQhnvdNpc0A+hkqkWMPTdIC/uTACo9f/C5IhVX
 PKOQ==
MIME-Version: 1.0
Received: by 10.182.2.169 with SMTP id 9mr6152277obv.66.1355530397622; Fri, 14
 Dec 2012 16:13:17 -0800 (PST)
Received: by 10.76.143.33 with HTTP; Fri, 14 Dec 2012 16:13:17 -0800 (PST)
In-Reply-To: <201212150003.qBF03Zr0085865@svn.freebsd.org>
References: <201212150003.qBF03Zr0085865@svn.freebsd.org>
Date: Fri, 14 Dec 2012 16:13:17 -0800
Message-ID: <CAGH67wQT0rRocJ5Zhxv0=Rjy3q_ECby45Y+753R1E8FSwbXzpA@mail.gmail.com>
Subject: Re: svn commit: r244236 - head/share/mk
From: Garrett Cooper <yanegomi@gmail.com>
To: Ed Maste <emaste@freebsd.org>
Content-Type: text/plain; charset=ISO-8859-1
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
 src-committers@freebsd.org
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 15 Dec 2012 00:13:19 -0000

On Fri, Dec 14, 2012 at 4:03 PM, Ed Maste <emaste@freebsd.org> wrote:
> Author: emaste
> Date: Sat Dec 15 00:03:35 2012
> New Revision: 244236
> URL: http://svnweb.freebsd.org/changeset/base/244236

...

> Modified: head/share/mk/sys.mk
> ==============================================================================
> --- head/share/mk/sys.mk        Fri Dec 14 23:13:06 2012        (r244235)
> +++ head/share/mk/sys.mk        Sat Dec 15 00:03:35 2012        (r244236)
> @@ -134,6 +134,8 @@ NM          ?=      nm
>  OBJC           ?=      cc
>  OBJCFLAGS      ?=      ${OBJCINCLUDES} ${CFLAGS} -Wno-import
>
> +OBJCOPY                ?=      objcopy
> +
>  PC             ?=      pc
>  PFLAGS         ?=

    This shouldn't be defined when !defined(%POSIX) is true. The
.endif should be pulled down to just above SHELL?= according to what
I'm reading in http://pubs.opengroup.org/onlinepubs/009695399/utilities/make.html
.
    Other spots in the tree where OBJCOPY?= is noted can be probably
start to be reaped (thinking about sys/boot/, etc in particular). I
have a PR open for some work Warner started with an initial patch that
I've kind of been keeping up to date in git, but it needs to be
updated now per this change (and also because I didn't notice that
these variables weren't supposed to be defined when POSIX mode was
on).
Thanks!
-Garrett