Date: Fri, 14 Dec 2012 16:13:17 -0800 From: Garrett Cooper <yanegomi@gmail.com> To: Ed Maste <emaste@freebsd.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r244236 - head/share/mk Message-ID: <CAGH67wQT0rRocJ5Zhxv0=Rjy3q_ECby45Y%2B753R1E8FSwbXzpA@mail.gmail.com> In-Reply-To: <201212150003.qBF03Zr0085865@svn.freebsd.org> References: <201212150003.qBF03Zr0085865@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, Dec 14, 2012 at 4:03 PM, Ed Maste <emaste@freebsd.org> wrote: > Author: emaste > Date: Sat Dec 15 00:03:35 2012 > New Revision: 244236 > URL: http://svnweb.freebsd.org/changeset/base/244236 ... > Modified: head/share/mk/sys.mk > ============================================================================== > --- head/share/mk/sys.mk Fri Dec 14 23:13:06 2012 (r244235) > +++ head/share/mk/sys.mk Sat Dec 15 00:03:35 2012 (r244236) > @@ -134,6 +134,8 @@ NM ?= nm > OBJC ?= cc > OBJCFLAGS ?= ${OBJCINCLUDES} ${CFLAGS} -Wno-import > > +OBJCOPY ?= objcopy > + > PC ?= pc > PFLAGS ?= This shouldn't be defined when !defined(%POSIX) is true. The .endif should be pulled down to just above SHELL?= according to what I'm reading in http://pubs.opengroup.org/onlinepubs/009695399/utilities/make.html . Other spots in the tree where OBJCOPY?= is noted can be probably start to be reaped (thinking about sys/boot/, etc in particular). I have a PR open for some work Warner started with an initial patch that I've kind of been keeping up to date in git, but it needs to be updated now per this change (and also because I didn't notice that these variables weren't supposed to be defined when POSIX mode was on). Thanks! -Garrett
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAGH67wQT0rRocJ5Zhxv0=Rjy3q_ECby45Y%2B753R1E8FSwbXzpA>