From owner-cvs-src@FreeBSD.ORG  Fri Jul  9 21:43:57 2004
Return-Path: <owner-cvs-src@FreeBSD.ORG>
Delivered-To: cvs-src@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id B71F616A4CE; Fri,  9 Jul 2004 21:43:57 +0000 (GMT)
Received: from elvis.mu.org (elvis.mu.org [192.203.228.196])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id AB80943D3F; Fri,  9 Jul 2004 21:43:57 +0000 (GMT)
	(envelope-from bright@elvis.mu.org)
Received: by elvis.mu.org (Postfix, from userid 1192)
	id A0B0C5C8E1; Fri,  9 Jul 2004 14:43:57 -0700 (PDT)
Date: Fri, 9 Jul 2004 14:43:57 -0700
From: Alfred Perlstein <alfred@freebsd.org>
To: Dag-Erling Smorgrav <des@FreeBSD.org>
Message-ID: <20040709214357.GZ95729@elvis.mu.org>
References: <200407091143.i69Bhbvt053927@repoman.freebsd.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <200407091143.i69Bhbvt053927@repoman.freebsd.org>
User-Agent: Mutt/1.4.2.1i
cc: cvs-src@FreeBSD.org
cc: src-committers@FreeBSD.org
cc: cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sys/fs/pseudofs pseudofs_vnops.c
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 09 Jul 2004 21:43:57 -0000

* Dag-Erling Smorgrav <des@FreeBSD.org> [040709 04:43] wrote:
> des         2004-07-09 11:43:37 UTC
> 
>   FreeBSD src repository
> 
>   Modified files:
>     sys/fs/pseudofs      pseudofs_vnops.c 
>   Log:
>   Accumulate directory entries in a fixed-length sbuf, and uiomove them in
>   one go before returning.  This avoids calling uiomove() while holding
>   allproc_lock.
>   
>   Don't adjust uio->uio_offset manually, uiomove() does that for us.
>   
>   Don't drop allproc_lock before calling panic().

I would suggest dropping it.  (but I may be wrong).

>   Suggested by:   alfred

thanks! :)

Also, the routines for inode allocation in psuedofs are very useful,
is there some way I can convince you to make them available as a
resource for other synthetic filesystems?

Perhaps split it out into another module that psuedofs can depend on
so that other fs's can use them?

thank you,
-- 
- Alfred Perlstein
- Research Engineering Development Inc.
- email: bright@mu.org cell: 408-480-4684