From owner-freebsd-current@FreeBSD.ORG  Sat May 12 06:51:38 2007
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
X-Original-To: freebsd-current@freebsd.org
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id BAB0216A400
	for <freebsd-current@freebsd.org>; Sat, 12 May 2007 06:51:38 +0000 (UTC)
	(envelope-from Yuriy.Tsibizov@gfk.ru)
Received: from mx2.gfk.ru (mx2.gfk.ru [84.21.231.139])
	by mx1.freebsd.org (Postfix) with ESMTP id 4311A13C468
	for <freebsd-current@freebsd.org>; Sat, 12 May 2007 06:51:37 +0000 (UTC)
	(envelope-from Yuriy.Tsibizov@gfk.ru)
Received: from ex.hhp.local by mx2.gfk.ru (MDaemon PRO v9.5.6)
	with ESMTP id md50000070782.msg
	for <freebsd-current@freebsd.org>; Sat, 12 May 2007 10:53:47 +0400
Received: from dialup-chibis.gfk.ru ([10.0.6.45]) by ex.hhp.local with
	Microsoft SMTPSVC(6.0.3790.1830); Sat, 12 May 2007 10:53:42 +0400
Date: Sat, 12 May 2007 10:51:25 +0400 (MSD)
From: Yuriy Tsibizov <Yuriy.Tsibizov@gfk.ru>
X-X-Sender: chibis@free.home.local
To: freebsd-current@freebsd.org
In-Reply-To: <20070509125720.U911@free.home.local>
Message-ID: <20070512104053.J943@free.home.local>
References: <20070509125720.U911@free.home.local>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed
X-OriginalArrivalTime: 12 May 2007 06:53:43.0402 (UTC)
	FILETIME=[47B3CCA0:01C79462]
X-Spam-Processed: mx2.gfk.ru, Sat, 12 May 2007 10:53:47 +0400
	(not processed: message from valid local sender)
X-MDRemoteIP: 10.0.0.30
X-Return-Path: Yuriy.Tsibizov@gfk.ru
X-Envelope-From: Yuriy.Tsibizov@gfk.ru
X-MDaemon-Deliver-To: freebsd-current@freebsd.org
X-MDAV-Processed: mx2.gfk.ru, Sat, 12 May 2007 10:53:47 +0400
Subject: Re: geom_label problems when MS-DOS FS label is blank (all spaces)
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>, 
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 12 May 2007 06:51:38 -0000

> In this situation libdisk can't parse kern.geom.conftxt and sysinstall 
> exits with BARF 171 message.

It can be fixed with following patch. "all spaces" volume will be treated 
like a volume without label.

Index: g_label_msdosfs.c
===================================================================
RCS file: /home/ncvs/src/sys/geom/label/g_label_msdosfs.c,v
retrieving revision 1.6
diff -u -r1.6 g_label_msdosfs.c
--- g_label_msdosfs.c	30 Sep 2006 08:16:49 -0000	1.6
+++ g_label_msdosfs.c	12 May 2007 06:39:23 -0000
@@ -200,7 +200,7 @@
  	}

  endofchecks:
-	for (i = size - 1; i > 0; i--) {
+	for (i = size - 1; i >= 0; i--) {
  		if (label[i] == '\0')
  			continue;
  		else if (label[i] == ' ')


Yuriy.