From owner-svn-src-head@freebsd.org Wed Dec 21 19:53:10 2016 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id E4979C8BF5B; Wed, 21 Dec 2016 19:53:10 +0000 (UTC) (envelope-from etnapierala@gmail.com) Received: from mail-wm0-x242.google.com (mail-wm0-x242.google.com [IPv6:2a00:1450:400c:c09::242]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 725B31C67; Wed, 21 Dec 2016 19:53:10 +0000 (UTC) (envelope-from etnapierala@gmail.com) Received: by mail-wm0-x242.google.com with SMTP id m203so32312900wma.3; Wed, 21 Dec 2016 11:53:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:mail-followup-to :references:mime-version:content-disposition:in-reply-to:user-agent; bh=sJ6d9Rgr4VESNrGVaQonFmMIplNLPUIfj67Fwg0u3HY=; b=W5P1TM0+DCK+3pDDZKP7uIxniuX4Q3V/vdtgIlYhCqBf6atBkOqTQ6rlZtIWK0hFhl oDThsUovR3hNhMDtkOuGffeBdI8pMsulrIUz8eHAjti71PXIXhuqX/s9x2oxykcOoPI4 O4GyjfwC3SpWnEc16gGPnRfIJ0ZdQO8c0hB89HVoQbAfeIANufgv8Wn56Mr8lbgBMBHO l9Z5rTQKC1UjbKux47iJ/ahzTkA7Bj9Y8W4BTyrBlEa4hGH10Iatch/qTCobX8egrBP6 ofKXZv/withpQDmx1gZypRW4zXPfqiFFBa/NSu5ysAAn3Vz9Jg9SzlqgCsgAkwT0BPBe FSww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :mail-followup-to:references:mime-version:content-disposition :in-reply-to:user-agent; bh=sJ6d9Rgr4VESNrGVaQonFmMIplNLPUIfj67Fwg0u3HY=; b=YwxWL4A4ifakqHyIFXjtLPXkBM/T7juBjMDff/hWJmrU5oWBHYnqyyJccvvOeQ+eEN W/eU8whBbm94ctrmZnelJyr5OXZGDQvOYCHUTPbs8Dh8V+zrIsaG1kHhkwyQPs6ig/Lb gLcutkLH0Yheao49RP9Tyr5Tt02I4ubOod5cskH1ouLcBVYTKrefhkt2LrlXxUW6hYFc 1yVs6J/VBEEX625ajVZeY7fYvQVTaYOmPjgVk0SXxvUem9NQLvuEhcUf9f+0yZ7UDzCi MX4WUZdS/mRt8W+CmcD6TDlASu/G+MbMSUCrvWjVFlWt/19eIwhGRlqqaqlbRYARS1K6 U4iw== X-Gm-Message-State: AIkVDXLaBW7qB/lx62EbQDtjxMbERHzyzsk0cUezCQni1duhIv2XVPJ0d2M4pxMzImiDMQ== X-Received: by 10.28.174.194 with SMTP id x185mr6332400wme.4.1482349987883; Wed, 21 Dec 2016 11:53:07 -0800 (PST) Received: from brick (abvn235.neoplus.adsl.tpnet.pl. [83.8.211.235]) by smtp.gmail.com with ESMTPSA id w7sm28553311wmd.24.2016.12.21.11.53.06 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 21 Dec 2016 11:53:07 -0800 (PST) Sender: =?UTF-8?Q?Edward_Tomasz_Napiera=C5=82a?= Date: Wed, 21 Dec 2016 20:53:04 +0100 From: Edward Tomasz =?utf-8?Q?Napiera=C5=82a?= To: Ed Schouten Cc: Adrian Chadd , Ed Schouten , "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Subject: Re: svn commit: r310354 - in head/usr.sbin: . prometheus_sysctl_exporter Message-ID: <20161221195304.GA3396@brick> Mail-Followup-To: Ed Schouten , Adrian Chadd , Ed Schouten , "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" References: <201612210829.uBL8Tijt041811@repo.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.7.2 (2016-11-26) X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 21 Dec 2016 19:53:11 -0000 On 1221T2006, Ed Schouten wrote: > Hi Adrian, > > 2016-12-21 18:32 GMT+01:00 Adrian Chadd : > > Maybe just "sysctl_export" would be fine. > > Good point. Almost all Prometheus metrics exporters use this naming scheme: > > ~80%: ${foo}_exporter > ~20%: prometheus_${foo}_exporter > > Examples; > > - https://github.com/prometheus/node_exporter > - https://github.com/ewr/elasticsearch_exporter > - https://github.com/jonnenauha/prometheus_varnish_exporter > > The reason why I went for the 'prometheus_' prefix was mainly because > of the following totally subjective reasons: > > - I didn't want to wreck tab completion. Right now if you type in > 'sysc' and press tab, it tends to complete to 'sysctl'. That's a very good reason; it could also be fixed by moving it from sbin/ to libexec/. > - This tool is part of the base system, meaning that it will be > present even if the user did nothing special. This is why I wanted the > name to be a bit more self-documenting. > - Thinking ahead: what if we're going to add exporters for other > things as well? E.g., for Sendmail, sshd, ftpd, HAST, etc. In that > case it would be nicer if those exporters shared a common prefix. Another advantage of having the "prometheus" in the name is that it's easily googlable, and it clearly indicates the "protocol" (in the wide meaning) one is supposed to use to talk to it.