From owner-freebsd-current@FreeBSD.ORG Tue Sep 2 21:29:29 2003 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id ADD5116A4BF for ; Tue, 2 Sep 2003 21:29:29 -0700 (PDT) Received: from possum.icir.org (possum.icir.org [192.150.187.67]) by mx1.FreeBSD.org (Postfix) with ESMTP id 0BC1D43FE0 for ; Tue, 2 Sep 2003 21:29:29 -0700 (PDT) (envelope-from pavlin@possum.icir.org) Received: from possum.icir.org (localhost [127.0.0.1]) by possum.icir.org (8.12.8p1/8.12.3) with ESMTP id h834TSam099735; Tue, 2 Sep 2003 21:29:28 -0700 (PDT) (envelope-from pavlin@possum.icir.org) Message-Id: <200309030429.h834TSam099735@possum.icir.org> To: freebsd-current@freebsd.org Date: Tue, 02 Sep 2003 21:29:28 -0700 From: Pavlin Radoslavov cc: pavlin@icir.org Subject: Problem with building PicoBSD with CURRENT tree X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 03 Sep 2003 04:29:29 -0000 It appears that a recent change to src/Makefile.inc1 has broken the build of PicoBSD when I attempt to build CURRENT on FreeBSD-4.8 host: *** PICO_OBJ is /home/possum/u0/pavlin/freebsd_src/../usr/obj-pico/picobsd/pim make: no target to make. "/scratch/possum/u1/pavlin/FreeBSD/HEAD.cvs/src/Makefile.inc1", line 147: warning: "make -f /dev/null -m /scratch/possum/u1/pavlin/FreeBSD/HEAD.cvs/src/share/mk CPUTYPE=i386 -V CPUTYPE" returned non-zero status "/scratch/possum/u1/pavlin/FreeBSD/HEAD.cvs/src/Makefile.inc1", line 761: warning: String comparison operator should be either == or != "/scratch/possum/u1/pavlin/FreeBSD/HEAD.cvs/src/Makefile.inc1", line 761: Malformed conditional ((!defined(NO_RESCUE) || defined(RELEASEDIR)) && (${TARGET_ARCH} != ${MACHINE_ARCH} || ${BOOTSTRAPPING} < 501101)) "/scratch/possum/u1/pavlin/FreeBSD/HEAD.cvs/src/Makefile.inc1", line 761: Missing dependency operator "/scratch/possum/u1/pavlin/FreeBSD/HEAD.cvs/src/Makefile.inc1", line 763: if-less endif "/scratch/possum/u1/pavlin/FreeBSD/HEAD.cvs/src/Makefile.inc1", line 763: Need an operator make: fatal errors encountered -- cannot continue The change that breaks the build is in revision 1.388 of Makefile.inc1; see http://www.freebsd.org/cgi/cvsweb.cgi/src/Makefile.inc1.diff?r1=1.387&r2=1.388 The particular command in the release/picobsd/build/picobsd script that triggers the above problem is: eval export `cd ${SRC}; make -f Makefile.inc1 -V WMAKEENV` Reversing back the Makefile.inc1 change by applying the following simple nit does fix the problem: --- Makefile.inc1 Tue Sep 2 21:01:02 2003 +++ Makefile.inc1.FIX Tue Sep 2 19:21:49 2003 @@ -758,7 +758,7 @@ .if (!defined(NO_RESCUE) || \ defined(RELEASEDIR)) && \ - (${TARGET_ARCH} != ${MACHINE_ARCH} || ${BOOTSTRAPPING} < 501101) + (${TARGET_ARCH} != ${MACHINE_ARCH} || ${BOOTSTRAPPING} < 501101 ) _crunchide= usr.sbin/crunch/crunchide .endif I believe that the particular change to Makefile.inc1 was made with the assumption that we are always going to use the new "make" version that comes with FreeBSD-current. However, even if I use the new "make" to run the above command, I still have an error: pavlin@possum[622] ../usr/obj-pico/scratch/possum/u1/pavlin/FreeBSD/HEAD.cvs/src/make.i386/make -f Makefile.inc1 -V WMAKEENV ../usr/obj-pico/scratch/possum/u1/pavlin/FreeBSD/HEAD.cvs/src/make.i386/make: not found "/scratch/possum/u1/pavlin/FreeBSD/HEAD.cvs/src/Makefile.inc1", line 147: warning: "../usr/obj-pico/scratch/possum/u1/pavlin/FreeBSD/HEAD.cvs/src/make.i386/make -f /dev/null -m /scratch/possum/u1/pavlin/FreeBSD/HEAD.cvs/src/share/mk CPUTYPE=i386 -V CPUTYPE" returned non-zero status "/scratch/possum/u1/pavlin/FreeBSD/HEAD.cvs/src/Makefile.inc1", line 149: CPUTYPE global should be set with ?=. Exit 1 Thanks, Pavlin P.S. Running make with -DALWAYS_CHECK_MAKE does not do the trick, because it has no effect inside Makefile.inc1 :)