From owner-freebsd-bugs@FreeBSD.ORG Wed Jan 29 13:50:01 2014 Return-Path: Delivered-To: freebsd-bugs@smarthost.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id DE6BB3C1 for ; Wed, 29 Jan 2014 13:50:00 +0000 (UTC) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id B93FB19F1 for ; Wed, 29 Jan 2014 13:50:00 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.7/8.14.7) with ESMTP id s0TDo089060390 for ; Wed, 29 Jan 2014 13:50:00 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.7/8.14.7/Submit) id s0TDo0h4060389; Wed, 29 Jan 2014 13:50:00 GMT (envelope-from gnats) Resent-Date: Wed, 29 Jan 2014 13:50:00 GMT Resent-Message-Id: <201401291350.s0TDo0h4060389@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Sébastien Santoro Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id E0443278 for ; Wed, 29 Jan 2014 13:44:52 +0000 (UTC) Received: from oldred.freebsd.org (oldred.freebsd.org [IPv6:2001:1900:2254:206a::50:4]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id B1D701993 for ; Wed, 29 Jan 2014 13:44:52 +0000 (UTC) Received: from oldred.freebsd.org ([127.0.1.6]) by oldred.freebsd.org (8.14.5/8.14.7) with ESMTP id s0TDiqHI092128 for ; Wed, 29 Jan 2014 13:44:52 GMT (envelope-from nobody@oldred.freebsd.org) Received: (from nobody@localhost) by oldred.freebsd.org (8.14.5/8.14.5/Submit) id s0TDiqg2092123; Wed, 29 Jan 2014 13:44:52 GMT (envelope-from nobody) Message-Id: <201401291344.s0TDiqg2092123@oldred.freebsd.org> Date: Wed, 29 Jan 2014 13:44:52 GMT From: Sébastien Santoro To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Subject: misc/186235: [www/npm] [patch] port depends of node/node-devel packages X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 29 Jan 2014 13:50:01 -0000 >Number: 186235 >Category: misc >Synopsis: [www/npm] [patch] port depends of node/node-devel packages >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Wed Jan 29 13:50:00 UTC 2014 >Closed-Date: >Last-Modified: >Originator: Sébastien Santoro >Release: 10.0-RELEASE >Organization: >Environment: FreeBSD threyscend.drake 10.0-RELEASE FreeBSD 10.0-RELEASE #0 r260789: Thu Jan 16 22:34:59 UTC 2014 root@snap.freebsd.org:/usr/obj/usr/src/sys/GENERIC amd64 >Description: RUN_DEPENDS doesn't look for /usr/local/bin/node, but for a Node package: .if ${PORT_OPTIONS:MNODE_DEVEL} RUN_DEPENDS+= node-devel>=0.8.0:${PORTSDIR}/www/node-devel .else RUN_DEPENDS+= node>=0.8.0:${PORTSDIR}/www/node .endif The package doesn't do any operation dependings of this setting, so could look for node binary instead. A use case is a Node shared hosting facility with on two staging servers a development version available in continuous integration recompiling each hour from Node repository. * * * I guess the current choice comes from versioning. We're at v0.10.25, dev version is at 0.11. 0.8.0 were release June 25, 2012, which is quite recently, but from the 0.8.0 release announcement: * "Node got a lot faster." * "Node got more stable." * "You can do stuff with file descriptors again." And indeed, the 0.6 version were barely usable, so I really doubt the scenario "someone wants to install www/npm on an old node" will occur. >How-To-Repeat: A. (1) Install node manually, or node-devel without editing www/npm port config (2) Install www/npm package and see it install an already installed Node or complaint about conflict B. (1) Install www/node-devel or www/node (2) In www/npm port config, ask node or node-devel, the other setting from 1 (3) Install www/npm package it will complaints about conflict >Fix: Index: Makefile =================================================================== --- Makefile (revision 341737) +++ Makefile (working copy) @@ -48,9 +48,9 @@ .include .if ${PORT_OPTIONS:MNODE_DEVEL} -RUN_DEPENDS+= node-devel>=0.8.0:${PORTSDIR}/www/node-devel +RUN_DEPENDS+= ${PREFIX}/bin/node:${PORTSDIR}/www/node-devel .else -RUN_DEPENDS+= node>=0.8.0:${PORTSDIR}/www/node +RUN_DEPENDS+= ${PREFIX}/bin/node:${PORTSDIR}/www/node .endif post-patch: >Release-Note: >Audit-Trail: >Unformatted: