From owner-freebsd-current@FreeBSD.ORG Sat Feb 19 01:28:06 2011 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 4D61E106566C for ; Sat, 19 Feb 2011 01:28:06 +0000 (UTC) (envelope-from imb@protected-networks.net) Received: from sarah.protected-networks.net (sarah.protected-networks.net [IPv6:2001:470:1f07:4e1::1]) by mx1.freebsd.org (Postfix) with ESMTP id 10D508FC08 for ; Sat, 19 Feb 2011 01:28:06 +0000 (UTC) Received: from toshi.auburn.protected-networks.net (toshi.auburn.protected-networks.net [202.12.127.84]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (Client CN "Iain Butler", Issuer "RSA Class 2 Personal CA" (verified OK)) (Authenticated sender: imb@protected-networks.net) by sarah.protected-networks.net (Postfix) with ESMTPSA id 045D16137; Fri, 18 Feb 2011 20:28:04 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=protected-networks.net; s=200705; t=1298078885; bh=uUsU0HYwPG0vucpfsv9X20AUbfjziouYsXAVa84kMOo=; h=Message-ID:Date:From:MIME-Version:To:CC:Subject:References: In-Reply-To:Content-Type:Content-Transfer-Encoding; b=GvYtXnxky0bO9zd7kzzGgkKBjhUp7Jo482I/3G7eS3CPI2hnlseMPmnlfObxHEnWV CiV8G/XLD+f07pX6eApCWD7vz+nIVUAogGdpaypa7OAkYxxDeKJNYte+QswaOgs DomainKey-Signature: a=rsa-sha1; s=200509; d=protected-networks.net; c=nofws; q=dns; h=message-id:date:from:user-agent:mime-version:to:cc:subject: references:in-reply-to:x-enigmail-version:openpgp:content-type:content-transfer-encoding; b=G19a+q/X91w5qogw0D1IczZHo0gCyEyBx6/f48HeNxHMCJcPuB9tnwIuqAJ5Qwxr/ UC4cXO+ZCIZbX2FT9eIIYB8Ygw0a1hysucHJHtWfXtyd33CibzLagYHJmMvNZlU Message-ID: <4D5F1CA3.3040408@protected-networks.net> Date: Fri, 18 Feb 2011 20:28:03 -0500 From: Michael Butler User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; en-US; rv:1.9.2.13) Gecko/20110116 Thunderbird/3.1.7 MIME-Version: 1.0 To: Kostik Belousov References: <20110218215330.GA9549@mail.auburn.protected-networks.net> <20110218221108.GB78089@deviant.kiev.zoral.com.ua> <20110218223358.GB9549@mail.auburn.protected-networks.net> <20110218232218.GC78089@deviant.kiev.zoral.com.ua> In-Reply-To: <20110218232218.GC78089@deviant.kiev.zoral.com.ua> X-Enigmail-Version: 1.1.2 OpenPGP: id=0442D492 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: freebsd-current@freebsd.org Subject: Re: rename on socket fails :-( X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 19 Feb 2011 01:28:06 -0000 -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 02/18/11 18:22, Kostik Belousov wrote: > > The patch below fixed the bug for the test extracted from your kdump. > > diff --git a/sys/ufs/ufs/ufs_vnops.c b/sys/ufs/ufs/ufs_vnops.c > index 084971e..34b1758 100644 > --- a/sys/ufs/ufs/ufs_vnops.c > +++ b/sys/ufs/ufs/ufs_vnops.c > @@ -1295,7 +1295,9 @@ relock: > newparent = tdp->i_number; > doingdirectory = 1; > } > - if (fvp->v_mountedhere != NULL || (tvp && tvp->v_mountedhere != NULL)) { > + if ((fvp->v_type == VDIR && fvp->v_mountedhere != NULL) || > + (tvp != NULL && tvp->v_type == VDIR && > + tvp->v_mountedhere != NULL)) { > error = EXDEV; > goto unlockout; > } To confirm - this fixes the issue - thanks! imb -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (FreeBSD) iEYEARECAAYFAk1fHKMACgkQQv9rrgRC1JKt+ACgv6Cx9NVZapjDn0bMUskLs7jM ym8An0YIQKWY0dcJ12qX9zV4c6ePzgD+ =JQxR -----END PGP SIGNATURE-----