From owner-svn-src-head@freebsd.org  Mon Sep 30 19:10:39 2019
Return-Path: <owner-svn-src-head@freebsd.org>
Delivered-To: svn-src-head@mailman.nyi.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.nyi.freebsd.org (Postfix) with ESMTP id EE3E812FC0B;
 Mon, 30 Sep 2019 19:10:39 +0000 (UTC)
 (envelope-from kaktus@FreeBSD.org)
Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 server-signature RSA-PSS (4096 bits)
 client-signature RSA-PSS (4096 bits) client-digest SHA256)
 (Client CN "smtp.freebsd.org",
 Issuer "Let's Encrypt Authority X3" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id 46hsRz5zlkz4K6B;
 Mon, 30 Sep 2019 19:10:39 +0000 (UTC)
 (envelope-from kaktus@FreeBSD.org)
Received: from [172.20.0.193] (193-106-244-222.noc.fibertech.net.pl
 [193.106.244.222])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 (Authenticated sender: kaktus/mail)
 by smtp.freebsd.org (Postfix) with ESMTPSA id D37A128C2A;
 Mon, 30 Sep 2019 19:10:38 +0000 (UTC)
 (envelope-from kaktus@FreeBSD.org)
From: =?utf-8?Q?Pawe=C5=82_Biernacki?= <kaktus@FreeBSD.org>
Content-Type: text/plain;
	charset=us-ascii
Content-Transfer-Encoding: quoted-printable
Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.11\))
Subject: Re: svn commit: r352914 - head/sys/compat/linux
Date: Mon, 30 Sep 2019 21:10:35 +0200
References: <201909301905.x8UJ5EB0029624@repo.freebsd.org>
To: src-committers@freebsd.org, svn-src-all@freebsd.org,
 svn-src-head@freebsd.org
In-Reply-To: <201909301905.x8UJ5EB0029624@repo.freebsd.org>
Message-Id: <30C3B920-8F83-4677-A984-4701A505D4AC@FreeBSD.org>
X-Mailer: Apple Mail (2.3445.104.11)
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 30 Sep 2019 19:10:40 -0000



> On 30 Sep 2019, at 21:05, Pawel Biernacki <kaktus@FreeBSD.org> wrote:
>=20
> Author: kaktus
> Date: Mon Sep 30 19:05:14 2019
> New Revision: 352914
> URL: https://svnweb.freebsd.org/changeset/base/352914
>=20
> Log:
>  linux_renameat2: don't add extra \n on error.
>=20
>  linux_msg() already adds \n at the end of all messages.
>=20
>  Reported by:	emaste, kib (mentor), mjg (mentor)
>  Reviewed by:	kib (mentor), mjg (mentor)

Should be:
Reviewed by:	emaste, kib (mentor), mjg (mentor)
Approved by:	kib (mentor), mjg (mentor)


>  Differential Revision:	https://reviews.freebsd.org/D21852
>=20
> Modified:
>  head/sys/compat/linux/linux_file.c
>=20
> Modified: head/sys/compat/linux/linux_file.c
> =
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D
> --- head/sys/compat/linux/linux_file.c	Mon Sep 30 19:03:43 2019	=
(r352913)
> +++ head/sys/compat/linux/linux_file.c	Mon Sep 30 19:05:14 2019	=
(r352914)
> @@ -704,7 +704,7 @@ linux_renameat2(struct thread *td, struct =
linux_rename
> 	int error, olddfd, newdfd;
>=20
> 	if (args->flags !=3D 0) {
> -		linux_msg(td, "renameat2 unsupported flags 0x%x\n",
> +		linux_msg(td, "renameat2 unsupported flags 0x%x",
> 		    args->flags);
> 		return (EINVAL);
> 	}