From owner-freebsd-ports@FreeBSD.ORG Sun May 24 19:56:04 2009 Return-Path: Delivered-To: freebsd-ports@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 1818A106566B for ; Sun, 24 May 2009 19:56:04 +0000 (UTC) (envelope-from pav@FreeBSD.org) Received: from raven.customer.vol.cz (raven.customer.vol.cz [195.250.144.108]) by mx1.freebsd.org (Postfix) with ESMTP id 711D08FC18 for ; Sun, 24 May 2009 19:56:03 +0000 (UTC) (envelope-from pav@FreeBSD.org) Received: from [192.168.0.23] (r5af140.net.upc.cz [86.49.39.140]) (authenticated bits=0) by raven.customer.vol.cz (8.14.3/8.14.3) with ESMTP id n4OJtuYQ044798; Sun, 24 May 2009 21:55:56 +0200 (CEST) (envelope-from pav@FreeBSD.org) From: Pav Lucistnik To: David Naylor In-Reply-To: <200905242007.06917.naylor.b.david@gmail.com> References: <20090522.195350.193746535.chat95@mac.com> <20090524190131.0b30b101@it.buh.tecnik93.com> <1243182477.18007.18.camel@hood.oook.cz> <200905242007.06917.naylor.b.david@gmail.com> Content-Type: multipart/signed; micalg="pgp-sha1"; protocol="application/pgp-signature"; boundary="=-AUB9x9XsZQDcuhZviMHD" Date: Sun, 24 May 2009 21:55:56 +0200 Message-Id: <1243194956.21797.4.camel@hood.oook.cz> Mime-Version: 1.0 X-Mailer: Evolution 2.26.2 FreeBSD GNOME Team Port X-Spam-Score: -1.48 () AWL,BAYES_00,RCVD_IN_PBL X-Scanned-By: MIMEDefang 2.64 on 195.250.144.108 Cc: pgollucci@p6m7g8.com, Ion-Mihai Tetcu , freebsd-ports@FreeBSD.org Subject: Re: MAKE_JOBS_UNSAFE (some more ports) X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: pav@FreeBSD.org List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 24 May 2009 19:56:04 -0000 --=-AUB9x9XsZQDcuhZviMHD Content-Type: text/plain; charset="ISO-8859-2" Content-Transfer-Encoding: quoted-printable David Naylor p=ED=B9e v ne 24. 05. 2009 v 20:07 +0200: > On Sunday 24 May 2009 18:27:57 Pav Lucistnik wrote: > > Ion-Mihai Tetcu p=ED=B9e v ne 24. 05. 2009 v 19:01 +0300: > > > On Sun, 24 May 2009 16:10:23 +0200 > > > > > > Pav Lucistnik wrote: > > > > Ion-Mihai Tetcu p=ED=B9e v so 23. 05. 2009 v 13:51 +0300: > > > > > > > - MAKE_JOBS_NUMBER defaults (but user defined) to number of > > > > > > > cores > > > > > > > > > > This part looks OK, I wonder if there's any reason t ain't like t= his > > > > > now; Pav? > > > > > -.if defined(MAKE_JOBS_NUMBER) > > > > > +MAKE_JOBS_NUMBER?=3D `${SYSCTL} -n kern.smp.cpus` > > > > > _MAKE_JOBS=3D -j${MAKE_JOBS_NUMBER} > > > > > -.else > > > > > -_MAKE_JOBS=3D -j`${SYSCTL} -n kern.smp.cpus` > > > > > -.endif > > > > > > > > Wouldn't that mean an evaluation of the backtick command in every > > > > make(1) invocation? That would be highly undesirable. >=20 > I don't believe that is the case. =20 >=20 > Here is what I get with the patch applied (MAKE_JOBS_NUMBER not defined): > /usr/ports/editors/openoffice.org-3# make -V MAKE_JOBS_NUMBER -V _MAKE_JO= BS > `/sbin/sysctl -n kern.smp.cpus` > -j`/sbin/sysctl -n kern.smp.cpus` >=20 > Wouldn't this indicate that the backtick command is not being evaluated? Seems correct. But explain again, why you need this change? You cannot use it to evaluate single/multi-processor machine in Makefile, as it's not expanded there either. And why should anything fail with -j1 but work with -j4? That is totally unexpected. --=20 Pav Lucistnik It whines, glows and fades... --=-AUB9x9XsZQDcuhZviMHD Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Toto je =?UTF-8?Q?digit=C3=A1ln=C4=9B?= =?ISO-8859-1?Q?_podepsan=E1?= =?UTF-8?Q?_=C4=8D=C3=A1st?= =?ISO-8859-1?Q?_zpr=E1vy?= -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (FreeBSD) iEYEABECAAYFAkoZpkgACgkQntdYP8FOsoI3sgCfRDhNxYYVcgr+apj+WhlrMufP mecAoK3UWYZybYOFXwIlkDq1W9Qwk+jU =sC0u -----END PGP SIGNATURE----- --=-AUB9x9XsZQDcuhZviMHD--