Date: Tue, 15 Sep 2015 23:50:49 +0200 From: Jan Beich <jbeich@FreeBSD.org> To: Jason Unovitch <junovitch@FreeBSD.org> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r396965 - head/textproc/smi Message-ID: <7fnr-2vye-wny@FreeBSD.org> In-Reply-To: <201509151504.t8FF4siS037935@repo.freebsd.org> (Jason Unovitch's message of "Tue, 15 Sep 2015 15:04:54 %2B0000 (UTC)") References: <201509151504.t8FF4siS037935@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--=-=-=
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable
Jason Unovitch <junovitch@FreeBSD.org> writes:
> textproc/smi: Remove PREFIX and MANPREFIX edits inherited through MAKE_=
ENV
>
> PR: 196224
> Reported by: jbeich
[...]
> post-patch:
> - ${REINPLACE_CMD} -e 's|^CC =3D .*|CC =3D ${CC}|' \
> - -e 's|^PREFIX =3D .*|PREFlX =3D ${PREFIX}|' \
> - -e 's|^MANPREFIX =3D .*|MANPREFIX =3D ${MANPREFIX}|' \
> - ${WRKSRC}/config.mk
> + ${REINPLACE_CMD} -e 's|^CC =3D .*|CC =3D ${CC}|' ${WRKSRC}/config.mk
>=20=20
> do-install:
> ${INSTALL_PROGRAM} ${WRKSRC}/smi ${STAGEDIR}${PREFIX}/bin
>
The commit message is misleading. PREFIX and MANPREFIX from MAKE_ENV
(unlike MAKE_ARGS) are not inherited but unused due to custom do-install
in the port.
do-install and post-patch existence suggest vendor Makefile isn't very
useful and is riddled with issues. For an unfixed one, see bug 203137.
--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1
iQF8BAEBCgBmBQJV+JK5XxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w
ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXREQjQ0MzY3NEM3RDIzNTc4NkUxNDkyQ0VF
NEM3Nzg4MzQ3OURCRERCAAoJEOTHeINHnb3bkyUIAIpOCa6Q8UL9CISDQrctHtY+
uKd6uCiFG5cvuQj/3blJWI6bzlIOfMOzDd35Enw/xO5+BinTeN/7oZCcz8GwlZ/+
KvBEvQH0sbb7I/Gvq64SqT6GJLAya+QT8zY4Ooo++Pj5pqBQX9iZDS0JkPYCkIg7
ECLW96T1/ibeoM5UT0hTVizKp4lQvJYD4e0L3PvaGhFNw+q0Pgu2q75CGLSLo8Lz
jDBNc8Gz9miC9d1vxnt2Rs6WlbAWSPGNpofCOW4cMq/huIydm9fpOcOIGK6vqrCi
K2lJmJBfYyY+4FVAKBi/iXWWg7zwcLW5LweYUUYI3tlI1WJqlpaS1m/4rOYMs5k=
=ET4a
-----END PGP SIGNATURE-----
--=-=-=--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?7fnr-2vye-wny>