From owner-freebsd-stable@freebsd.org Thu Mar 29 20:22:28 2018 Return-Path: Delivered-To: freebsd-stable@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 78F0CF73FAE for ; Thu, 29 Mar 2018 20:22:28 +0000 (UTC) (envelope-from kib@freebsd.org) Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id D254B83149; Thu, 29 Mar 2018 20:22:27 +0000 (UTC) (envelope-from kib@freebsd.org) Received: from tom.home (kib@localhost [127.0.0.1]) by kib.kiev.ua (8.15.2/8.15.2) with ESMTPS id w2TKMGpA046515 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Thu, 29 Mar 2018 23:22:20 +0300 (EEST) (envelope-from kib@freebsd.org) DKIM-Filter: OpenDKIM Filter v2.10.3 kib.kiev.ua w2TKMGpA046515 Received: (from kostik@localhost) by tom.home (8.15.2/8.15.2/Submit) id w2TKMGp5046514; Thu, 29 Mar 2018 23:22:16 +0300 (EEST) (envelope-from kib@freebsd.org) X-Authentication-Warning: tom.home: kostik set sender to kib@freebsd.org using -f Date: Thu, 29 Mar 2018 23:22:16 +0300 From: Konstantin Belousov To: Slawa Olhovchenkov Cc: Kevin Oberman , Gary Palmer , Eric van Gyzen , FreeBSD-STABLE Mailing List Subject: Re: KBI unexpexted change in stable/11 ? Message-ID: <20180329202216.GH1774@kib.kiev.ua> References: <20180328130903.GC6612@zxy.spb.ru> <316fb5cd-720b-e62a-cb56-5e9b722d05e9@vangyzen.net> <20180328153529.GL4305@zxy.spb.ru> <0b3b3294-7de4-cb1c-f85b-b846b46e8d75@vangyzen.net> <20180328164646.GC59700@in-addr.com> <20180329182143.GE6612@zxy.spb.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180329182143.GE6612@zxy.spb.ru> User-Agent: Mutt/1.9.4 (2018-02-28) X-Spam-Status: No, score=-2.9 required=5.0 tests=ALL_TRUSTED,BAYES_00 autolearn=ham autolearn_force=no version=3.4.1 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on tom.home X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 29 Mar 2018 20:22:28 -0000 On Thu, Mar 29, 2018 at 09:21:43PM +0300, Slawa Olhovchenkov wrote: > On Wed, Mar 28, 2018 at 11:25:08PM -0700, Kevin Oberman wrote: > > > > > > r325665 is previos point and is good. > > > > > r331615 crashed. > > > > > Can I use some script for bisect? > > > > > > > > I'm not aware of a script for this. The only tool I've used is "git > > > > bisect", which is very handy if you're already familiar with git. > > > > > > You may want to try devel/p5-App-SVN-Bisect. Never used it, so > > > no idea if it's functional or helpful, just found it doing a quick > > > search > > > > It would be nice if this could be fixed, but it is the case. > > r328475 bad (tzdata) > r328469 in progress (kib, sys/vm) > r328463 in progress (don't touch kernel) > r328462 good > > I mean r328469 break KBI. This commit is basically required to avoid significant confusion between HEAD and stable code. Its absense might make other merges impossible or quite hard. In fact, my opinion is that the real bug is elsewere. We do provide vm_map_min/max KPI, but the KPI is not KBI-stable because it encodes struct vm_map layout into binaries which (correctly) use KPI instead of directly accessing struct vm_map. This should be fixed, I put the review https://reviews.freebsd.org/D14902 for it.