From owner-cvs-all Thu Mar 1 9: 8: 9 2001 Delivered-To: cvs-all@freebsd.org Received: from pike.osd.bsdi.com (pike.osd.bsdi.com [204.216.28.222]) by hub.freebsd.org (Postfix) with ESMTP id B0B4D37B718; Thu, 1 Mar 2001 09:08:01 -0800 (PST) (envelope-from jhb@foo.osd.bsdi.com) Received: from foo.osd.bsdi.com (root@foo.osd.bsdi.com [204.216.28.137]) by pike.osd.bsdi.com (8.11.1/8.9.3) with ESMTP id f21H7pK08318; Thu, 1 Mar 2001 09:07:51 -0800 (PST) (envelope-from jhb@foo.osd.bsdi.com) Received: (from jhb@localhost) by foo.osd.bsdi.com (8.11.1/8.11.1) id f21H6h788620; Thu, 1 Mar 2001 09:06:43 -0800 (PST) (envelope-from jhb) Message-ID: X-Mailer: XFMail 1.4.0 on FreeBSD X-Priority: 3 (Normal) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 8bit MIME-Version: 1.0 In-Reply-To: <3726.983461458@axl.fw.uunet.co.za> Date: Thu, 01 Mar 2001 09:06:42 -0800 (PST) Organization: BSD, Inc. From: John Baldwin To: Sheldon Hearn Subject: Re: cvs commit: src/sys/kern init_main.c kern_fork.c kern_intr.c Cc: cvs-all@FreeBSD.org, cvs-committers@FreeBSD.org, Jake Burkholder Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG On 01-Mar-01 Sheldon Hearn wrote: > > > On Tue, 27 Feb 2001 18:53:45 PST, Jake Burkholder wrote: > >> Log: >> Sigh. Try to get priorities sorted out. Don't bother trying to >> update native priority, it is diffcult to get right and likely >> to end up horribly wrong. Use an honestly wrong fixed value >> that seems to work; [...] > > Hi Jake, > > This commit suffers from a commonly made mistake these days -- things > that should be XXX-style comments in the source code only make it into > the CVS history. > > I'm just making a noise here because this kind of thing worries me; it's > got nothing to do with you personally. :-) Actually, in this instance, the priority values probably aren't actually wrong. Although ideally all kthreads will have nativepri set to their "normal" priority, not just ithreads. > Ciao, > Sheldon. -- John Baldwin -- http://www.FreeBSD.org/~jhb/ PGP Key: http://www.Baldwin.cx/~john/pgpkey.asc "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message