From owner-svn-src-all@FreeBSD.ORG Sun Aug 3 15:45:52 2014 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id F2FE742B for ; Sun, 3 Aug 2014 15:45:52 +0000 (UTC) Received: from nm4.bullet.mail.bf1.yahoo.com (nm4.bullet.mail.bf1.yahoo.com [98.139.212.163]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id A3AA12D3C for ; Sun, 3 Aug 2014 15:45:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1407080359; bh=7PT45R27/H43iHCiuUO5jyJayDrqoL7I26Bljipxqw4=; h=Received:Received:Received:X-Yahoo-Newman-Id:X-Yahoo-Newman-Property:X-YMail-OSG:X-Yahoo-SMTP:Content-Type:Mime-Version:Subject:From:In-Reply-To:Date:Cc:Message-Id:References:To:X-Mailer; b=ZsAMOQYsgOfdmYLLZjvKno5/aXGmWzo+s5H1gFu1OGnSMZcDfwQyOXcPs/iutwjhcBzABfGZ1aMCtA7SIvDtPx0EeDdLSkp6UfMdwJlX7mZN4mX6a3auMCHv83OHQKWoOJKO5ztWrKWaaCOi2HrTx9uNEgJWVKJgI5ktIcBrF6BRTqw484TvJi2mwjAD6YwtUh2rCqHfR5mNcYUEWDmSomFr9WyrgluDaopeu8+vF5buG3i0of8mXeDOfpOVhNZJLAbieTUCg4BNocg+QN8SvQLoGDEOzeGtWfEAXq6KiQiymUx0U1wEH+UVFGNJpryJdIZZi48YngFRJ4EF+3Oujw== DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=s2048; d=yahoo.com; b=rU899zTdQaYdWsXqdxXAv5LvpbRGXP7QedNu0zKm+2WqrTsWloFhUECsenVSpFDZgIurFBE6nhiEeIB6p1CXdQ/2/O3d+nfZVtf1EgjglTUAn9v8PB48/RpLgROhvQ7scnjL4btGbLhvMDp9p28bSAajFRd0X92rqjRzZfoV9pZkvg6ZSxCjm4qjLzCXtGTfLF4JHEOjnNRSkif7XcDWWnsWcZuhFV61k4Hfj2VPnTCMbH1wAb0u2Xe/HOGFwZKoymO0EyZr02sW2ZZTIvBWgbgS1JT3AmJTA+WOSBCIGfQCqE3kwcKabUK7uGpj72H3ZbuiFm7OFpeTiuAX8rkq+w==; Received: from [98.139.214.32] by nm4.bullet.mail.bf1.yahoo.com with NNFMP; 03 Aug 2014 15:39:19 -0000 Received: from [68.142.230.65] by tm15.bullet.mail.bf1.yahoo.com with NNFMP; 03 Aug 2014 15:39:19 -0000 Received: from [127.0.0.1] by smtp222.mail.bf1.yahoo.com with NNFMP; 03 Aug 2014 15:39:19 -0000 X-Yahoo-Newman-Id: 819285.98655.bm@smtp222.mail.bf1.yahoo.com X-Yahoo-Newman-Property: ymail-3 X-YMail-OSG: V792YDkVM1lAOiJfCaDsbjeBeFwOIifEZpp4Sc3tpyxq9om __GGdfLo1DTh5Nr6i7XwRgJORT8QAyc2AzUBY9KDlzHFYJqFM_PS4W8X8tym NowkDVXyBPjw5yi3PSwIPpTldSscw524YxkF.xNtGNgHDc.Kgm004jcyIzKZ qgvjdABX_Y47XtbwhjL71kDM74rTN9h0pO7xi5Xi3XvhMW5muU0PRBRa6ShS zjYZxa2De58UljKkjUnWc1mP7eL4Npja6etH6TGn8RLnzmmayZxK546Ryejg AGZ8iSiSN.7z0k1ga1zbuUsjDkShklHPPn78HKublDE4uKK5WufrZvROMZd. 9PM43XvhvASTfYgTCmeq69k5BqUWiup72e28Vafs4wmFxn4I3kEV3bHVs6o2 qFvmKjb_1ldK3i.F0VvbTixr0doujagIRJzY_SKQ.j2cmu7CcvsvvxNRS6hr GD679EybrmDPXta_IWWYuP8iHpj3cHlB_Yz0ZDpGwm8VjiCfyOFbEUXWl79. VYr3OvXlUKnC9N4Wo X-Yahoo-SMTP: xcjD0guswBAZaPPIbxpWwLcp9Unf Mime-Version: 1.0 (Mac OS X Mail 7.3 \(1878.6\)) Subject: Re: svn commit: r268943 - in head: include lib/libc/stdlib From: Pedro Giffuni In-Reply-To: <65378493-7F05-4314-9809-E689891F6067@gmail.com> Date: Sun, 3 Aug 2014 10:39:15 -0500 Message-Id: <6A2B0200-EB23-459B-8E3F-6B1151C90D0E@freebsd.org> References: <201407211522.s6LFMnQo084633@svn.freebsd.org> <53CD430F.5040604@fastmail.net> <68E8EDB9-64DE-4037-9047-C8BEAD86801A@freebsd.org> <65378493-7F05-4314-9809-E689891F6067@gmail.com> To: Warner Losh X-Mailer: Apple Mail (2.1878.6) Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.18 Cc: svn-src-head@freebsd.org, Bruce Simpson , src-committers@freebsd.org, svn-src-all@freebsd.org X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 03 Aug 2014 15:45:53 -0000 Il giorno 03/ago/2014, alle ore 09:27, Warner Losh ha = scritto: >=20 > On Jul 21, 2014, at 12:51 PM, Pedro Giffuni wrote: >=20 >>=20 >> Il giorno 21/lug/2014, alle ore 11:42, Bruce Simpson = ha scritto: >>=20 >>> On 21/07/2014 16:22, Pedro F. Giffuni wrote: >>>> ] >>>> Log: >>>> Add re-entrant versions of the hash functions based on the GNU = api. >>>>=20 >>> What, if anything, can be done about qsort_r() API incompatibility? >>=20 >> qsort_r is non-standard and we did it first, plus we will want to = stay compatible with Apple :). >>=20 >> I guess we could do some ugly parameter swapping in the case where = _GNU_SOURCE >> is defined, but I won=92t volunteer to do that. >=20 > Are there any ABI considerations for the change? >=20 I would keep the qsort_r() ABI unchanged and add a GNU-compatible = version that is used only when _GNU_SOURCE (but not _BSD_SOURCE) is = defined. This would already be pretty messy by itself because some portable code = may define _GNU_SOURCE but still may try to use the Apple/BSD interface = under another #ifdef. Perhaps it=92s just better to leave our headers = alone and let the end-users do the wrapping. Pedro.