From owner-cvs-all@FreeBSD.ORG Fri Jun 15 09:11:52 2012 Return-Path: Delivered-To: cvs-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 19760106564A; Fri, 15 Jun 2012 09:11:52 +0000 (UTC) (envelope-from arved@FreeBSD.org) Received: from mail01.rise-w.com (mail01.rise-w.com [88.116.105.226]) by mx1.freebsd.org (Postfix) with ESMTP id BF6BD8FC14; Fri, 15 Jun 2012 09:11:51 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by mail01.rise-w.com (Postfix) with ESMTP id 94F7740E18B; Fri, 15 Jun 2012 11:11:43 +0200 (CEST) Received: from [192.168.129.170] (unknown [213.33.60.225]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.rise-world.com (Postfix) with ESMTPSA id BAAB340E18A; Fri, 15 Jun 2012 11:11:42 +0200 (CEST) Message-ID: <4FDAFC4E.2030502@FreeBSD.org> Date: Fri, 15 Jun 2012 11:11:42 +0200 From: =?UTF-8?B?VGlsbWFuIEtlc2tpbsO2eg==?= User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:12.0) Gecko/20120430 Thunderbird/12.0.1 MIME-Version: 1.0 To: Sunpoet Po-Chuan Hsieh References: <201206081528.q58FSovl055134@repoman.freebsd.org> <20120614163053.GA37124@bonjour.sunpoet.net> In-Reply-To: <20120614163053.GA37124@bonjour.sunpoet.net> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Cc: cvs-ports@FreeBSD.org, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/devel/pcsc-lite Makefile X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: **OBSOLETE** CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 15 Jun 2012 09:11:52 -0000 * Sunpoet Po-Chuan Hsieh [Fri, 15 Jun 2012 00:30:53 +0800]: > On Fri, Jun 08, 2012 at 03:28:50PM +0000, Tilman Keskinoz wrote: >> arved 2012-06-08 15:28:50 UTC >> >> FreeBSD ports repository >> >> Modified files: >> devel/pcsc-lite Makefile >> Log: >> Convert WITH_ style option to optionsng >> >> Revision Changes Path >> 1.61 +10 -12 ports/devel/pcsc-lite/Makefile > > Hi, > > The transition to new options framework is incorrect. > OPTIONS* was processed by bsd.options.mk. > Therefore OPTIONS* should be defined before the inclusion of bsd.port.pre.mk. > Since OSVERSION is defined in bsd.port.pre.mk it is not possible to just move the OPTIONS before bsd.port.pre.mk. Do you have a suggestion how this can be done? Or should the commit reverted? regards arved