From nobody Thu Feb 26 03:56:19 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4fLyLd2Xn7z6TBK5 for ; Thu, 26 Feb 2026 03:56:25 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R12" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4fLyLc5907z3CTK for ; Thu, 26 Feb 2026 03:56:24 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1772078184; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=fjH2bguszh4QHuj4ZqdTHuauBQimoQPN5BdKhRT0HwI=; b=E1KUBci1nX9tmjwwEetUNqHT4m6BEUjzIKUyD69kZzHnpuMnqegVg3ZttBAvDoUCzX75rS sJ+pbtEDBJGvOO/hbdUvWga7N8wsTjyx/J70v5qJkPZFtkjD4yoiruoQLFX9Q/gNnbwAoP WGPctASkW8ol0WNoF7PL32wesc33fUbyIZVX8DiGhwb+gVwT+qwxSiqEYrcypJKjcGAxB1 r9Xi4BxU03R2BqBWm4XYziHW0JekTx2L141oH3B0HA6z6vcX4uu0aB69o++n/ypL/ZKEOE gTzxlT8Q3ge8qYOhiDIeUAARVqASh0LaF/grXF/UsME20TOTmk1BAOLCHvrWRQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1772078184; a=rsa-sha256; cv=none; b=MmZkHrGUyAeSuNNEZSJFG19yYgm7Ds7vGll3qBZFs3Nh0ET3vdPC/r9LasHFCdV08I800D 8upfSXPvbpW/aqb38zGVl6FbmcVMU8EsK71OChHdcojjSXcTyNv/c4APzocf81gn5sULbB WsuaRxmjG98dPZimFFoHQtUVoVFhy0drQ2QMMDTmpANp5wddTjKPLySFtoPHvVRNqWP+KC DWTSFCM4xT2qoSrDyXZWlgDjqU4czGhLDQXvaCD5uMx1DvPjoQ16Us/qkBHfQAJi3EXA+L VROtZYh5N+Vki28wjs+sooOH7MCcuByg968UBMvvS0Hy40TVE0dAaMMeHXefQw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1772078184; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=fjH2bguszh4QHuj4ZqdTHuauBQimoQPN5BdKhRT0HwI=; b=KSzYIDqr2rr3gOIp+jWw1wiLqQo7jxRx+kIaKbRv1Lp4zJP1m2ilDViTU77SoohN4WVKTv qVxNEnZqub66S5IQA4CVAVw8Ke99W4hOK6zbtNpDTshHUDgGkeXbyEOJTuahKzF3Cx+hAs Dfa4cxA61qltY1clsusAzWQNCfVyLKE1tPQmoAy9jxgRRSEyIB1ehxAAge6eXkqbWaGKNK zb0eoApWwtduJOB6jSoOEZuzg0g0aBAMOdv65oJEjsN73mIOVPobmpC25vyco0AU2NSFx3 DO/09fXF0KWOyvqyNVPy01BC33AAn+nkTNIUHFKU67ptBVi4tiDrrFMAH7m9BQ== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4fLyLc3w3Gzwm for ; Thu, 26 Feb 2026 03:56:24 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 3237a by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Thu, 26 Feb 2026 03:56:19 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Adrian Chadd Subject: git: a54a36c40f07 - main - ath: migrate to new net80211 encryption key API List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: adrian X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: a54a36c40f07092ace706ccec8c3db6f6a1877c1 Auto-Submitted: auto-generated Date: Thu, 26 Feb 2026 03:56:19 +0000 Message-Id: <699fc463.3237a.681a6e95@gitrepo.freebsd.org> The branch main has been updated by adrian: URL: https://cgit.FreeBSD.org/src/commit/?id=a54a36c40f07092ace706ccec8c3db6f6a1877c1 commit a54a36c40f07092ace706ccec8c3db6f6a1877c1 Author: Adrian Chadd AuthorDate: 2026-02-26 03:49:27 +0000 Commit: Adrian Chadd CommitDate: 2026-02-26 03:49:27 +0000 ath: migrate to new net80211 encryption key API Migrate to the new encryption key API rather than poking at the key struct directly. Differential Revision: https://reviews.freebsd.org/D54479 --- sys/dev/ath/if_ath_keycache.c | 34 +++++++++++++++++++++++++--------- 1 file changed, 25 insertions(+), 9 deletions(-) diff --git a/sys/dev/ath/if_ath_keycache.c b/sys/dev/ath/if_ath_keycache.c index a58625ad2803..2b40a8940674 100644 --- a/sys/dev/ath/if_ath_keycache.c +++ b/sys/dev/ath/if_ath_keycache.c @@ -134,12 +134,16 @@ ath_keyset_tkip(struct ath_softc *sc, const struct ieee80211_key *k, * TX key goes at first index, RX key at the rx index. * The hal handles the MIC keys at index+64. */ - memcpy(hk->kv_mic, k->wk_txmic, sizeof(hk->kv_mic)); + memcpy(hk->kv_mic, + ieee80211_crypto_get_key_txmic_data(k), + sizeof(hk->kv_mic)); KEYPRINTF(sc, k->wk_keyix, hk, zerobssid); if (!ath_hal_keyset(ah, k->wk_keyix, hk, zerobssid)) return 0; - memcpy(hk->kv_mic, k->wk_rxmic, sizeof(hk->kv_mic)); + memcpy(hk->kv_mic, + ieee80211_crypto_get_key_rxmic_data(k), + sizeof(hk->kv_mic)); KEYPRINTF(sc, k->wk_keyix+32, hk, mac); /* XXX delete tx key on failure? */ return ath_hal_keyset(ah, k->wk_keyix+32, hk, mac); @@ -149,8 +153,12 @@ ath_keyset_tkip(struct ath_softc *sc, const struct ieee80211_key *k, * slot, just set key at the first index; the hal * will handle the rest. */ - memcpy(hk->kv_mic, k->wk_rxmic, sizeof(hk->kv_mic)); - memcpy(hk->kv_txmic, k->wk_txmic, sizeof(hk->kv_txmic)); + memcpy(hk->kv_mic, + ieee80211_crypto_get_key_rxmic_data(k), + sizeof(hk->kv_mic)); + memcpy(hk->kv_txmic, + ieee80211_crypto_get_key_txmic_data(k), + sizeof(hk->kv_txmic)); KEYPRINTF(sc, k->wk_keyix, hk, mac); return ath_hal_keyset(ah, k->wk_keyix, hk, mac); } @@ -160,13 +168,19 @@ ath_keyset_tkip(struct ath_softc *sc, const struct ieee80211_key *k, * NB: must pass MIC key in expected location when * the keycache only holds one MIC key per entry. */ - memcpy(hk->kv_mic, k->wk_txmic, sizeof(hk->kv_txmic)); + memcpy(hk->kv_mic, + ieee80211_crypto_get_key_txmic_data(k), + sizeof(hk->kv_txmic)); } else - memcpy(hk->kv_txmic, k->wk_txmic, sizeof(hk->kv_txmic)); + memcpy(hk->kv_txmic, + ieee80211_crypto_get_key_txmic_data(k), + sizeof(hk->kv_txmic)); KEYPRINTF(sc, k->wk_keyix, hk, mac); return ath_hal_keyset(ah, k->wk_keyix, hk, mac); } else if (k->wk_flags & IEEE80211_KEY_RECV) { - memcpy(hk->kv_mic, k->wk_rxmic, sizeof(hk->kv_mic)); + memcpy(hk->kv_mic, + ieee80211_crypto_get_key_rxmic_data(k), + sizeof(hk->kv_mic)); KEYPRINTF(sc, k->wk_keyix, hk, mac); return ath_hal_keyset(ah, k->wk_keyix, hk, mac); } @@ -210,8 +224,10 @@ ath_keyset(struct ath_softc *sc, struct ieee80211vap *vap, KASSERT(cip->ic_cipher < nitems(ciphermap), ("invalid cipher type %u", cip->ic_cipher)); hk.kv_type = ciphermap[cip->ic_cipher]; - hk.kv_len = k->wk_keylen; - memcpy(hk.kv_val, k->wk_key, k->wk_keylen); + hk.kv_len = ieee80211_crypto_get_key_len(k); + memcpy(hk.kv_val, + ieee80211_crypto_get_key_data(k), + ieee80211_crypto_get_key_len(k)); } else hk.kv_type = HAL_CIPHER_CLR;